From: Andrew Morton <akpm@linux-foundation.org>
To: Muchun Song <muchun.song@linux.dev>
Cc: joasantonio108@gmail.com, Oscar Salvador <osalvador@suse.de>,
David Hildenbrand <david@kernel.org>,
linux-mm@kvack.org, Hongbo Li <lihongbo22@huawei.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+91e1fc35f51774c479b2@syzkaller.appspotmail.com,
stable@vger.kernel.org
Subject: Re: [PATCH v3] hugetlbfs: move hugetlbfs_free_inode tracepoint to ->destroy_inode()
Date: Sun, 1 Nov 2026 18:40:37 -0800 [thread overview]
Message-ID: <20261101184037.5398ecf4c8348462a70b3968@linux-foundation.org> (raw)
In-Reply-To: <6FC96012-76AA-483B-BDA4-8E1C1ABB5FFE@linux.dev>
On Mon, 2 Nov 2026 10:24:38 +0800 Muchun Song <muchun.song@linux.dev> wrote:
> > static void hugetlbfs_destroy_inode(struct inode *inode)
> > {
> > + /*
> > + * Not in ->free_inode(): that runs from an RCU callback, when the
> > + * superblock the event reads may already be freed.
> > + */
>
> Since the trace point name has already been changed, the comment here
> doesn't seem to serve much purpose anymore, as there isn't any ambiguity.
>
> With the comment removed:
>
> Reviewed-by: Muchun Song <muchun.song@linux.dev>
Thanks. I've added a note-to-self to track this, but I've left the
patch in-place as your observation doesn't invalidate ongoing testing.
I always do this! But this doesn't appear to to be widely known :(.
My fault, really.
My notes-to-self are mastered in
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/pc/devel-series,
so the overly-curious can always look up status in there.
If a patch has a note, I won't progress it until that note has been
cleared away. This often involves sending annoying private emails to
people, or fixing stuff myself.
prev parent reply other threads:[~2026-11-02 2:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-01 13:48 Joas Antonio dos Santos via B4 Relay
2026-11-02 2:24 ` Muchun Song
2026-11-02 2:40 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261101184037.5398ecf4c8348462a70b3968@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=joasantonio108@gmail.com \
--cc=lihongbo22@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=stable@vger.kernel.org \
--cc=syzbot+91e1fc35f51774c479b2@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®