From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=202.12.124.144 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793569478; b=bvi3hekDcMNUDclnB8NIkTSL1+eLjKUnTo1ynt2vg80/TKsb3TjqLPkieihtTs83Epsy P5CSepLz20Bo8mWAI+geXtCqwhu1dC+pTm2o4/xxTLSMtP5EK3NKHnN3tNExtDP+26aww jf9ZiKhxFDWjrvPBRSVoJ6NS4g7zsLPh1mJJEBs+F5kmIj9RamoDx2OY+YYCDOzmKdAD0 V3CLklVKBCH8OetM3MdmZGaYmT2u07VGwNuSjpFzB/5KTGbh+phBDPiGFC6O+hcy2cY02 5u/A9fR5CL2wjVcMCAGYc1gBfX1mwav4rAdhu5RviWmplG8R1+Caeuey9NBYWGCqqzw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793569478; h=DMARC-Filter:Received:Received:DKIM-Signature:DKIM-Signature: X-DKIM2-Info:DKIM2-Signature:X-DKIM2-Info:Message-Instance: X-ME-Sender:X-ME-Received:X-ME-Proxy-Cause:X-ME-Proxy:Feedback-ID: Received:From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding; bh=1mMVj/Ylp3Zajqhxi8SVpg1+8G54F1N0w5aojxYs+sA=; b=iT864JR2jWIZGC7sZmunaHahVy2ZkMzyaGLskzFc70eou19t8GOXR4Qq0FOQci8FqUt5 yhzGL/ItXfifTJp6BRFxfyW/C10whMS2uCp85WJx5BgiWRf3np2KQLk+sb5bmQLLHVqME skZYQAhsZF2vMlTy6Uh6Ljm1hbs/iB9GyC15EP+S+gHqjRDS3+9mXLvqj0Ti8u48jsrX4 o2P0tzOc5S/KNn/BKen391PVdcUTEF41p9Fmx5y3mH/CNbOayYJXaBnbuMmjObDUVcJN9 vRn4qcKEk9V0wPw1NnAzco5U6sUy/fdBSCpTCpnyjPhv4eRbaHNFa48Y/uAKy2hv+mQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=fastmail.org; spf=pass smtp.mailfrom=fastmail.org; dkim=pass header.d=fastmail.org header.i=@fastmail.org header.a=rsa-sha256 header.s=fm2 header.b=AE7ESmBE; dkim=pass header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b="qs1HYt/q"; arc=none smtp.remote-ip=202.12.124.144 Received: from fout-b1-smtp.messagingengine.com (fout-b1-smtp.messagingengine.com [202.12.124.144]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EAD7606A326 for ; Sun, 1 Nov 2026 21:44:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 8EAD7606A326 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastmail.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=fastmail.org header.i=@fastmail.org header.a=rsa-sha256 header.s=fm2 header.b=AE7ESmBE; dkim=pass (2048-bit key, unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=qs1HYt/q Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfout.stl.internal (Postfix) with ESMTP id 08CFB1D001BE for ; Sun, 1 Nov 2026 16:44:32 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Sun, 01 Nov 2026 16:44:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1793569471; x= 1793655871; bh=1mMVj/Ylp3Zajqhxi8SVpg1+8G54F1N0w5aojxYs+sA=; b=A E7ESmBE6MDWnJYpCWrVoCtT02gtzn9NTvwMgTdQLAVXpaqkLfdprHvXCk+hWw3Rr kJseJgZJFHcb4LrtdJza5j83J0USbsdS2pJNE/LFkJvRmQaJhUmy0vrV1ACL+YhB vtuazn397TFJyNEUAX0urpWDOlkPLKrIAYURFRH9wtKLnXOn8fL1G3uwfbF45Z6i iktXULjLjUWTGAgoDpsGDtYWvz+pwCMo/sM4lXOmJOaLFWkdVOd+VrrXN4DPl6YN SzVvW9iHWqeFQ4zRbifW2R1wZ0jZgkI+vzLP29dYdJhN5a5ocE/B4wfUNr13h3ty UoKymClKGyy9DcWS9C6sw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1793569471; x=1793655871; bh=1 mMVj/Ylp3Zajqhxi8SVpg1+8G54F1N0w5aojxYs+sA=; b=qs1HYt/qSsqGmuJxz swYVYH9gVaA7p3NTG/mQG6XEAmkaYpUQBfKlPKVU0cFF3DxXkN9Leb2YrZLWPmgP MGM8X32lhCzyXpGX95vZkLEwO5CQWe3UQBv/2mz0JMq0V43wDI1Sd8KXcL5U6IAb SnHA9Jewbv5ZvDPaNuh0xuz0nWyiMBNvXaRoAXQ1N3UwUB2bdaUcUi3C7bFwD0hJ 1UljXX4y529kzVGIXp8LLJGJOWMuEkHQuXvhvFFTIeH07UZ5arutP3DCzsUy0wgV BHV/AblUTtDZyRz6tkIMmxdVF1p4g5W15gER9pTZH/WNC6/iCq0JDcHNHfEJPJun uTTuQ== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-08; repo=github.com/dkim2wg/interop; date=2026-10-28; sw=lmtpprox; action=sign d=fastmail.org a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1793569471; d=fastmail.org; mf=PGljYkBmYXN0bWFpbC5vcmc+; rt=PGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc+; s=fm2:rsa-sha256:Gg6taEAAV/02t3v8/9DQUlyyVqgMFlTYf4k5zaPcXyxxf8T 5y0GAdfb3rFvwjBMRF3jDZhwLzdxv8OLzxdtDLscHat19bPv28VoDlm5ufxlp9m8 4+c3UhHr9a7B7i/sTcDRLNNBcKFG6uCYZtXZrfAioog0Bl4mn0+He6jlvpCsIYVV oPxPt1hHTq0Ym2HDUiTL6F2AXN8kC1fI8EjUCHbBT3//VFqtMS1yWEeK36waa5NR gzS3uK1xnaF4XoWqG8ieIx27TX1dOTdaMwN2VJ/amEtQrzDGDaAMwHT8dX+BZvkT x/dXsyKBOOMBhun3UdYvVbJqj7QpMk+4pu3AO1Q==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-08; repo=github.com/dkim2wg/interop; date=2026-10-28; sw=lmtpprox; action=mi-m=1; hc=11; hn=cc,content-transfer-encoding,date,feedback-id,from, in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:s3D0c4wDMJC0cXlZMBmVc9tbHXMHJ9R/y4awmIrt6vw=:1mMVj/Ylp3Zajqhxi8SVpg1+8G54F1N0w5aojxYs+sA=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTF3NaYCNjGh8GDiquiV6BKvLn2bMNkt+4G+za2RoAktBLWK4JKctLjCjO6hCq7GZ3 7rnwthsvRlCv9UYVVrRk2loGsJl/F6CzE3Y9g/blAALzQq7ks4iNzx1pAEH39xpCVQjwek Qdvo+MRPAD6cZ5hbNV2cUyyi7rLPkDTTUiY0Q8K3T/RShhsHjaiUw1eZL0+wfnzlh58JrI zi5S0J6vutAyLNbOY/gRvta14zWuOVd0MrR5Xq1Ftmz4VmdX5u7yXtdViF9qBunFVxYfQI dXx4BY3mmXk8NIHWwjfPkKgSADDBBEvOWzA2U7xHjITY8hzbTtHKrAj00CXwbo8WMj/2iN U0Yngt/+ZCSV+YnN2kFxMjmgg0EqXvU0snjVa3O/XapJlMJpmEjOn+G0XgVWULXMRkmRCW 5ZCksZ0Uoyc69Ta+4AqkpulLhMP9UNsOpYnig+WtCdZ7kNio7xBOif3bHkQcjzxXZNjD2e 8QGhV6Y9sh0eT+FnXUmmY4G9YgvQDSmH/63M4qoWyCZJFkzW8JWCz1xGW29GZb/sA5RATX J+YXciU+QW0cDBORN7B1wKWWnRfDs1uTV+G63thGA1pZLSMdgbRUF+jIXMgD34d1eXdwKb ytVlbF8dFX8wzr88oUFe118J9VEBQwjhKIn1FCdrJZk6mXZy4YU9WusG535w X-ME-Proxy: Feedback-ID: ib53e4b78:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 1 Nov 2026 16:44:29 -0500 (EST) From: Ian Bridges To: Namjae Jeon Cc: Sergey Senozhatsky , Tom Talpey , ChenXiaoSong , linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ksmbd: enforce the DACL permission check on delete-on-close opens Date: Sun, 1 Nov 2026 15:44:20 -0600 Message-ID: <20261101214420.731352-1-icb@fastmail.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: <20261029140535.260498-1-icb@fastmail.org> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Namjae, Please drop this patch. I checked Sashiko's comments. It found two real problems in this patch. While fixing them I found that checking delete-on-close opens with smb_check_perm_dacl() makes some valid opens fail. Other issues need to be fixed first. I will send patches for those issues, then resend a fix for this bug once those patches are merged. Thanks, Ian