mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: Ettore Chimenti <ettore.chimenti@linaro.org>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
	Kevin Hilman <khilman@baylibre.com>,
	Roger Quadros <rogerq@kernel.org>,
	Tony Lindgren <tony@atomide.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Christopher Obbard <chris.obbard@oss.qualcomm.com>,
	Andrew Goodbody <andrew.goodbody@linaro.org>,
	Paul Walmsley <paul@pwsan.com>,
	Russell King <linux@armlinux.org.uk>,
	Rouven Czerwinski <rouven.czerwinski@linaro.org>,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 9/9] ARM: dts: omap: dm8168-evm: enable MUSB multipoint support
Date: Sun, 1 Nov 2026 22:34:10 +0100	[thread overview]
Message-ID: <20261101223410.25cc6477@kemnade.info> (raw)
In-Reply-To: <20261028-patch-ektor5-dm8168-dts-v2-9-4544429251e2@linaro.org>

On Wed, 28 Oct 2026 17:06:10 +0100
Ettore Chimenti <ettore.chimenti@linaro.org> wrote:

> From: Christopher Obbard <christopher.obbard@linaro.org>
> 
> The DM8168 USB controllers are used in host mode and must advertise
> multipoint support to the MUSB core. Without this the kernel disables
> external hub support and warns:
> 
>     musb-hdrc: kernel must disable external hubs, please fix the
> 	configuration
> 
> On the affected board this also prevents devices from enumerating
> reliably, with descriptor reads failing with -EPROTO:
> 
>     usb 1-1: device descriptor read/all, error -71
> 
> Set mentor,multipoint to the default value of 1 for both MUSB instances.
> With this enabled, USB devices enumerate successfully on the host ports.
> 
> Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
> Signed-off-by: Ettore Chimenti <ettore.chimenti@linaro.org>

Reviewed-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  arch/arm/boot/dts/ti/omap/dm8168-evm.dts | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/ti/omap/dm8168-evm.dts b/arch/arm/boot/dts/ti/omap/dm8168-evm.dts
> index a6d42766a496..4b4e4d850231 100644
> --- a/arch/arm/boot/dts/ti/omap/dm8168-evm.dts
> +++ b/arch/arm/boot/dts/ti/omap/dm8168-evm.dts
> @@ -198,17 +198,14 @@ &mmc1 {
>  	wp-gpios = <&gpio2 8 GPIO_ACTIVE_HIGH>;
>  };
>  
> -/* At least dm8168-evm rev c won't support multipoint, later may */
>  &usb0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&usb0_pins>;
> -	mentor,multipoint = <0>;
>  };
>  
>  &usb1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&usb1_pins>;
> -	mentor,multipoint = <0>;
>  };
>  
>  &sata {
> 


      reply	other threads:[~2026-11-01 21:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28 16:06 [PATCH v2 0/9] ARM: dts: omap: dm816x: fixes and peripheral updates for DM8168 SoC Ettore Chimenti
2026-10-28 16:06 ` [PATCH v2 1/9] ARM: dts: omap: dm816x: Add specific pinctrl config defines Ettore Chimenti
2026-10-30 10:31   ` Andreas Kemnade
2026-10-28 16:06 ` [PATCH v2 2/9] ARM: dts: omap: dm816x: use dedicated SoC pinctrl Ettore Chimenti
2026-10-30 10:34   ` Andreas Kemnade
2026-10-28 16:06 ` [PATCH v2 3/9] ARM: dts: omap: dm816x: Fix pinctrl range Ettore Chimenti
2026-11-01 21:18   ` Andreas Kemnade
2026-10-28 16:06 ` [PATCH v2 4/9] ARM: dts: omap: dm816x: refactor and align MMC node Ettore Chimenti
2026-10-30 10:30   ` Andreas Kemnade
2026-10-30 17:53     ` Ettore Chimenti
2026-10-28 16:06 ` [PATCH v2 5/9] ARM: dts: omap: dm816x: Correct speed for sysclk5 Ettore Chimenti
2026-11-01 21:29   ` Andreas Kemnade
2026-10-28 16:06 ` [PATCH v2 6/9] ARM: dts: omap: dm816x: Update USB node Ettore Chimenti
2026-10-28 16:06 ` [PATCH v2 7/9] ARM: dts: omap: dm816x: Remove hwmod code for USB Ettore Chimenti
2026-10-30 12:07   ` Andreas Kemnade
2026-10-28 16:06 ` [PATCH v2 8/9] ARM: dts: omap: dm8168-evm: Correct SD card pinmux Ettore Chimenti
2026-11-01 21:31   ` Andreas Kemnade
2026-10-28 16:06 ` [PATCH v2 9/9] ARM: dts: omap: dm8168-evm: enable MUSB multipoint support Ettore Chimenti
2026-11-01 21:34   ` Andreas Kemnade [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261101223410.25cc6477@kemnade.info \
    --to=andreas@kemnade.info \
    --cc=aaro.koskinen@iki.fi \
    --cc=andrew.goodbody@linaro.org \
    --cc=chris.obbard@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=ettore.chimenti@linaro.org \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=paul@pwsan.com \
    --cc=robh@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=rouven.czerwinski@linaro.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®