From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=71.18.227.1 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793629053; b=4XD8S0DTdaZnV//ISY65Kw6S9CRqwwgSM/1BoTjHfcbqHvTiG0bo2V8b8VcvY+I4+lIW qjlmjbNmR+yLwdv7bUuRcWKPIh62gc1vXaT0Pd33ot+CJCRqPdstPkkRsSXD6cXIbeqbt O1pwtRd3rwvS5lJ1I4U4f67j4YxgvYkNWG/WwFQZ5spGkoUokDZPaK/c+yntW94Ok/Ahv hZhfcbrYl1Edtxbw2Sq2hb4Xao+I610IAlj2Jg8EhpC2QzockXiCJ4Zpvr4Nhiba72mJh Ts8zfVeOTe3nRhOTdqx3i0HlYL/45a0zB5pMwvk01oMYIHugNmNcNa6Vy9J1shzzibw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793629053; h=DMARC-Filter:DKIM-Signature:Received:Content-Transfer-Encoding: Subject:Date:Mime-Version:X-B4-Tracking:Cc:X-Change-Id:X-Mailer: X-Lms-Return-Path:X-Original-From:Content-Type:To:From:Message-Id; bh=UETLk1dQekRKIibLsMQYa9UEIKc8XT6x173PcXv7ydk=; b=35s/W1Sf8AJ9U2xnGTUKsp4/Eht5UvnPhx5+YLtlETZEg/PP8P/9n0yrGP8KFWSNt+bs pau9nimZEwkJqsxToYAlXEmRI6Vxf4ygcfZu32W3LcvTxsG+Wae43nbAyYRrLiylI7biu e+hjsKi1h2ujgf+mh3USzBTLm2CpzVRfCQQXklPASDAEsgTGyhJ9BBGyQD2tFbXzKlmVc v7n9kKTbtI4xDDzQxRiD9xQOCg9tPqH9dmY4Oh0J4mRv01NCb6Fva53Py+MVST5ogkMKR wA9UJi4cfUltxMuScQLos+qNvLi5utQiFD+8KeL50NGmPIGuyw7sCl8qAPGwsYlVd+w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=cherr.cc; spf=pass smtp.mailfrom=cherr.cc; dkim=pass header.d=cherr.cc header.i=@cherr.cc header.a=rsa-sha256 header.s=feishu2604220257 header.b=JY0Q4JGk; arc=none smtp.remote-ip=71.18.227.1 Received: from sg-2-1.ptr.blmpb.com (sg-2-1.ptr.blmpb.com [71.18.227.1]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DD74606B5C9 for ; Mon, 2 Nov 2026 14:17:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 8DD74606B5C9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cherr.cc Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cherr.cc Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=cherr.cc header.i=@cherr.cc header.a=rsa-sha256 header.s=feishu2604220257 header.b=JY0Q4JGk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=feishu2604220257; d=cherr.cc; t=1793629040; h=from:subject: mime-version:from:date:message-id:subject:to:cc:reply-to:content-type: mime-version:in-reply-to:message-id; bh=UETLk1dQekRKIibLsMQYa9UEIKc8XT6x173PcXv7ydk=; b=JY0Q4JGkbzEoqaB5iqiyXIOHU6WLKEi2rncgK0ZIGJ7nGHZMghZxKeE7nVBtbdfrXkOjqK QlR+QRx0S2zaOkj9VfN5oIhpoJ4q11o09bYiUGjseJsMbhavExaRch6aMjRF5Tx1POtdLD +C6ggqPkXOuTu0mAEV0kJgj+qXxULtivKXfk0vPzcapaGh0VOmMKPeg5b6T/Fhkdmt0I+3 /Qvd8IDzsQqS1NcoUKfdkkX08xXJQsmbOSzqCTCUgKpOm+MVd/fjbHCvvSj/jb/wCvj78/ YuFbki68SXI9EuNOJhJDgB9l3C9cJcmfxg52qeUhB3YYATUdEwrd5j3kvDwBoQ== Received: from [127.0.1.1] ([111.42.148.145]) by smtp.feishu.cn with ESMTPS; Mon, 02 Nov 2026 22:17:18 +0800 Content-Transfer-Encoding: 7bit Subject: [PATCH v2] HID: pidff: fix undefined shift for infinite duration Date: Mon, 02 Nov 2026 22:17:11 +0800 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAGab6GoC/yXMQQqDQAyF4atI1gZ0iDJ4leLCcZIaF1YmYymId +/ULj947z/BOCkbDNUJid9q+toKXF3BvEzbk1FjMbjG9W3jPAbCXaMIxiNNuazRFpWMPgpJT11 L5KG898Sin7v8GP+2I6w8518OrusLASO2RHsAAAA= Cc: , , , , "Shengzhuo Wei" X-Change-Id: 20261028-b4-pidff-duration-shift-8df4f6451448 X-Mailer: b4 0.16.0 X-Lms-Return-Path: X-Original-From: Shengzhuo Wei Content-Type: text/plain; charset=UTF-8 To: =?utf-8?q?Tomasz_Paku=C5=82a?= , "Oleg Makarenko" , "Jiri Kosina" , "Benjamin Tissoires" From: "Shengzhuo Wei" Message-Id: <20261102-b4-pidff-duration-shift-v2-1-83c5f8c67484@cherr.cc> pidff_set_duration() computes the infinite duration as (1U << report_size) - 1, but report_size comes from the device's report descriptor and can be 32 or greater. This causes an undefined shift. A UHID test on x86-64 triggers UBSAN and programs a 32-bit duration field as zero instead of 0xffffffff. For report sizes of 32 or more, store -1 in the s32 field value to set all 32 bits without shifting. Keep the existing calculation for smaller fields. Fixes: 1a575044d516 ("HID: pidff: Compute INFINITE value instead of using hardcoded 0xffff") Cc: stable@vger.kernel.org Signed-off-by: Shengzhuo Wei --- Changes in v2: - Swap the branch order so the default operation is unguarded, as suggested by Tomasz in review. v1: https://lore.kernel.org/r/20261028-b4-pidff-duration-shift-v1-1-65028c6b4a37@cherr.cc --- drivers/hid/usbhid/hid-pidff.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index 22951b7ecd17..50906890fdad 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -394,7 +394,9 @@ static void pidff_set_duration(struct pidff_usage *usage, u16 duration) { /* PID defines INFINITE as the max possible value for duration field */ if (pidff_is_duration_infinite(duration)) { - usage->value[0] = (1U << usage->field->report_size) - 1; + usage->value[0] = -1; + if (usage->field->report_size < 32) + usage->value[0] = (1U << usage->field->report_size) - 1; return; } --- base-commit: d135ab453a7400a34930bdda1ef4bdc8acfac80e change-id: 20261028-b4-pidff-duration-shift-8df4f6451448 Best regards, -- Shengzhuo Wei