From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vidhu Sarwal <vidhu.linux@gmail.com>
Cc: "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>
Subject: Re: [PATCH v2 0/3] iio: proximity: Add Benewake TF-Luna LiDAR driver
Date: Mon, 2 Nov 2026 11:47:56 +0100 [thread overview]
Message-ID: <20261102-massive-busy-woodlouse-8d0bbb@quoll> (raw)
In-Reply-To: <20261031-tf-luna-v2-0-ce403579bb8a@gmail.com>
On Sat, Oct 31, 2026 at 12:23:27AM +0530, Vidhu Sarwal wrote:
> This series adds support for the Benewake TF-Luna, a single point ToF
> LiDAR distance sensor with a range of 0.2 m to 8 m. The
> sensor uses either UART or I2C, selected by a strap pin at power-up.
> This series covers the I2C interface only.
>
> Patch 1 adds the vendor prefix, patch 2 adds the binding and patch 3 adds the
> driver, which reports distance using an IIO_DISTANCE channel.
>
> The driver keeps the sensor in trigger mode and starts a measurement
> per read. The manual warns that reads in continuous mode can race with
> the sensor updating its result registers unless they are synchronised
> to the data ready output, which the driver does not use yet.
>
> Two issues I faced with the hardware that the manual does not mention:
> - The sensor silently drops a register write that arrives right after
> another one, so probe reads the mode back after setting it.
> - The boot time is not documented. I was able to measure 350ms after a
> reboot before the registers read back correctly, so probe waits
> 500 ms after enabling the supply, keeping some buffer.
>
> Later on I plan to add buffered caputure using data ready interrupt and
> runtime PM in a follow up series.
>
> This was tested on hardware using Raspberry Pi 4 and with firmware v3.6.0
> built out of tree on the 6.18 RPi kernel both via new_device as well as a
> DT Overlay.
>
> ---
> Changes in v2:
> - dt-bindings: describe the UART interface as well per Krzysztof
What changed exactly? b4 diff fails, the patchset cannot be applied on
any known upstream revision I tried.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-11-02 10:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 18:53 Vidhu Sarwal via B4 Relay
2026-10-30 18:53 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add Benewake Vidhu Sarwal via B4 Relay
2026-10-30 18:53 ` [PATCH v2 2/3] dt-bindings: iio: proximity: Add Benewake TF-Luna Vidhu Sarwal via B4 Relay
2026-11-02 10:47 ` Krzysztof Kozlowski
2026-10-30 18:53 ` [PATCH v2 3/3] iio: proximity: Add Benewake TF-Luna LiDAR driver Vidhu Sarwal via B4 Relay
2026-10-31 14:51 ` Andy Shevchenko
2026-10-31 23:22 ` Jonathan Cameron
2026-11-02 10:47 ` Krzysztof Kozlowski [this message]
2026-11-02 11:48 ` [PATCH v2 0/3] " Vidhu Sarwal
2026-11-02 12:23 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261102-massive-busy-woodlouse-8d0bbb@quoll \
--to=krzk@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=vidhu.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®