From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.46 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793649308; b=Q/Mrc5pOe3BhDSa5nE3MJovDiLkKo+OlfMxQVX78dDNK/fPzPEIMrF1W97z1LjzLIDM9 m2o5knpG8q/bQ7BzLARkUaKLfIxbreEOkgmqCfMiCjSrFl6ctRLhZgkkpTVbs8CFJYn7X XU0tlfdsnok33eOAcU9IX58nPHqDO4ozIFMPfqsupHRsHqYCUfE2/i5qwsMK0srXqWI35 QwImQhE2OZCF1g3x7ja3E9E0peN9IglxpVGAgxZkrkiqcF7ghCh0dUsFMqp/YL8Ncsvpt HN2f+4EkReF42kyOjXHTi/E3ibh6pjjYb7CI8CMun9Qe3zPgxd27VuJ5bBJX4/QByMA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793649308; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:Date:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:References:In-Reply-To:To:Cc:X-Mailer; bh=9uUZbAhfeGjYG/riHe43I8tFvO+tplgSrmlkSMwjJsY=; b=VbZPUBlI6hO5VjHw9fDNrzBEiiqsc8vQh4EsWkKz/6M5RZw0XNvb5mjxjyMECRHvyAe0 CH3Vx/hYK6tkENWE+VMcMcZM6BUtneeYlY5SyWO99EfwcTsA1NUm4zZ7ohvpsCPxhQUZ2 bYPom7kTfstXW1h1WSdqHK/vuGCNLTH0Rmwz01C7Gg1MItkkUlomLhZMeKheUDgLZnvSY zwiIUR4U35k654gGUKdiGFMXM6MUBtg6ANPMJ/BoJfJeUntReBuOA51CdUx7NVyTMu0te nGeTmfmc5+UCM1X9kB+j6GjVTL93uy5NYSHGVU+jGcG5hh89yb4kPTcmlkXNU/r3gtA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=Nbc61Li5; arc=none smtp.remote-ip=209.85.128.46 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8692606A329 for ; Mon, 2 Nov 2026 19:55:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D8692606A329 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=Nbc61Li5 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4a599e9110eso18318905e9.0 for ; Mon, 02 Nov 2026 11:55:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793649306; x=1794254106; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9uUZbAhfeGjYG/riHe43I8tFvO+tplgSrmlkSMwjJsY=; b=Nbc61Li5mrA/nfVnFJBC+77qQTYw1R19JfVYWDt4vXFAWRYiA/Kj/jZW4gDsux2G0U z4xSX2Jo5KBV9a4Gblt3/9U4XT5JPXUNAwk2aeSiMTrQQCQSmWPeusrWxNzRfj7go7x7 L7ND1QnWt043Y4aupzbTBav8HUseoTeEYEJj1IE4XNejhQk5qE1sCd3GptOM3SLi9hEO vEZpoxeCQruNGLChXf/W71TM4ORkfk2QiAervrEqJJkRFlJQN6dS2mMASE+XE1soty9h NXzjzUVoS8ppaVGJNNNFkEpbd6F6F7Ug1Z0+uu33fkZ5idEH/o0JNNGGin7DsZGb3Set KiBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793649306; x=1794254106; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9uUZbAhfeGjYG/riHe43I8tFvO+tplgSrmlkSMwjJsY=; b=ktibMmbp4feGzI39CermvjebnxSYWadeNUMPMaKeKhPsmKrPltjewc1iLmmsUApZjv nthaccx8Lqzb7Txih1XjXNJ4XdrmVmrNgE2v97qkYko2bYkTv5Z15stVCVgfmxCkBTbS kZVv2n/QduK+YBsncuVrRPtkR2i6qQ2vP34r8dxDgqSOTsUqhxHicauZCyWoR+AZW5Nb 10JKxOfDMy/6VndrQk3bhOCPqhiJDkDP8a16ZlnG1ZVnL3UdBwgdX69nTPT2cVou+XfM 3Kp/RFn0H9l0HCJq8FyvCD/2Gkzm95qpD6QUR7weucgfh6BzpzxHf4iiKBUb1I/JTIGo C31Q== X-Forwarded-Encrypted: i=1; AKwUvByf6JGCA8IWkO56cnanP+A20eVLPhrbRmxhALcgBo1F1YrkGqrI0uWWCa5+uNYx9KS+7gSIP/2fVlTAKXE=@vger.kernel.org X-Gm-Message-State: APuU4Z8LpT7GcHaL2zIzC+JR3e5ABtWQFhTHOOPR2O7EytDWl8vNlfXG 5WX1QO0Hp8PYMa4MoNjQ681j5KiI9+n90zpOlpyWFvw5Aw8ECtG5bI7RreYrJvV0 X-Gm-Gg: AYBFou2CsP1JInRahWL3SQO9XBOcnOU8UTzxQ17e8Zi+ri0/SWsUWbevBjHVGstTXw+ mQ3vaYlNdiCouY2InrjSNTHSGXxJJV4ntRd0ujkyMTH7h7jykNPYalZoFQmR7ALOMyh2aLxFVan Ba8iDqpQK3vlWx2QaIeFsd1+Ny+URwLIsnaPjmpigkvu+/BE3c7fd4t4cuG0GrfO4sgYUbipxKD MrzAhlJrMPT0BI6EXQmLHLQjdiZMSG4+pMKk0rrgB2/1Fd9iZRqaqFR4+LwsL8pLT45UUuWANJC B/E2LQ1jIhg/h61QV4/mnggRkLVmQllucaCQr/UT9Dvh80XkLOgzJQ3emeGyVI64SEMrNUpreAu YGLsEMG6WpUWmllxCJTKW0kQJ2jABlr90k/QbxcykyGWkccbMs78N8DGqbNRnm67aWkz4q/51ZM XpaCpa9nD4ZH/F83aeNO8FT64+VVD7Z1TX+tH9VF8n7DBA+YIiq1ZnkWDw4t5dEUtrW9nzRXp01 sBR1GodjN/OiNdvWNrM0MlbD9wrZkzn/9ky04G/IwuLMYSrJH9YohPn+onDpnN3jbBoipmWNbio hRE0S1j42lkOw/iSuaNLL/WuyNo+mN3s X-Received: by 2002:a05:6000:2587:b0:48e:5ad1:5e77 with SMTP id ffacd0b85a97d-48e6e261607mr24082404f8f.0.1793649306240; Mon, 02 Nov 2026 11:55:06 -0800 (PST) Received: from localhost ([2620:10d:c092:500::7:f93e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e71b723cdsm22180229f8f.12.2026.11.02.11.55.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2026 11:55:05 -0800 (PST) From: Gustavo Luiz Duarte Date: Mon, 02 Nov 2026 19:54:50 +0000 Subject: [PATCH net v5 2/4] netconsole: read np.dev under target_list_lock in local_mac_show() X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261102-netcons-fixes-v5-2-bdada2f03563@gmail.com> References: <20261102-netcons-fixes-v5-0-bdada2f03563@gmail.com> In-Reply-To: <20261102-netcons-fixes-v5-0-bdada2f03563@gmail.com> To: Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Stephen Hemminger Cc: Gustavo Luiz Duarte , netdev@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.2 local_mac_show() loads nt->np.dev and dereferences it with no lock. It can race with the interface going away and netconsole_netdev_event() eventually calling netdev_put() and freeing the device before we dereference it, leading to a UAF. The window is only a few instructions wide, so I could only reproduce it with an artificially widened window between the load and the dereference: BUG: KASAN: slab-use-after-free in local_mac_show+0x4e/0x80 Read of size 8 at addr ffff88800e990458 by task uaf/130 local_mac_show+0x4e/0x80 configfs_read_iter+0x187/0x260 vfs_read+0x453/0x5a0 Allocated by task 116: alloc_netdev_mqs+0x78/0x830 rtnl_create_link+0x53b/0x5c0 Freed by task 121: kfree+0x159/0x420 device_release+0x77/0x120 kobject_put+0xb5/0x160 netdev_run_todo+0x420/0x850 rtnl_dellink+0x259/0x5b0 Two places can free np.dev: (1) netconsole_netdev_event() moves a target out of STATE_ENABLED under target_list_lock before netdev_put(), and (2) process_resume_target() releases np.dev under dynamic_netconsole_mutex. Fixes: 0953864160bd ("[NETPOLL]: no need to store local_mac") Signed-off-by: Gustavo Luiz Duarte --- drivers/net/netconsole.c | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index 7dde00eb8e98..1680581c595e 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -900,10 +900,23 @@ static ssize_t remote_ip_show(struct config_item *item, char *buf) static ssize_t local_mac_show(struct config_item *item, char *buf) { - struct net_device *dev = to_target(item)->np.dev; - static const u8 bcast[ETH_ALEN] = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff }; + struct netconsole_target *nt = to_target(item); + unsigned long flags; + u8 mac[ETH_ALEN]; + + eth_broadcast_addr(mac); + + dynamic_netconsole_mutex_lock(); + /* Hold target_list_lock here so netconsole_netdev_event() doesn't tear + * down np.dev from under us. + */ + spin_lock_irqsave(&target_list_lock, flags); + if (nt->state == STATE_ENABLED && nt->np.dev) + memcpy(mac, nt->np.dev->dev_addr, ETH_ALEN); + spin_unlock_irqrestore(&target_list_lock, flags); + dynamic_netconsole_mutex_unlock(); - return sysfs_emit(buf, "%pM\n", dev ? dev->dev_addr : bcast); + return sysfs_emit(buf, "%pM\n", mac); } static ssize_t remote_mac_show(struct config_item *item, char *buf) -- 2.56.0