Re: [PATCH] firewire: cdev: Check return value in ioctl_get_cycle_timer()

[Takashi Sakamoto <o-takashi@sakamocchi.jp>]

Hi,

On Thu, Oct 29, 2026 at 10:15:45AM +0000, Sreeraj S Kurup wrote:
> ioctl_get_cycle_timer() ignores the return value of
> ioctl_get_cycle_timer2(). If the latter fails, the output fields
> may remain uninitialized, causing the caller to use uninitialized
> data when calculating local_time and assigning cycle_timer.
> 
> Check the return value and propagate the error to the caller.
> 
> Signed-off-by: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
> ---
>  drivers/firewire/core-cdev.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Applied to for-next branch.

I prefer this submission to the previous ones from other contributors[1].
It's concise, to the point, and easy to read. When using generative AI in
our work, it's especially important to keep the intended recipients in
mind.


[1] https://lore.kernel.org/lkml/20260617023554.2789907-1-michael.bommarito@gmail.com/

Thanks

Takashi Sakamoto