From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.136.64.133 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793604139; b=J4xAGZIdBkQ8UVbW3AvVimmCaKETVptxd69iadQIeA/Pqe+1+GhC5M1OE09x0ds+HQb2 mBeWEtpyXSvcop5y6FR5P0xoRBFpH3U+nUd46Yj9plF0STKTLKFsK8YXrm7bjX7tOJ7er Nn7iVUJ9BwY121H7MmKtHvtjTzFi1lt8RAIVUWHrteRGwTI+gn9/Nyr3Flxl+l9ZasPDE 3wDBoizbvJtQXcyRLaUUfFsSxVTKcbmt95FfQa5xhrLYbH2AEXM/5FTMTt31CZVqEGG+4 KHuWCFDjRH5bm7Y4TOq+NKcNow5+RqjmGmlQrqEnNcKoiQwRmoBFHhxXrQb484gRq1Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793604139; h=DMARC-Filter:Received:DKIM-Signature:DKIM-Signature:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:Content-Transfer-Encoding:In-Reply-To; bh=YxYTF91G0F1lBThpqealjixyREmPnBACasG4sOFttPk=; b=Df9x+5rh4mMDFAMn/uyBhLb8EtWhEVFJiqCcughHIJKqf/Uj36lGiEEQHRxrjWK2usv4 El0W0Kl2KACN4ZyeRMuSYoAPAloKJ/62mWduaJ0Htt9WH4jLetlLuhn3MUxnseXLk9Ov9 2y02BWARSJRdW68QL98O/+xQ02Y+CU9fX++libr3tyrrnw+FphZnZWvt7ULK5wLBOkcgy rQlbq+vV2VSMVHjzBsVLcgb305tJRSEBL4zMMSeevJ3DdghHqQ3fOCMfU4LI5ihcKub3o 9JMjsdph0YZq7PnC+cxd9l1c5eCZsgnL/JTWvPvNeeu/gODxlfmOZ8XbYG0DmDKJOng== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=siemens-energy.com; spf=pass smtp.mailfrom=errorhandling.siemens-energy.com; dkim=pass header.d=flowmailer.net header.i=@flowmailer.net header.a=rsa-sha256 header.s=s1 header.b=dKvu6EqV; dkim=pass header.d=siemens-energy.com header.i=schuster.simon@siemens-energy.com header.a=rsa-sha256 header.s=fm4 header.b=bSfWfPqd; arc=none smtp.remote-ip=185.136.64.133 Received: from mta-64-133.flowmailer.net (mta-64-133.flowmailer.net [185.136.64.133]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3BD0606A33A for ; Mon, 2 Nov 2026 07:22:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C3BD0606A33A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=siemens-energy.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=errorhandling.siemens-energy.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=flowmailer.net header.i=@flowmailer.net header.a=rsa-sha256 header.s=s1 header.b=dKvu6EqV; dkim=pass (2048-bit key, unprotected) header.d=siemens-energy.com header.i=schuster.simon@siemens-energy.com header.a=rsa-sha256 header.s=fm4 header.b=bSfWfPqd Received: by mta-64-133.flowmailer.net with ESMTPSA id 2026110207220404ae1bc9db0019fd8a for ; Mon, 02 Nov 2026 08:22:04 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=s1; d=flowmailer.net; h=from:from:sender:to:to:cc:cc:subject:subject:content-type:content-type:content-transfer-encoding:content-transfer-encoding:References:In-Reply-To:Date:Message-ID:MIME-Version; bh=YxYTF91G0F1lBThpqealjixyREmPnBACasG4sOFttPk=; b=dKvu6EqVfSnsJbr1DYEMjQGKG08K0ycQRSmZDbjHQ0wmiEUVroiHDsR71k2L9GxtosNpUg hI4nCzr1GZkb9FBjoGy8fY2S/cVqwm1dVXhY9WTEx8yv2k9bofoHwExDt7TKt2953ZJI5FL8 Q7Q1PmgD/16OV1B5H/u99P5C7fuZ4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm4; d=siemens-energy.com; i=schuster.simon@siemens-energy.com; h=from:from:sender:to:to:cc:cc:subject:subject:content-type:content-type:content-transfer-encoding:content-transfer-encoding:References:In-Reply-To:Date:Message-ID:MIME-Version; bh=YxYTF91G0F1lBThpqealjixyREmPnBACasG4sOFttPk=; b=bSfWfPqdM+oB6qQiyE5obxHU0/LKsL5LXG9G41UDyAlpzS7u/vvcE99C+WwEvUYX1g2Vfk JDhEBHYxyLIS/S9DQo54lxUFFNPQwgCAVsD6ROrofTYoXqJ2nmGp77sEcRaZqgtY9RvojQ4B z8IuppUMQdHxD/brkp5OMHl0YYx+Js9sUuccqD0xalrkIDDleQJXazFTp8/QNPRHNIEF2+tA QGcuWhV/W/Aj8QTmPZLmN/MI1cZfUDU9lacTeO7AFx4muoDlDGVu+RjdXoAs5fUZqIUN+Xol W3tgoMpA1UZCrVeo3VSjMLIUYquAL6HCJ7mzRxwRHYrAuvblmFyJmkMQ==; Date: Mon, 2 Nov 2026 08:22:02 +0100 From: Simon Schuster To: Arnd Bergmann Cc: Vineet Gupta , Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Dinh Nguyen , Ley Foon Tan , linux-kernel@vger.kernel.org, kernel test robot , linux-snps-arc@lists.infradead.org, linux-parisc@vger.kernel.org, "linux-openrisc@vger.kernel.org" Subject: Re: [PATCH] nios2: ksyms: Declare __mulsi3 export Message-ID: <20261102072202.hpcrob7xknqwx4a4@dev-vm-schuster> References: <20261019-nios2-mulsi3-v1-1-4fd75b1bacef@linutronix.de> <47eb6b48-d664-440f-84b6-ba09f34d5e08@app.fastmail.com> <3175caa0-9f49-465d-959e-6b6c9bbb4f01@kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sun, Nov 01, 2026 at 12:19:34PM +0100, Arnd Bergmann wrote: > On Sun, Nov 1, 2026, at 01:26, Vineet Gupta wrote: > > On 10/31/26 16:57, Vineet Gupta wrote: > > >> > >> ┌───────────┬───────┬───────────┐ > >> │  routine  │ calls │ functions │ > >> ├───────────┼───────┼───────────┤ > >> │ __udivsi3 │ 415   │ 238       │ > >> ├───────────┼───────┼───────────┤ > >> │ __umodsi3 │ 203   │ 131       │ > >> ├───────────┼───────┼───────────┤ > >> │ __divsi3  │ 77    │ 57        │ > >> ├───────────┼───────┼───────────┤ > >> │ __modsi3  │ 41    │ 33        │ > >> └───────────┴───────┴───────────┘ > >> > >> I can take a stab at providing the generic libgcc implementation in > >> lib/* but I only expect the arches using libgcc version to switch. > > > > It seems there 4 are always needed together or not at all. > > Do we want 4 Kconfig gates or just one will suffice ? > > Either way is fine for me. Simon did separate symbols in his > nios2 patch[1], and I don't mind staying with that version > unless someone else feels strongly about it. So the implementation of these four in the series is indeed coupled and all resolve back to a common base implementation. It got separate symbols as I assumed that one could potentially provide optimised assembly routines for one of them but not the others in an individual arch; but admittedly, I did not think too much about that point (one would indeed probably provide a specialised instance of the common base routine?) as it was easy enough to do. > I would however like to have separate patches to add lib/divmul.c > and lib/mulsi3.c, and then patches on top that start using these > from nios2 and arc. I can split up Patch 3 in my series and pull out the nios2-KConfig selects of the generic symbols, so that nios2 enabling them is a separate patch. Best regards Simon