mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Suren Baghdasaryan <surenb@google.com>
Cc: david@kernel.org, ljs@kernel.org, jannh@google.com,
	liam@infradead.org, willy@infradead.org, paulmck@kernel.org,
	pfalcato@suse.de, usama.arif@linux.dev, vbabka@kernel.org,
	linux-fsdevel@vger.kernel.org, yi1.lai@intel.com,
	oe-lkp@lists.linux.dev, lkp@intel.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] selftests/proc: use RSS in /proc/pid/smaps_rollup tearing tests
Date: Mon, 2 Nov 2026 08:01:03 -0800	[thread overview]
Message-ID: <20261102080103.6e3f602364747ac6adb13f5c@linux-foundation.org> (raw)
In-Reply-To: <CAJuCfpGmPLBRhHa_dmyP10QzyRyvcWMYDLU0+J9t-RCLBsTaWA@mail.gmail.com>

On Mon, 2 Nov 2026 07:43:17 -0800 Suren Baghdasaryan <surenb@google.com> wrote:

> > :
> > : The patched userspace test passed all six cases on an existing
> > : x86-64 6.18.57 kernel, with a PID-namespace adjustment. That kernel
> > : predates ca5480fb53fa, so this checks selftest behavior, not the
> > : intended kernel's procfs changes. Separate syscall tests on that
> > : kernel confirmed the EXEC-merging and memlock failure cases.
> 
> I'm guessing your bot was using personality() to make the tests fail.
> Again, I'm not sure we should handle such use case. Should we?


: The concern is pre-ARMv6 CPUs, where READ_IMPLIES_EXEC is set by
: default. Nobody needs to call personality() to encounter this there.
: 
: We already addressed this in 0685630fdccb ("selftests/proc: make
: proc-maps-race work with READ_IMPLIES_EXEC"):
: 
: https://lore.kernel.org/r/20260808200312.6326-1-kmehltretter@gmail.com
: 
: That fixed split_vma(). Alternating PROT_EXEC in setup introduces the
: same assumption elsewhere: RW and RWX both become RWX, allowing adjacent
: mappings to merge. The parent then cannot find the expected three-page
: VMAs and the test fails during setup, before testing procfs tearing.
: 
: Yes, the focused x86-64 check explicitly enabled READ_IMPLIES_EXEC to
: exercise this behavior. It wasn't tested on old ARM hardware. But I
: think we should preserve the existing support for those machines.
: Populating writable, then removing write permission from alternate
: mappings, preserves both RSS and the required VMA boundaries.


  reply	other threads:[~2026-11-02 16:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-01 15:45 Suren Baghdasaryan
2026-11-01 19:01 ` Andrew Morton
2026-11-02 13:08   ` Pedro Falcato
2026-11-02 15:31     ` Suren Baghdasaryan
2026-11-02 15:43   ` Suren Baghdasaryan
2026-11-02 16:01     ` Andrew Morton [this message]
2026-11-02 16:11       ` Suren Baghdasaryan
2026-11-02 16:15         ` Suren Baghdasaryan
2026-11-02 17:01           ` Andrew Morton
2026-11-02 17:21             ` Suren Baghdasaryan
2026-11-02 13:26 ` Pedro Falcato
2026-11-02 15:59   ` Suren Baghdasaryan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261102080103.6e3f602364747ac6adb13f5c@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=jannh@google.com \
    --cc=liam@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ljs@kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-lkp@lists.linux.dev \
    --cc=paulmck@kernel.org \
    --cc=pfalcato@suse.de \
    --cc=surenb@google.com \
    --cc=usama.arif@linux.dev \
    --cc=vbabka@kernel.org \
    --cc=willy@infradead.org \
    --cc=yi1.lai@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®