From: Tejun Heo <tj@kernel.org>
To: sched-ext@lists.linux.dev
Cc: David Vernet <void@manifault.com>,
Andrea Righi <arighi@nvidia.com>,
Changwoo Min <changwoo@igalia.com>,
Emil Tsalapatis <emil@etsalapatis.com>,
David Dai <david.dai@linux.dev>,
linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>
Subject: [PATCH sched_ext/for-7.5] sched_ext: Say "hosting" instead of "running" in scx_exec_sched() comments
Date: Sun, 1 Nov 2026 22:02:59 -1000 [thread overview]
Message-ID: <20261102080259.1509843-1-tj@kernel.org> (raw)
scx_exec_sched()'s comments call the nearest non-bypassing ancestor the
sched running a bypassing sched's tasks. ops.sub_cid_sched_updated() uses
"the sched running on a cid" for the sched owning the task running there.
Call the ancestor the host, as the bypass dispatch code already does.
Signed-off-by: Tejun Heo <tj@kernel.org>
---
kernel/sched/ext/internal.h | 10 +++++-----
kernel/sched/ext/sub.c | 2 +-
kernel/sched/ext/sub.h | 2 +-
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/kernel/sched/ext/internal.h b/kernel/sched/ext/internal.h
index 80c746054ce7..c20326d6eed8 100644
--- a/kernel/sched/ext/internal.h
+++ b/kernel/sched/ext/internal.h
@@ -2756,14 +2756,14 @@ static inline struct scx_sched *scx_parent(struct scx_sched *sch) { return NULL;
#endif /* CONFIG_EXT_SUB_SCHED */
/**
- * scx_exec_sched - Find the sched running @sch's tasks on @cpu
+ * scx_exec_sched - Find the sched hosting @sch's tasks on @cpu
* @sch: sched owning the tasks
* @cpu: cpu of interest
*
- * A bypassing sched's tasks are run by its nearest ancestor that isn't
- * bypassing. Return @sch if it isn't bypassing on @cpu, otherwise that
- * ancestor, or the root if every ancestor is bypassing. Hold @cpu's rq lock for
- * a stable answer.
+ * A bypassing sched's tasks are hosted on the bypass DSQs of its nearest
+ * ancestor that isn't bypassing. Return @sch if it isn't bypassing on @cpu,
+ * otherwise that ancestor, or the root if every ancestor is bypassing. Hold
+ * @cpu's rq lock for a stable answer.
*/
static inline struct scx_sched *scx_exec_sched(struct scx_sched *sch, s32 cpu)
{
diff --git a/kernel/sched/ext/sub.c b/kernel/sched/ext/sub.c
index 8962498e937c..9732809c09f8 100644
--- a/kernel/sched/ext/sub.c
+++ b/kernel/sched/ext/sub.c
@@ -950,7 +950,7 @@ bool scx_task_reenq_on_cap_revoke(struct rq *rq, struct task_struct *p)
if (is_migration_disabled(p) || p == scx_rescuee(rq))
return false;
- /* check caps against the sched running a bypassed task */
+ /* check caps against the sched hosting a bypassed task */
missing = scx_missing_caps(scx_exec_sched(scx_task_sched(p), cpu), cpu,
scx_caps_for_task(p));
if (likely(!missing))
diff --git a/kernel/sched/ext/sub.h b/kernel/sched/ext/sub.h
index eb1dba6d51e2..41099218e38d 100644
--- a/kernel/sched/ext/sub.h
+++ b/kernel/sched/ext/sub.h
@@ -238,7 +238,7 @@ static inline bool scx_task_can_stay_on_cpu(struct rq *rq, struct task_struct *p
if (unlikely(is_migration_disabled(p)))
return true;
- /* check caps against the sched running a bypassed task */
+ /* check caps against the sched hosting a bypassed task */
return likely(!scx_missing_caps(scx_exec_sched(scx_task_sched(p), cpu), cpu,
SCX_CAP_BASE));
}
--
2.56.0
next reply other threads:[~2026-11-02 8:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 8:02 Tejun Heo [this message]
2026-11-02 16:16 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261102080259.1509843-1-tj@kernel.org \
--to=tj@kernel.org \
--cc=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=david.dai@linux.dev \
--cc=emil@etsalapatis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sched-ext@lists.linux.dev \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®