From: Matthias Goergens <matthias.goergens@gmail.com>
To: Helge Deller <deller@gmx.de>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/3] fbdev: pxafb: unregister cpufreq notifier on removal
Date: Mon, 2 Nov 2026 16:03:30 +0800 [thread overview]
Message-ID: <20261102080332.1466689-2-matthias.goergens@gmail.com> (raw)
In-Reply-To: <20261102080332.1466689-1-matthias.goergens@gmail.com>
pxafb_probe() registers a cpufreq transition notifier, but
pxafb_remove() never unregisters it. The notifier block is part of
struct pxafb_info, which is devm-allocated and freed after removal, so
once the driver is unbound or the module unloaded, the next CPU
frequency change calls pxafb_freq_transition() through freed memory.
Unregister the notifier in pxafb_remove().
Sashiko, the AI review bot, pointed this out while reviewing a pxafb
cleanup. I have no PXA hardware; this is build-tested only.
Link: https://lore.kernel.org/all/20260722081427.413EF1F000E9@smtp.kernel.org/
Fixes: 9f17f2874834 ("[ARM] 5118/1: pxafb: add exit and remove handlers")
Signed-off-by: Matthias Goergens <matthias.goergens@gmail.com>
---
drivers/video/fbdev/pxafb.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
index 1682345fb9b0..4f5c408eae56 100644
--- a/drivers/video/fbdev/pxafb.c
+++ b/drivers/video/fbdev/pxafb.c
@@ -2384,6 +2384,10 @@ static void pxafb_remove(struct platform_device *dev)
info = &fbi->fb;
+#ifdef CONFIG_CPU_FREQ
+ cpufreq_unregister_notifier(&fbi->freq_transition,
+ CPUFREQ_TRANSITION_NOTIFIER);
+#endif
pxafb_overlay_exit(fbi);
cancel_work_sync(&fbi->task);
unregister_framebuffer(info);
--
2.56.0
next prev parent reply other threads:[~2026-11-02 8:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 8:03 [PATCH v2 0/3] fbdev: pxafb: fix teardown and early-interrupt lifetimes Matthias Goergens
2026-11-02 8:03 ` Matthias Goergens [this message]
2026-11-02 8:03 ` [PATCH v2 2/3] fbdev: pxafb: stop the smart-panel thread Matthias Goergens
2026-11-02 8:03 ` [PATCH v2 3/3] fbdev: pxafb: initialize IRQ completions before requesting IRQ Matthias Goergens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261102080332.1466689-2-matthias.goergens@gmail.com \
--to=matthias.goergens@gmail.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®