From: santino.wang <santino.wang@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: <linux-mediatek@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <light.chen@mediatek.com>,
<Fred-WY.Chen@mediatek.com>, <arnab.layek@mediatek.com>,
Santino Wang <santino.wang@mediatek.com>
Subject: [RFC PATCH 03/11] soc: mediatek: dram-ecc: add tracepoints
Date: Mon, 2 Nov 2026 17:23:25 +0800 [thread overview]
Message-ID: <20261102092334.138759-4-santino.wang@mediatek.com> (raw)
In-Reply-To: <20261102092334.138759-1-santino.wang@mediatek.com>
From: Santino Wang <santino.wang@mediatek.com>
Add tracepoints for the driver lifecycle, corrected and uncorrectable
errors, and page retirement, so error handling can be followed with
ftrace without relying on the kernel log.
Signed-off-by: Santino Wang <santino.wang@mediatek.com>
---
drivers/soc/mediatek/dram-ecc/core/Makefile | 5 +-
drivers/soc/mediatek/dram-ecc/core/main.c | 3 +
drivers/soc/mediatek/dram-ecc/core/trace.c | 6 +
drivers/soc/mediatek/dram-ecc/core/trace.h | 119 ++++++++++++++++++++
4 files changed, 132 insertions(+), 1 deletion(-)
create mode 100644 drivers/soc/mediatek/dram-ecc/core/trace.c
create mode 100644 drivers/soc/mediatek/dram-ecc/core/trace.h
diff --git a/drivers/soc/mediatek/dram-ecc/core/Makefile b/drivers/soc/mediatek/dram-ecc/core/Makefile
index 429347bfd057..66ce5d306a45 100644
--- a/drivers/soc/mediatek/dram-ecc/core/Makefile
+++ b/drivers/soc/mediatek/dram-ecc/core/Makefile
@@ -4,4 +4,7 @@ obj-$(CONFIG_MTK_DRAM_ECC) += mtk_dram_ecc.o
mtk_dram_ecc-y := \
main.o \
- smc.o
+ smc.o \
+ trace.o
+
+CFLAGS_trace.o := -I$(src)
diff --git a/drivers/soc/mediatek/dram-ecc/core/main.c b/drivers/soc/mediatek/dram-ecc/core/main.c
index 5000d1f3c7e3..ce6bd39fa303 100644
--- a/drivers/soc/mediatek/dram-ecc/core/main.c
+++ b/drivers/soc/mediatek/dram-ecc/core/main.c
@@ -7,6 +7,7 @@
#include <linux/device/class.h>
#include "mtk_dram_ecc.h"
+#include "trace.h"
static struct class *mtk_dram_ecc_class;
static struct device *mtk_dram_ecc_dev;
@@ -33,6 +34,7 @@ static int __init mtk_dram_ecc_init(void)
goto err_class;
}
+ trace_mtk_dram_ecc_lifecycle(0);
dev_info(mtk_dram_ecc_dev, "initialized\n");
return 0;
@@ -45,6 +47,7 @@ static void __exit mtk_dram_ecc_exit(void)
{
device_destroy(mtk_dram_ecc_class, MKDEV(0, 0));
class_destroy(mtk_dram_ecc_class);
+ trace_mtk_dram_ecc_lifecycle(1);
}
module_init(mtk_dram_ecc_init);
diff --git a/drivers/soc/mediatek/dram-ecc/core/trace.c b/drivers/soc/mediatek/dram-ecc/core/trace.c
new file mode 100644
index 000000000000..9a8b20e48069
--- /dev/null
+++ b/drivers/soc/mediatek/dram-ecc/core/trace.c
@@ -0,0 +1,6 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2026 MediaTek Inc.
+ */
+#define CREATE_TRACE_POINTS
+#include "trace.h"
diff --git a/drivers/soc/mediatek/dram-ecc/core/trace.h b/drivers/soc/mediatek/dram-ecc/core/trace.h
new file mode 100644
index 000000000000..d603fc38f0a7
--- /dev/null
+++ b/drivers/soc/mediatek/dram-ecc/core/trace.h
@@ -0,0 +1,119 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2026 MediaTek Inc.
+ */
+#undef TRACE_SYSTEM
+#define TRACE_SYSTEM mtk_dram_ecc
+
+#if !defined(_TRACE_MTK_DRAM_ECC_H) || defined(TRACE_HEADER_MULTI_READ)
+#define _TRACE_MTK_DRAM_ECC_H
+
+#include <linux/tracepoint.h>
+
+/* driver lifecycle - state: 0=init, 1=exit */
+
+TRACE_EVENT(mtk_dram_ecc_lifecycle,
+ TP_PROTO(int state),
+ TP_ARGS(state),
+ TP_STRUCT__entry(
+ __field(int, state)
+ ),
+ TP_fast_assign(
+ __entry->state = state;
+ ),
+ TP_printk("%s", __entry->state ? "driver removed" : "driver initialized")
+);
+
+/*
+ * ECC events - spa/channel/subchannel/rank/bank/row/column decoded from the
+ * ECCERR_INFO0/1 entry that determined severity (see ghes_notifier.c),
+ * mirroring ATF dram_ecc/mt8992/fiq.c's decode. No agent/master ID: ATF's
+ * GHES vendor section doesn't compute them (see mtk_dram_ecc_event.h).
+ */
+
+TRACE_EVENT(mtk_dram_ecc_ce,
+ TP_PROTO(u64 spa, u8 channel, u8 subch, u16 rank, u16 bank, u32 row,
+ u16 column),
+ TP_ARGS(spa, channel, subch, rank, bank, row, column),
+ TP_STRUCT__entry(
+ __field(u64, spa)
+ __field(u8, channel)
+ __field(u8, subch)
+ __field(u16, rank)
+ __field(u16, bank)
+ __field(u32, row)
+ __field(u16, column)
+ ),
+ TP_fast_assign(
+ __entry->spa = spa;
+ __entry->channel = channel;
+ __entry->subch = subch;
+ __entry->rank = rank;
+ __entry->bank = bank;
+ __entry->row = row;
+ __entry->column = column;
+ ),
+ TP_printk("spa=0x%016llx ch=%u subch=%u rank=%u bank=%u row=%u column=%u",
+ __entry->spa, __entry->channel, __entry->subch,
+ __entry->rank, __entry->bank, __entry->row,
+ __entry->column)
+);
+
+TRACE_EVENT(mtk_dram_ecc_uce,
+ TP_PROTO(u64 spa, u8 channel, u8 subch, u16 rank, u16 bank, u32 row,
+ u16 column),
+ TP_ARGS(spa, channel, subch, rank, bank, row, column),
+ TP_STRUCT__entry(
+ __field(u64, spa)
+ __field(u8, channel)
+ __field(u8, subch)
+ __field(u16, rank)
+ __field(u16, bank)
+ __field(u32, row)
+ __field(u16, column)
+ ),
+ TP_fast_assign(
+ __entry->spa = spa;
+ __entry->channel = channel;
+ __entry->subch = subch;
+ __entry->rank = rank;
+ __entry->bank = bank;
+ __entry->row = row;
+ __entry->column = column;
+ ),
+ TP_printk("spa=0x%016llx ch=%u subch=%u rank=%u bank=%u row=%u column=%u",
+ __entry->spa, __entry->channel, __entry->subch,
+ __entry->rank, __entry->bank, __entry->row,
+ __entry->column)
+);
+
+/* page retire */
+
+TRACE_EVENT(mtk_dram_ecc_page_retire,
+ TP_PROTO(u64 pfn, u32 count, u32 threshold, bool retired),
+ TP_ARGS(pfn, count, threshold, retired),
+ TP_STRUCT__entry(
+ __field(u64, pfn)
+ __field(u32, count)
+ __field(u32, threshold)
+ __field(bool, retired)
+ ),
+ TP_fast_assign(
+ __entry->pfn = pfn;
+ __entry->count = count;
+ __entry->threshold = threshold;
+ __entry->retired = retired;
+ ),
+ TP_printk("pfn=0x%llx count=%u threshold=%u retired=%s",
+ __entry->pfn, __entry->count, __entry->threshold,
+ __entry->retired ? "yes" : "no")
+);
+
+#endif /* _TRACE_MTK_DRAM_ECC_H */
+
+#undef TRACE_INCLUDE_PATH
+#define TRACE_INCLUDE_PATH .
+#undef TRACE_INCLUDE_FILE
+#define TRACE_INCLUDE_FILE trace
+
+#include <trace/define_trace.h>
--
2.45.2
next prev parent reply other threads:[~2026-11-02 9:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 9:23 [RFC PATCH 00/11] soc: mediatek: add a DRAM ECC error handling driver santino.wang
2026-11-02 9:23 ` [RFC PATCH 01/11] soc: mediatek: dram-ecc: add the DRAM ECC driver skeleton santino.wang
2026-11-02 13:41 ` Krzysztof Kozlowski
2026-11-02 9:23 ` [RFC PATCH 02/11] soc: mediatek: dram-ecc: add the SMC interface to the secure firmware santino.wang
2026-11-02 9:23 ` santino.wang [this message]
2026-11-02 9:23 ` [RFC PATCH 04/11] soc: mediatek: dram-ecc: handle GHES vendor records from the firmware santino.wang
2026-11-02 9:23 ` [RFC PATCH 05/11] soc: mediatek: dram-ecc: add error counters and the address lists santino.wang
2026-11-02 13:42 ` Krzysztof Kozlowski
2026-11-02 9:23 ` [RFC PATCH 06/11] soc: mediatek: dram-ecc: keep error counters across boots santino.wang
2026-11-02 9:23 ` [RFC PATCH 07/11] soc: mediatek: dram-ecc: add containment policy and storm protection santino.wang
2026-11-02 9:23 ` [RFC PATCH 08/11] soc: mediatek: dram-ecc: add the corrected error leaky bucket santino.wang
2026-11-02 9:23 ` [RFC PATCH 09/11] soc: mediatek: dram-ecc: add a generic netlink event interface santino.wang
2026-11-02 9:23 ` [RFC PATCH 10/11] soc: mediatek: dram-ecc: report an uncorrectable error of the previous boot santino.wang
2026-11-02 13:44 ` Krzysztof Kozlowski
2026-11-02 9:23 ` [RFC PATCH 11/11] Documentation: ABI: add the sysfs attributes of the MediaTek DRAM ECC driver santino.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261102092334.138759-4-santino.wang@mediatek.com \
--to=santino.wang@mediatek.com \
--cc=Fred-WY.Chen@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnab.layek@mediatek.com \
--cc=light.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®