mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Abdelnasser Hussein <abdelnasserhussein11@gmail.com>
To: "Jonathan Cameron" <jic23@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>
Cc: David Lechner <dlechner@baylibre.com>,
	Andy Shevchenko <andy@kernel.org>,
	Joshua Crofts <crofts@kernel.org>,
	linux@analog.com, linux-iio@vger.kernel.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Abdelnasser Hussein <abdelnasserhussein11@gmail.com>
Subject: [PATCH v3 0/2] staging: iio: addac: adt7316: clean up header inclusions
Date: Mon,  2 Nov 2026 11:42:34 +0200	[thread overview]
Message-ID: <20261102094236.57757-1-abdelnasserhussein11@gmail.com> (raw)

This series cleans up header inclusions in adt7316.c by following
the Include What You Use (IWYU) principle.

The series is split into two logical steps:
1. Sort existing header inclusions alphabetically without modifying the
   list of included headers. Keep subsystem <linux/iio/*> headers
   separated and insert a blank line before "adt7316.h".
2. Drop proxy header <linux/kernel.h>, explicitly add missing headers
   (<linux/bits.h>, <linux/err.h>, <linux/errno.h>, <linux/kstrtox.h>,
   <linux/pm.h>, <linux/string.h>, <linux/types.h>), drop unused headers
   (<linux/i2c.h>, <linux/list.h>, <linux/rtc.h>, <linux/slab.h>,
   <linux/workqueue.h>), and maintain alphabetical sorting.

v3:
 - Split the series as suggested by Joshua Crofts: patch 1 only sorts
   the headers, patch 2 replaces kernel.h and adds/drops headers.
 - Explicitly include <linux/err.h>, <linux/errno.h>, and
   <linux/types.h> per IWYU following verification of symbols used.

v2:
 - Address review feedback from Andy Shevchenko: drop <linux/kernel.h>
   and include the headers actually used.
 - Split the original patch into a 2-patch series.

v1:
 - Initial submission.

Abdelnasser Hussein (2):
  staging: iio: addac: adt7316: sort headers alphabetically
  staging: iio: addac: adt7316: replace kernel.h with explicit headers

 drivers/staging/iio/addac/adt7316.c | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)

-- 
2.56.0


             reply	other threads:[~2026-11-02  9:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02  9:42 Abdelnasser Hussein [this message]
2026-11-02  9:42 ` [PATCH v3 1/2] staging: iio: addac: adt7316: sort headers alphabetically Abdelnasser Hussein
2026-11-02  9:42 ` [PATCH v3 2/2] staging: iio: addac: adt7316: replace kernel.h with explicit headers Abdelnasser Hussein
2026-11-02 10:01 ` [PATCH v3 0/2] staging: iio: addac: adt7316: clean up header inclusions Joshua Crofts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261102094236.57757-1-abdelnasserhussein11@gmail.com \
    --to=abdelnasserhussein11@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=crofts@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=linux@analog.com \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®