From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.54 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793617048; b=qCtSioEH8zbEXr89ybkXZLy2KdOEiGtRQBr6B/dYeaBkb5bOKbMPdXlKLLe0F6/rh/zp WhB59pB85Hm0DDKDSz+HTOH/b5Ee0l5+7nsohsq8HcBGE6W7ADuOE1Z3Yax0Lc4t+cR8g Xji40EvOLOMj1gV9/l8Xm3IynXHmtkRLW7WLihg4FTWm4YEnMCr8/Q2PVGkQ6rm01HDaS eX3QC7f8Q3iIfjps+fnUCOALb6Mtn4rbKl/KA+ULc1GMP0VUsn5jOAhFDdRZSC3UsJYGO tdfwrDYRTrP8HPVSex3/7heqtU6VcTyajmEwomyhvNQ5zkpvf6AKAFtq0OFXvNx6f0g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793617048; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Gm-Gg:X-Received:Received:From:To:Cc:Subject: Date:Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Type:Content-Transfer-Encoding; bh=VTSGFL/OuCHUOn2dSnsPuxyMOhqVaXG6DpAGnPdCD68=; b=5CymVA7agrtSRmEtk8BXuz/joanDRPIinyIp+N67RyBXn9YejzndRJJUhnXNKUD7ALFa 8VwZSoMmzV2Q+WeoZ9Ah3psJGV4XKG+KDopav3ii1+FMll98y8FFMmNgQdR8UnvlFSRAZ xL7rwBJ/1qR8fkyXTLvT8oCZE1PLwtHq2UrnepB0dJuS84ZgyBgZLQgpi7dBSzmgrJFX8 0W34elMY6mVqbDIb+Xm5HBPymuhQrnvJs3AzYFCbUDfTH2uWuJBSo0VXlj0W870eUY5tP qzSwSfkSlR1Nthi1mZPC/ikWF6vbIgzbXAhrCZGPr8zxGThvdJKA2lYIw5FCT9x1FDQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=FJMqbfoH; arc=none smtp.remote-ip=209.85.128.54 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52EF1606A332 for ; Mon, 2 Nov 2026 10:57:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 52EF1606A332 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=FJMqbfoH Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4a5177d78c7so28966525e9.2 for ; Mon, 02 Nov 2026 02:57:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1793617047; x=1794221847; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=VTSGFL/OuCHUOn2dSnsPuxyMOhqVaXG6DpAGnPdCD68=; b=FJMqbfoHzmU9NBD5OFazlCTtXApiZl2pCDBFkJYEeWZp2zNjHrL8hIA+ErSrHlYIy3 gPGruyieOAD6LhqwXujERZqWZBVFYI+UvIEOgn6cWVZbYyuuflU6FCmFyU1yzWUPK9F8 k/638ZQuZvZ5yq9olZUMdCnfGbk4kN9pWZTyHVG1M3FzWjkjd8MXGQbAlNrpNkMzLkUe ExCh65HdON6dE/sKFRPxj88eHxM14/RiFdxDQ3UJDBTcccbtUquX1eBIQp6YsA2FkvVE jszA64F8slwC9nnNstEkvqCpiDgI/0l7pAZ5OtgdjF9wJO1Dg4uE51CBNQHYVaXtjutg EbCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793617047; x=1794221847; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=VTSGFL/OuCHUOn2dSnsPuxyMOhqVaXG6DpAGnPdCD68=; b=edQK8/nYPxs+CyIuV+0OtiSGYbhAaGaa6RZxNVsjBFCVQ9BogEmEdkGMfjWKcDJQF5 UW67B6DlleFwJQlnNN1zdkXs9Hic6GphbpdFOrF7TIcXi8271CwprR/657aRG8lDcvWC oxwilrk6w2o0/HBVix00FypefJD12mPQKrCcSxLQA12k+2uitzrvtU0HrFzWUfTbujw/ eyKTDc3Vvfcf8aPTzA/uBt43s0VVNu29pfuhWNP+6gsgI+AlhCGnJNc82D+qvx5Y39W9 KJLUmmT09cmMjjZtvVjdXkETFKpQlpdgMInf5VG+fbNxBDrQif1EgVqPEy/LZgAgD1Ar PCYw== X-Gm-Message-State: AFq9FYK0AN3iCJEDPffOANnujGRXjlONczQPtf3NTzBrrB7jZ4MqJ2bb ULebHVrvcbaKX8ZcZPWPEtmKfmm9NvHuY1abLLh+xJ/x49ongJ13sCdEF22efLRvdh7epMpJKja Zc+XoiHY= X-Gm-Gg: AYBFou0w3IIWBs3kEVWpDDvANhQWkbJ6Rrk/juFYFCJ71JVF4shWzK94WSXBmeQrIU/ FSfyEIj2X4+IdrTo1TEf1EeBDNhh3MOlPWPhfNiBhOqRQSb+TfrcqFnakzgEwrtKirohRcuHZ8q 6SgHaVomhrVFGhoOZbefJW4fgHolWeIIxj87DK5KNagelZ14unQuRYrvQzP4oj0vTrQtOKFq22k Fj6yzpDR/LMzOxsGha7vhPUOxYZlaC6KUclNV47OZHF7uDIW+0tk8rO0tcW1xlJAfojc2jgbudF KcgoWA+PqG/3gWhTNQH09gR0MoDp4nLScyrKO2OWTWZM8HMmnqgyjWVTa4240hZvEnApX7Hccoy P654d0katZchTY8+JEsDFdkrB4GJWAXADOY9J4Ws1i8BwHT6O83rMsFwsM0zH/4We4K2aKRl8Lv GuAZ9VvqmXSugXABMxnG7LlGvluww0/5+v8LRto0I+/vawmuFFLtQb/vgeWWFz7+dJZxGPAQ/Ik mvY+FamraDGt+k3UZh7pXP8j3jzyXN3OyrOsozAzRjIXncYrnDYeg7OzreuvhnTUn4V15IlJxeo xOTeKiA4hBNm/TkktD1vjg+afopqwGnlViIyNvcNEb0lvgyQR8W/ X-Received: by 2002:a05:600c:a4d:b0:4a3:12fb:1ee7 with SMTP id 5b1f17b1804b1-4ac18c7388dmr247349255e9.25.1793617046786; Mon, 02 Nov 2026 02:57:26 -0800 (PST) Received: from localhost.localdomain ([2a00:6d43:105:c401:e307:1a37:2e76:ce91]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4abeb77af8csm363171175e9.1.2026.11.02.02.57.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2026 02:57:26 -0800 (PST) From: Marco Crivellari To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Marco Crivellari , Michal Hocko , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ethan Nelson-Moore , linux-usb@vger.kernel.org Subject: [PATCH net-next v5 6/6] net: usb: r8152: Move long delayed work on system_dfl_long_wq Date: Mon, 2 Nov 2026 11:56:56 +0100 Message-ID: <20261102105703.111844-7-marco.crivellari@suse.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261102105703.111844-1-marco.crivellari@suse.com> References: <20261102105703.111844-1-marco.crivellari@suse.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Currently the code enqueue work items using {queue|mod}_delayed_work(), using system_long_wq. This workqueue should be used when long works are expected and it is a per-cpu workqueue. The function(s) end up calling __queue_delayed_work(), which set a global timer that could fire anywhere, enqueuing the work where the timer fired. Unbound works could benefit from scheduler task placement, to optimize performance and power consumption. Long work shouldn't stick to a single CPU. Recently, a new unbound workqueue specific for long running work has been added:     c116737e972e ("workqueue: Add system_dfl_long_wq for long unbound works") Since the workqueue work doesn't rely on per-cpu variables, there is no obvious reason that justify the use of a per-cpu workqueue. So change system_long_wq with system_dfl_long_wq so that the work may benefit from scheduler task placement. Cc: Ethan Nelson-Moore Cc: linux-usb@vger.kernel.org Signed-off-by: Marco Crivellari --- drivers/net/usb/r8152.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index d3bb7ee9c9bf..4815235e8e73 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -7053,7 +7053,8 @@ static void rtl_hw_phy_work_func_t(struct work_struct *work) /* Delay execution in case request_firmware() is not ready yet. */ - queue_delayed_work(system_long_wq, &tp->hw_phy_work, HZ * 10); + queue_delayed_work(system_dfl_long_wq, &tp->hw_phy_work, + HZ * 10); goto ignore_once; } @@ -8821,7 +8822,7 @@ static int rtl8152_reset_resume(struct usb_interface *intf) clear_bit(SELECTIVE_SUSPEND, &tp->flags); rtl_reset_ocp_base(tp); tp->rtl_ops.init(tp); - queue_delayed_work(system_long_wq, &tp->hw_phy_work, 0); + queue_delayed_work(system_dfl_long_wq, &tp->hw_phy_work, 0); set_ethernet_addr(tp, true); return rtl8152_resume(intf); } @@ -10276,7 +10277,7 @@ static int rtl8152_probe_once(struct usb_interface *intf, /* Retry in case request_firmware() is not ready yet. */ tp->rtl_fw.retry = true; #endif - queue_delayed_work(system_long_wq, &tp->hw_phy_work, 0); + queue_delayed_work(system_dfl_long_wq, &tp->hw_phy_work, 0); set_ethernet_addr(tp, false); usb_set_intfdata(intf, tp); -- 2.56.0