From: Tristan Madani <tristmd@gmail.com>
To: linux-wireless@vger.kernel.org
Cc: arend.vanspriel@broadcom.com, brcm80211@lists.linux.dev,
brcm80211-dev-list.pdl@broadcom.com, fariyaf@gmail.com,
linville@tuxdriver.com, kvalo@kernel.org,
linux-kernel@vger.kernel.org,
Tristan Madani <tristan@talencesecurity.com>
Subject: [PATCH wireless 0/2] wifi: zero-pad SDIO writes to avoid leaking heap data
Date: Mon, 2 Nov 2026 12:23:09 +0000 [thread overview]
Message-ID: <20261102122311.181075-1-tristmd@gmail.com> (raw)
From: Tristan Madani <tristan@talencesecurity.com>
Several wireless drivers round up the length passed to
sdio_memcpy_toio() / sdio_writesb() for alignment purposes but do not
clear the padding bytes. The SDIO controller then reads past the
original buffer into adjacent heap memory, sending stale kernel data to
the wireless device.
Fix brcmfmac (4-byte alignment) and rsi (block alignment) by
zero-filling the gap before the write.
A third patch for rtw88 hits the same class of bug but needs a rebase
and will follow separately.
Tristan Madani (2):
wifi: brcmfmac: zero-pad SDIO write to 4-byte boundary
wifi: rsi: zero-pad SDIO TX to block boundary
drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 3 +++
drivers/net/wireless/rsi/rsi_91x_sdio.c | 3 +++
2 files changed, 6 insertions(+)
--
2.47.3
next reply other threads:[~2026-11-02 12:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 12:23 Tristan Madani [this message]
2026-11-02 12:23 ` [PATCH wireless 1/2] wifi: brcmfmac: zero-pad SDIO write to 4-byte boundary Tristan Madani
2026-11-02 12:23 ` [PATCH wireless 2/2] wifi: rsi: zero-pad SDIO TX to block boundary Tristan Madani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261102122311.181075-1-tristmd@gmail.com \
--to=tristmd@gmail.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=fariyaf@gmail.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=tristan@talencesecurity.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®