From: SJ Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Aveline Noir <jm5905938@gmail.com>,
Fernand Sieber <sieberf@amazon.com>,
Leonard Foerster <foersleo@amazon.de>, SJ Park <sj@kernel.org>,
SeongJae Park <sjpark@amazon.de>,
Shakeel Butt <shakeel.butt@linux.dev>,
Shubhang Kaushik <sh@gentwo.org>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: [PATCH 3/9] mm/damon/ops-common: align MMU notifier range when clearing PMD young bit
Date: Mon, 2 Nov 2026 07:07:50 -0800 [thread overview]
Message-ID: <20261102150757.93058-4-sj@kernel.org> (raw)
In-Reply-To: <20261102150757.93058-1-sj@kernel.org>
From: Aveline Noir <jm5905938@gmail.com>
damon_pmdp_mkold() clears the young bit of a PMD but notifies
[addr, addr + HPAGE_PMD_SIZE), where addr can be an unaligned sampling
address. This can miss part of the sampled huge page and age secondary
mappings in the next one.
Align addr to HPAGE_PMD_MASK so both operations cover the same huge page.
Fixes: 3f49584b262c ("mm/damon: implement primitives for the virtual memory address spaces")
Cc: Shubhang Kaushik (Ampere) <sh@gentwo.org>
Signed-off-by: Aveline Noir <jm5905938@gmail.com>
Reviewed-by: SJ Park <sj@kernel.org>
Signed-off-by: SJ Park <sj@kernel.org>
---
Changes from v1
- v1: https://lore.kernel.org/r/20261021-damon-align-pte-young-notifier-v1-1-d0365ac45b66@gentwo.org/
- Drop Link: tag.
- Collect R-b: from SJ.
- Update subject prefix.
- Rebase to latest mm-new.
mm/damon/ops-common.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/mm/damon/ops-common.c b/mm/damon/ops-common.c
index f88c6fd189fca..b9571f53e538c 100644
--- a/mm/damon/ops-common.c
+++ b/mm/damon/ops-common.c
@@ -102,6 +102,8 @@ void damon_pmdp_mkold(pmd_t *pmd, struct vm_area_struct *vma, unsigned long addr
bool young = false;
unsigned long pfn;
+ addr &= HPAGE_PMD_MASK;
+
if (likely(pmd_present(pmdval)))
pfn = pmd_pfn(pmdval);
else
--
2.47.3
next prev parent reply other threads:[~2026-11-02 15:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 15:07 [PATCH 0/9] mm/damon: various fixes and cleanup of code, test, and docs SJ Park
2026-11-02 15:07 ` [PATCH 1/9] mm/damon/core: remove unnecessary zero-initialization in damon_new_ctx() SJ Park
2026-11-02 15:07 ` [PATCH 2/9] mm/damon/ops-common: align MMU notifier range when clearing PTE young bit SJ Park
2026-11-02 15:07 ` SJ Park [this message]
2026-11-02 15:07 ` [PATCH 4/9] mm/damon/stat: avoid 32-bit overflow in idle percentiles SJ Park
2026-11-02 15:07 ` [PATCH 5/9] mm/damon/{p,v}addr: skip folios already on the migration target node SJ Park
2026-11-02 15:07 ` [PATCH 6/9] selftests/damon/sysfs.py: stop obsolete_target shells hanging the test SJ Park
2026-11-02 15:07 ` [PATCH 7/9] mm/damon/reclaim: fix typo and grammar SJ Park
2026-11-02 15:07 ` [PATCH 8/9] Docs/admin-guide/mm/damon/lru_sort: fix grammar and stlye SJ Park
2026-11-02 15:07 ` [PATCH 9/9] Docs/admin-guide/mm/damon/reclaim: document how to disable watermarks SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261102150757.93058-4-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=foersleo@amazon.de \
--cc=jm5905938@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sh@gentwo.org \
--cc=shakeel.butt@linux.dev \
--cc=sieberf@amazon.com \
--cc=sjpark@amazon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®