mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: YiPeng Chai <YiPeng.Chai@amd.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
	Alex Deucher <alexander.deucher@amd.com>,
	Hawking Zhang <Hawking.Zhang@amd.com>
Subject: drivers/gpu/drm/amd/ras/core/ras_mp1_v15_0.c:83:2-3: Unneeded semicolon
Date: Mon, 02 Nov 2026 18:09:52 +0100	[thread overview]
Message-ID: <202611021843.XfP1TzKA-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
commit: 87bd1227b14f30195ac7d41195159c099a8d5891 drm/amd/ras: Support obtaining bad page info at boot time for ras_mp1_v15_0
date:   10 weeks ago
config: loongarch-randconfig-r2111-20261102 (https://download.01.org/0day-ci/archive/20261102/202611021843.XfP1TzKA-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 3e5b45eed6c3ec25f4f1cc81ce0be10106a8f31f)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: 87bd1227b14f ("drm/amd/ras: Support obtaining bad page info at boot time for ras_mp1_v15_0")
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611021843.XfP1TzKA-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/amd/ras/core/ras_mp1_v15_0.c:83:2-3: Unneeded semicolon

vim +83 drivers/gpu/drm/amd/ras/core/ras_mp1_v15_0.c

    59	
    60	static int __direct_send_mp1_msg(struct ras_core_context *ras_core,
    61			enum ras_mp1_msg_id msg_id, u32 input, u32 *output)
    62	{
    63		u32 msg_code = 0;
    64		int timeout = 100000;  //100 ms
    65		u32 reg = 0;
    66	
    67		msg_code = ras_mp1_msg_codes[msg_id];
    68		if (!msg_code)
    69			return -EOPNOTSUPP;
    70	
    71		/* Send message and parameter to fw */
    72		RAS_DEV_WREG32_SOC15(ras_core->dev, MP1, 0, regMP1_SMN_C2PMSG_41, 0);
    73		RAS_DEV_WREG32_SOC15(ras_core->dev, MP1, 0, regMP1_SMN_C2PMSG_42, input);
    74		RAS_DEV_WREG32_SOC15(ras_core->dev, MP1, 0, regMP1_SMN_C2PMSG_40, msg_code);
    75	
    76		/* Poll MP1 response */
    77		while (timeout--) {
    78			reg = RAS_DEV_RREG32_SOC15(ras_core->dev, MP1, 0, regMP1_SMN_C2PMSG_41);
    79			if (reg)
    80				break;
    81	
    82			udelay(1);
  > 83		};
    84	
    85		if (reg != MP1_RESP_OK) {
    86			RAS_DEV_ERR(ras_core->dev, "MP1 fail to ack 0x%x for msg: 0x%x, 0x%x, %p\n",
    87				reg, msg_code, input, output);
    88			return -EIO;
    89		}
    90	
    91		/* Read output data */
    92		if (output)
    93			*output = RAS_DEV_RREG32_SOC15(ras_core->dev, MP1, 0, regMP1_SMN_C2PMSG_42);
    94	
    95		return 0;
    96	}
    97	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-11-02 17:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202611021843.XfP1TzKA-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=Hawking.Zhang@amd.com \
    --cc=YiPeng.Chai@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®