mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Kees Cook <kees@kernel.org>
Cc: Nicolas Schier <nsc@kernel.org>,
	Julian Braha <julianbraha@gmail.com>,
	"Lorenzo Stoakes (ARM)" <ljs@kernel.org>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ricardo Ribalda <ribalda@chromium.org>,
	linux-s390@vger.kernel.org
Subject: Re: [PATCH 1/2] kbuild: Move testing of '-mfentry' back to Makefile from Kconfig
Date: Mon, 2 Nov 2026 11:53:00 -0700	[thread overview]
Message-ID: <20261102185300.GA1177738@ax162> (raw)
In-Reply-To: <20261030222934.0fcfa7-kees@kernel.org>

On Fri, Oct 30, 2026 at 03:29:58PM -0700, Kees Cook wrote:
> On Tue, Oct 20, 2026 at 02:52:18PM -0700, Nathan Chancellor wrote:
> > Ricardo reported another issue with moving this check from Kbuild to
> > Kconfig, as '-mfentry' is not supported for x86_32 without '-fno-pic',
> > which affects GCC builds that are configured with PIE enabled by
> > default. arch/x86/Makefile adds '-fno-pic' to KBUILD_CFLAGS, so this
> > works properly in Kbuild.
> 
> FWIW, Debian's i686-linux-gnu-gcc 16.2.0 hits this too: ARCH=i386
> allmodconfig fails at scripts/mod/empty.o with "'-pg' without '-mfentry'
> may be unreliable with shrink wrapping" under -Werror. With this patch
> on top of Linus's tree, the whole build is clean.
> 
> Tested-by: Kees Cook <kees@kernel.org>

Thanks for testing! This patch is now in 7.4-rc1, I never sent out a
thanks message:

  https://git.kernel.org/linus/9a6882502d353b89fd2c82b03d9267c94684e4b2

I had applied these for testing pretty quickly and never picked up tags,
which isn't great on my part :/ but at least they will live on the
mailing list.

-- 
Cheers,
Nathan

  reply	other threads:[~2026-11-02 18:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20 21:52 [PATCH 0/2] kbuild: Fallout from moving '-mfentry' check into Kconfig stage Nathan Chancellor
2026-10-20 21:52 ` [PATCH 1/2] kbuild: Move testing of '-mfentry' back to Makefile from Kconfig Nathan Chancellor
2026-10-21 14:44   ` Kees Cook
2026-10-21 18:25     ` Nathan Chancellor
2026-10-30 22:29   ` Kees Cook
2026-11-02 18:53     ` Nathan Chancellor [this message]
2026-10-20 21:52 ` [PATCH 2/2] scripts/Kconfig.toolchain: Highlight cc-option differences between Kconfig and Kbuild Nathan Chancellor
2026-10-20 23:48 ` [PATCH 0/2] kbuild: Fallout from moving '-mfentry' check into Kconfig stage Ricardo Ribalda
2026-10-21 13:31 ` Lorenzo Stoakes (ARM)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261102185300.GA1177738@ax162 \
    --to=nathan@kernel.org \
    --cc=julianbraha@gmail.com \
    --cc=kees@kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=ljs@kernel.org \
    --cc=nsc@kernel.org \
    --cc=ribalda@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®