From: Frank.Li@oss.nxp.com
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Frank Li <Frank.Li@nxp.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org (open list:MEDIA INPUT
INFRASTRUCTURE (V4L/DVB)),
linux-kernel@vger.kernel.org (open list)
Cc: imx@lists.linux.dev, vkoul@kernel.org
Subject: [PATCH v2 3/3] media: pxa_camera: use cookie returned by dmaengine_submit() for logging
Date: Mon, 2 Nov 2026 14:46:50 -0500 [thread overview]
Message-ID: <20261102194700.4076807-3-Frank.Li@oss.nxp.com> (raw)
In-Reply-To: <20261102194700.4076807-1-Frank.Li@oss.nxp.com>
From: Frank Li <Frank.Li@nxp.com>
The debug print in pxa_dma_add_tail_buf() was logging buf->descs[i]->cookie
instead of buf->cookie[i].
dmaengine_submit() returns the cookie and it is stored in buf->cookie[i],
so use that value in the dev_dbg() call to accurately reflect the submitted
cookie.
Prepare to make struct dma_async_tx_descriptor private to the DMA engine.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
drivers/media/platform/intel/pxa_camera.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/intel/pxa_camera.c b/drivers/media/platform/intel/pxa_camera.c
index c9d57e4245181..d41cca2b2d8c2 100644
--- a/drivers/media/platform/intel/pxa_camera.c
+++ b/drivers/media/platform/intel/pxa_camera.c
@@ -903,7 +903,7 @@ static void pxa_dma_add_tail_buf(struct pxa_camera_dev *pcdev,
buf->cookie[i] = dmaengine_submit(buf->descs[i]);
dev_dbg(pcdev_to_dev(pcdev),
"%s (channel=%d) : submit vb=%p cookie=%d\n",
- __func__, i, buf, buf->descs[i]->cookie);
+ __func__, i, buf, buf->cookie[i]);
}
}
--
2.43.0
prev parent reply other threads:[~2026-11-02 19:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 19:46 [PATCH v2 1/3] media: omap3isp: hist: use dmaengine_submit() instead of ->tx_submit() Frank.Li
2026-11-02 19:46 ` [PATCH v2 2/3] media: use dmaengine_desc_set_callback() Frank.Li
2026-11-02 20:24 ` Nicolas Dufresne
2026-11-02 19:46 ` Frank.Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261102194700.4076807-3-Frank.Li@oss.nxp.com \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=imx@lists.linux.dev \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®