mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Janne Grunau <j@jannau.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: michael.reeves077@gmail.com,
	Pieter-Paul Giesberts <pieterpg@broadcom.com>,
	"Franky Lin (Zhenhui)" <frankyl@broadcom.com>,
	Mathy Vanhoef <vanhoefm@gmail.com>, Kalle Valo <kvalo@kernel.org>,
	Kees Cook <kees@kernel.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
	brcm80211-dev-list.pdl@broadcom.com, asahi@lists.linux.dev,
	Hector Martin <marcan@marcan.st>,
	Daniel Berlin <dberlin@dberlin.org>,
	linux-kernel@vger.kernel.org,
	Hante Meuleman <meuleman@broadcom.com>,
	linux-hardening@vger.kernel.org,
	Peter Robinson <pbrobinson@gmail.com>,
	Izabela Bakollari <ibakolla@redhat.com>
Subject: Re: [PATCH 00/13] wifi: brcmfmac: Add BCM4388 support
Date: Mon, 2 Nov 2026 21:46:27 +0100	[thread overview]
Message-ID: <20261102204627.GB770347@robin.jannau.net> (raw)
In-Reply-To: <d78cbbd2-601a-4cf1-800f-3be57a2b7de2@broadcom.com>

On Sun, Nov 01, 2026 at 08:27:22PM +0100, Arend van Spriel wrote:
> + Peter, Izabela
> 
> On 25/09/2026 15:43, Michael Reeves via B4 Relay wrote:
> > The Broadcom BCM4388 chipset requires new PCIe initialization and
> > firmware interfaces. Add support for these interfaces to brcmfmac to
> > enable basic station operation.
> > 
> > This series adds:
> > - Signed firmware loading and mailbox transport
> > - Fixes for chip identification and firmware capability matching
> > - Versioned scan and join requests, and extended PMK payloads
> > - Updated event mask handling
> > 
> > These changes include work by Hector Martin and Daniel Berlin from Asahi
> > Linux, refactored where needed for upstream inclusion.
> > 
> > The series provides basic station support only. 6 GHz support is planned
> > for a follow-up patchset after this lands. The driver retains legacy
> > interfaces for older firmware.
> > 
> > Tested on an Apple M3 MacBook Air (J613):
> > - Device boot and network scanning
> > - 5 GHz WPA2-PSK association and DHCP
> > - Bidirectional TCP traffic
> 
> Finally got some time to get this series tested on my setup. The patches 
> generally look good. So far no regressions observed. It would be good if 
> some more people could test this series on their equipment. I will do 
> some more testing and wait some days.

Tested series on top of v7.3 + commit 7ed5dce55fa8 ("wifi: brcmfmac: map
msgbuf RX packet IDs bidirectional") in wireless/main with resolving the
conflict by dropping the conflicting hunk of this series.

Tested on Mac mini (M1, BCM4378) and Macbook Pro 14-inch (M1 Max,
BCM4387) without regressions (except for the resolved RX msgbuf
mapping).

Tested-by: Janne Grunau <j@jannau.net>

thanks,

Janne

  reply	other threads:[~2026-11-02 20:46 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25 13:43 Michael Reeves via B4 Relay
2026-09-25 13:43 ` [PATCH 01/13] wifi: brcmfmac: pcie: Report the detected chip ID to the bus Michael Reeves via B4 Relay
2026-11-03 13:58   ` Arend van Spriel
2026-09-25 13:43 ` [PATCH 02/13] wifi: brcmfmac: Match complete firmware capability names Michael Reeves via B4 Relay
2026-11-03 13:58   ` Arend van Spriel
2026-09-25 13:43 ` [PATCH 03/13] wifi: brcmfmac: Fall back to RSSI-only default join preferences Michael Reeves via B4 Relay
2026-11-03 13:58   ` Arend van Spriel
2026-09-25 13:43 ` [PATCH 04/13] wifi: brcmfmac: Support newer PCIe core startup and interrupts Michael Reeves via B4 Relay
2026-11-03 13:58   ` Arend van Spriel
2026-09-25 13:43 ` [PATCH 05/13] wifi: brcmfmac: Negotiate PCIe mailbox transport with firmware Michael Reeves via B4 Relay
2026-11-03 13:58   ` Arend van Spriel
2026-09-25 13:43 ` [PATCH 06/13] wifi: brcmfmac: Load signed PCIe firmware images Michael Reeves via B4 Relay
2026-11-03 13:58   ` Arend van Spriel
2026-09-25 13:43 ` [PATCH 07/13] wifi: brcmfmac: Use event_msgs_ext for event masks Michael Reeves via B4 Relay
2026-11-03 13:58   ` Arend van Spriel
2026-09-25 13:43 ` [PATCH 08/13] wifi: brcmfmac: Handle larger firmware band lists Michael Reeves via B4 Relay
2026-11-03 13:58   ` Arend van Spriel
2026-09-25 13:43 ` [PATCH 09/13] wifi: brcmfmac: Accept newer BSS information versions Michael Reeves via B4 Relay
2026-11-03 13:58   ` Arend van Spriel
2026-09-25 13:43 ` [PATCH 10/13] wifi: brcmfmac: Support versioned scan parameter layouts Michael Reeves via B4 Relay
2026-11-03 13:58   ` Arend van Spriel
2026-09-25 13:43 ` [PATCH 11/13] wifi: brcmfmac: Support versioned join requests Michael Reeves via B4 Relay
2026-11-03 13:58   ` Arend van Spriel
2026-09-25 13:43 ` [PATCH 12/13] wifi: brcmfmac: Handle extended PMK command payloads Michael Reeves via B4 Relay
2026-11-03 13:58   ` Arend van Spriel
2026-09-25 13:43 ` [PATCH 13/13] wifi: brcmfmac: Add BCM4388 support Michael Reeves via B4 Relay
2026-11-02 20:36   ` Janne Grunau
2026-11-03 13:58   ` Arend van Spriel
2026-10-07 12:54 ` [PATCH 00/13] " Arend van Spriel
2026-11-01 19:27 ` Arend van Spriel
2026-11-02 20:46   ` Janne Grunau [this message]
2026-11-03 13:51     ` Arend van Spriel
2026-11-02  0:42 ` Neal Gompa
2026-11-02 16:58   ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261102204627.GB770347@robin.jannau.net \
    --to=j@jannau.net \
    --cc=arend.vanspriel@broadcom.com \
    --cc=asahi@lists.linux.dev \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211@lists.linux.dev \
    --cc=dberlin@dberlin.org \
    --cc=frankyl@broadcom.com \
    --cc=gustavoars@kernel.org \
    --cc=ibakolla@redhat.com \
    --cc=kees@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=meuleman@broadcom.com \
    --cc=michael.reeves077@gmail.com \
    --cc=pbrobinson@gmail.com \
    --cc=pieterpg@broadcom.com \
    --cc=vanhoefm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®