From: Patrick Zhang <patrzhan@amazon.com>
To: <netdev-bot+sashiko@kernel.org>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol@kernel.org>, <linux-can@vger.kernel.org>,
Pavel Pisa <pisa@cmp.felk.cvut.cz>,
Ondrej Ille <ondrej.ille@gmail.com>, Harini T <harini.t@amd.com>,
Michal Simek <michal.simek@amd.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
"Jakub Kicinski" <kuba@kernel.org>
Subject: Re: [PATCH v2 3/3] can: ifi_canfd: enable NAPI before starting the controller
Date: Mon, 2 Nov 2026 22:59:45 +0000 [thread overview]
Message-ID: <20261102225945.1257987-1-patrzhan@amazon.com> (raw)
In-Reply-To: <179353749137.3127.3654469722382202292@kernel.org>
On Sun, 01 Nov 2026 12:51, netdev-bot+sashiko wrote:
> With NAPI enabled here, can ifi_canfd_poll() now run at the same time as
> the rest of ifi_canfd_start()?
I think the analysis is right, and moving the CAN state and the error
counter writes into ifi_canfd_reset_config() and masking the interrupts
there makes sense. With those changes, the patch reorders the reset,
error counter and interrupt mask writes on both the open and the bus-off
restart paths. At that point the change is no longer obviously correct
by inspection, and I do not have IFI CAN FD hardware to test it, so I
am not confident continuing with it.
I will drop this patch and send v3 with only the ctucanfd and xilinx_can
patches. The race in ifi_canfd_open() remains, and this thread may be a
useful starting point for someone who can test a fix.
pw-bot: cr
prev parent reply other threads:[~2026-11-02 23:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 23:33 [PATCH v2 0/3] can: enable NAPI before starting the controller in three drivers Patrick Zhang
2026-10-30 23:33 ` [PATCH v2 1/3] can: ctucanfd: enable NAPI before starting the controller Patrick Zhang
2026-10-30 23:33 ` [PATCH v2 2/3] can: xilinx_can: " Patrick Zhang
2026-11-02 6:20 ` T, Harini
2026-10-30 23:33 ` [PATCH v2 3/3] can: ifi_canfd: " Patrick Zhang
2026-11-01 12:51 ` netdev-bot+sashiko
2026-11-02 22:59 ` Patrick Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261102225945.1257987-1-patrzhan@amazon.com \
--to=patrzhan@amazon.com \
--cc=harini.t@amd.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=michal.simek@amd.com \
--cc=mkl@pengutronix.de \
--cc=netdev-bot+sashiko@kernel.org \
--cc=ondrej.ille@gmail.com \
--cc=pisa@cmp.felk.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®