From: Philipp Zabel <p.zabel@pengutronix.de>
To: Damien Le Moal <dlemoal@kernel.org>,
Conor Dooley <conor.dooley@microchip.com>,
Valentina Fernandez <valentina.fernandezalanis@microchip.com>,
Daire McNamara <daire.mcnamara@microchip.com>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Michal Simek <michal.simek@amd.com>
Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-renesas-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: [PATCH 5/8] reset: mpfs: Use regmap_test_bits in mpfs_status
Date: Tue, 03 Nov 2026 15:51:25 +0100 [thread overview]
Message-ID: <20261103-reset-regmap-test-bits-v1-5-1b33607a76b0@pengutronix.de> (raw)
In-Reply-To: <20261103-reset-regmap-test-bits-v1-0-1b33607a76b0@pengutronix.de>
Simplify mpfs_status() by using regmap_test_bits().
Now returns 1 if asserted for all bits.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/reset/reset-mpfs.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/reset/reset-mpfs.c b/drivers/reset/reset-mpfs.c
index 8ffcc54ee6f6..ec61b4a1d753 100644
--- a/drivers/reset/reset-mpfs.c
+++ b/drivers/reset/reset-mpfs.c
@@ -63,15 +63,8 @@ static int mpfs_deassert(struct reset_controller_dev *rcdev, unsigned long id)
static int mpfs_status(struct reset_controller_dev *rcdev, unsigned long id)
{
struct mpfs_reset *rst = to_mpfs_reset(rcdev);
- u32 reg;
- regmap_read(rst->regmap, REG_SUBBLK_RESET_CR, ®);
-
- /*
- * It is safe to return here as MPFS_NUM_RESETS makes sure the sign bit
- * is never hit.
- */
- return (reg & BIT(id));
+ return regmap_test_bits(rst->regmap, REG_SUBBLK_RESET_CR, BIT(id));
}
static int mpfs_reset(struct reset_controller_dev *rcdev, unsigned long id)
--
2.47.3
next prev parent reply other threads:[~2026-11-03 14:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 14:51 [PATCH 0/8] reset: Use regmap_test_bits to simplify status callbacks Philipp Zabel
2026-11-03 14:51 ` [PATCH 1/8] reset: a10sr: Use regmap_test_bits in a10sr_reset_status Philipp Zabel
2026-11-03 14:51 ` [PATCH 2/8] reset: reset-intel-gw: Use regmap_reset_bits in intel_reset_status Philipp Zabel
2026-11-03 14:51 ` [PATCH 3/8] reset: k210: Use regmap_test_bits in k210_rst_status Philipp Zabel
2026-11-03 20:01 ` Damien Le Moal
2026-11-03 14:51 ` [PATCH 4/8] reset: lantiq: Use regmap_test_bits in lantiq_rcu_reset_status Philipp Zabel
2026-11-03 14:51 ` Philipp Zabel [this message]
2026-11-03 14:51 ` [PATCH 6/8] reset: rzv2h-usb2phy: Use regmap_test_bits in rzv2h_usbphy_reset_status Philipp Zabel
2026-11-03 14:51 ` [PATCH 7/8] reset: zynq: Use regmap_test_bits in zynq_reset_status Philipp Zabel
2026-11-03 14:51 ` [PATCH 8/8] reset: tn48m: Use regmap_test_bits in tn48m_control_status Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103-reset-regmap-test-bits-v1-5-1b33607a76b0@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=dlemoal@kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=michal.simek@amd.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=valentina.fernandezalanis@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®