From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793745755; b=KFxrbKdR1M56jTgao0+t7ch8hfHt5Wl7M1tmmlC24vbCgLka5j5zshAmnIWyIJINRAiQ VG6xfvhSB+qFDg/QCB+LLGPjD+6RpR90oU0C4O7Mt5A1Jy0MMA/LChGA6g/AEa0rVqDWg i1fKq2wRbGvdieCQHolfQ4/xAJU2eXKDLIMJpggSgbSO5Yx8YgQzMcLrGuBwOYDi49KNM xDijnMdP2NE2Awu9mqTa35FuCb9nEdRTNo+YtwQWgXZ7Y9z7upoHhfN16ErB7RTlLXM8h qDnd6Th5qAEYKorQMxY5yQLn4CWqqEH2kQQ28NXegqHFqGEJRgEZOGecTiJaZl6aWlQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793745755; h=Received:DKIM-Signature:From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:References:In-Reply-To:To:Cc: X-Mailer; bh=PEvKgHuzMcEqcFdxZxPthE75TieLrA0urwCwR3k19ac=; b=LOYQFNOPsFgwl7FHhn3ZMmZYxzJCdEnVSKmauX4Hu9V3T5MIpFbQbtKbyVM1jH0DW/sA Cj1tq/dSVtH+1tg6XjI8OFAtZoBZ/V4Xma21d8aDm1wbgBwlQw230PIRJm2Gj5zIBIxKe XtHszT52tvmpTBSCu0eNbfy52X4Yz169cuL6nVWt4fHrPPDMHq67dcggx3xNQTJBpeosd 77Ixw0CLes4nyFeMtkZaAUil33YE9kjz/CZYDfhcUfa3RHoZBhFkJMPVE881ZEBrKO8Dk ivJkWW2Vf89rQ6+gvXnZ8Dzvcz1UPiK8B75XdVQXOufcN3ioUbItC4CUlvobwTjkNxA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ngCPkUY0; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A656C606D807 for ; Tue, 3 Nov 2026 22:42:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ngCPkUY0 Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3E2A1F00A18; Tue, 3 Nov 2026 22:42:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793745754; bh=PEvKgHuzMcEqcFdxZxPthE75TieLrA0urwCwR3k19ac=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=ngCPkUY0jlR5Djwrf4nIjSIorDE1ghYkWYzgJSc1vgf4n9R9yaGn3wULmw0KOcstt 6aZGCzzU4BeKvANk8Gfa/qHtpmfmDbRX+zXEvNMWUY3HsGEbcy5yzNikUJmgTPC7MC +1+yY1aExPT3mr+4jratPgIP8zrDN0DsMS9F1PVS22AskyURF0L025OV8bLuhlemRR 0Kx9HCZgOzqrhIfDumPV313oJFhKOMaPW7pdcwwZ7O/Ji6M/7M5l7jT3dLX7uJbO+V 4aFXp/rjwtb7uv/PAlvQ0io6IwjFq/gv5VLqlRiew35lIjfsa/Iq7PRrp5h67G6LYv K7U61LGn4wCYA== From: "Mario Limonciello (AMD)" Date: Tue, 03 Nov 2026 16:42:11 -0600 Subject: [PATCH v11 10/12] drm/gud: add connector luminance support X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261103-superm1-backlight-property-v11-10-00cce7b2ba22@kernel.org> References: <20261103-superm1-backlight-property-v11-0-00cce7b2ba22@kernel.org> In-Reply-To: <20261103-superm1-backlight-property-v11-0-00cce7b2ba22@kernel.org> To: Maxime Ripard , Alex Deucher , Jani Nikula , Javier Martinez Canillas , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Harry Wentland , Leo Li , Rodrigo Siqueira Cc: Mario Limonciello , Xaver Hugl , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org, Mario Limonciello X-Mailer: b4 0.16.0 From: Mario Limonciello Expose GUD display brightness through the connector LUMINANCE property when DRM_LUMINANCE is enabled. The value is mirrored into tv.brightness during atomic check so it is sent to the device with GUD_REQ_SET_STATE_CHECK in the same commit. Signed-off-by: Mario Limonciello --- v11: * Apply LUMINANCE in the atomic commit instead of a worker, fixing an endless commit loop, a use-after-free on disconnect and brightness being clobbered on DPMS off (Sashiko) * Attach the property at connector init (Sashiko) * Keep selecting BACKLIGHT_CLASS_DEVICE (Sashiko) --- drivers/gpu/drm/gud/gud_connector.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/gud/gud_connector.c b/drivers/gpu/drm/gud/gud_connector.c index ddbf3b3ebbca8..bfb298bbc9b51 100644 --- a/drivers/gpu/drm/gud/gud_connector.c +++ b/drivers/gpu/drm/gud/gud_connector.c @@ -292,10 +292,19 @@ static int gud_connector_atomic_check(struct drm_connector *connector, struct drm_connector_state *old_state; new_state = drm_atomic_get_new_connector_state(state, connector); + old_state = drm_atomic_get_old_connector_state(state, connector); + + /* + * LUMINANCE is sent to the device as tv.brightness in the same commit, + * the brightness change below then triggers GUD_REQ_SET_STATE_CHECK. + */ + if (connector->luminance_property && + old_state->luminance != new_state->luminance) + new_state->tv.brightness = new_state->luminance; + if (!new_state->crtc) return 0; - old_state = drm_atomic_get_old_connector_state(state, connector); new_crtc_state = drm_atomic_get_new_crtc_state(state, new_state->crtc); if (old_state->tv.margins.left != new_state->tv.margins.left || @@ -324,7 +333,7 @@ static int gud_connector_late_register(struct drm_connector *connector) { struct gud_connector *gconn = to_gud_connector(connector); - if (gconn->initial_brightness < 0) + if (IS_ENABLED(CONFIG_DRM_LUMINANCE) || gconn->initial_brightness < 0) return 0; return gud_connector_backlight_register(gconn); @@ -699,6 +708,13 @@ static int gud_connector_create(struct gud_device *gdrm, unsigned int index, return ret; } + if (IS_ENABLED(CONFIG_DRM_LUMINANCE) && gconn->initial_brightness >= 0) { + ret = drm_connector_attach_luminance_property(connector, 0, 100, + gconn->initial_brightness); + if (ret) + return ret; + } + gconn->encoder.possible_crtcs = drm_crtc_mask(&gdrm->crtc); ret = drm_encoder_init(drm, &gconn->encoder, &gud_drm_simple_encoder_funcs_cleanup, DRM_MODE_ENCODER_NONE, NULL); -- 2.53.0