From: Wei Liu <wei.liu@kernel.org>
To: Michael Kelley <mhklinux@outlook.com>
Cc: "mdshahid03@gmail.com" <mdshahid03@gmail.com>,
"haiyangz@microsoft.com" <haiyangz@microsoft.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
"decui@microsoft.com" <decui@microsoft.com>,
"tglx@kernel.org" <tglx@kernel.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/hyperv: use pointed-to type size for page table offsets
Date: Mon, 2 Nov 2026 17:09:05 -0800 [thread overview]
Message-ID: <20261103010905.GD1862133@liuwe-devbox-debian-v2.local> (raw)
In-Reply-To: <MN2PR02MB6863DEE71E0B43A5850ED6C1D46B2@MN2PR02MB6863.namprd02.prod.outlook.com>
On Sun, Nov 01, 2026 at 10:41:05PM +0000, Michael Kelley wrote:
> From: mdshahid03@gmail.com <mdshahid03@gmail.com> Sent: Sunday, November 1, 2026 1:21 AM
> >
> > The Hyper-V crash trampoline code calculated page table entry
> > offsets using sizeof() on pointer variables.
> >
> > Use sizeof(*ptr) instead to calculates the size of the
> > pointed-to page table entry.
> >
> > This makes entry size explicit and avoids relying on the
> > pointer size matching the page table entry size.
> >
> > This issue was reported by Coccinelle script noderef.cocci.
>
> FWIW, this issue was also reported by the kernel test robot.
> See [1] & [2]. So you should probably add "Reported-by:" and
> "Closes: " tags for those reports.
>
> In any case, the fix looks good to me.
>
> Reviewed-by: Michael Kelley <mhklinux@outlook.com>
>
> [1] https://lore.kernel.org/lkml/202603101143.qUL1R1iy-lkp@intel.com/
> [2] https://lore.kernel.org/lkml/202610080503.ivDF5iYX-lkp@intel.com/
Applied. Thanks.
Wei
prev parent reply other threads:[~2026-11-03 1:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-01 8:20 mdshahid03
2026-11-01 22:41 ` Michael Kelley
2026-11-03 1:09 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103010905.GD1862133@liuwe-devbox-debian-v2.local \
--to=wei.liu@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdshahid03@gmail.com \
--cc=mhklinux@outlook.com \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®