mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>, Kees Cook <kees@kernel.org>,
	Tony Luck <tony.luck@intel.com>,
	"Guilherme G. Piccoli" <gpiccoli@igalia.com>
Subject: [PATCH v2] pstore: fixup struct member comments
Date: Mon,  2 Nov 2026 17:53:50 -0800	[thread overview]
Message-ID: <20261103015350.2475615-1-rdunlap@infradead.org> (raw)

Documenting the callback function parameters is great, but kernel-doc
doesn't support that. Drop the leading '@' sign from these comments to
avoid kernel-doc warnings:

Warning: ../include/linux/pstore.h:201 Excess struct member 'psi' description in 'pstore_info'
Warning: ../include/linux/pstore.h:201 Excess struct member 'record' description in 'pstore_info'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
v2: rebase & resend

Cc: Kees Cook <kees@kernel.org>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Guilherme G. Piccoli <gpiccoli@igalia.com>

 include/linux/pstore.h |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

--- linux-next-20261102.orig/include/linux/pstore.h
+++ linux-next-20261102/include/linux/pstore.h
@@ -114,7 +114,7 @@ struct pstore_record {
  *	Notify backend that pstore is starting a full read of backend
  *	records. Followed by one or more @read calls, and a final @close.
  *
- *	@psi:	in: pointer to the struct pstore_info for the backend
+ *	psi:	in: pointer to the struct pstore_info for the backend
  *
  *	Returns 0 on success, and non-zero on error.
  *
@@ -123,7 +123,7 @@ struct pstore_record {
  *	records. Always preceded by an @open call and one or more @read
  *	calls.
  *
- *	@psi:	in: pointer to the struct pstore_info for the backend
+ *	psi:	in: pointer to the struct pstore_info for the backend
  *
  *	Returns 0 on success, and non-zero on error. (Though pstore will
  *	ignore the error.)
@@ -132,7 +132,7 @@ struct pstore_record {
  *	Read next available backend record. Called after a successful
  *	@open.
  *
- *	@record:
+ *	record:
  *		pointer to record to populate. @buf should be allocated
  *		by the backend and filled. At least @type and @id should
  *		be populated, since these are used when creating pstorefs
@@ -144,7 +144,7 @@ struct pstore_record {
  * @write:
  *	A newly generated record needs to be written to backend storage.
  *
- *	@record:
+ *	record:
  *		pointer to record metadata. When @type is PSTORE_TYPE_DMESG,
  *		@buf will be pointing to the preallocated @psi.buf, since
  *		memory allocation may be broken during an Oops. Regardless,
@@ -162,8 +162,8 @@ struct pstore_record {
  *	buffer that is coming directly from userspace, instead of the
  *	@record @buf.
  *
- *	@record:	pointer to record metadata.
- *	@buf:		pointer to userspace contents to write to backend
+ *	record:	pointer to record metadata.
+ *	buf:		pointer to userspace contents to write to backend
  *
  *	Returns 0 on success, and non-zero on error.
  *
@@ -173,7 +173,7 @@ struct pstore_record {
  *	passed back to assist in identification of what the backend
  *	should remove from storage.
  *
- *	@record:	pointer to record metadata.
+ *	record:	pointer to record metadata.
  *
  *	Returns 0 on success, and non-zero on error.
  *

                 reply	other threads:[~2026-11-03  1:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261103015350.2475615-1-rdunlap@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=gpiccoli@igalia.com \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®