From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>, Thomas Graf <tgraf@suug.ch>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-crypto@vger.kernel.org
Subject: [PATCH] rhashtable: headers: add missing members, remove excess ones
Date: Mon, 2 Nov 2026 19:15:47 -0800 [thread overview]
Message-ID: <20261103031547.2662864-1-rdunlap@infradead.org> (raw)
Add or remove kernel-doc comments for missing or excess struct members
and function (or macro) parameters to prevent these kernel-doc warnings:
Warning: include/linux/rhashtable-types.h:108 struct member 'alloc_tag' not described in 'rhashtable'
Warning: include/linux/rhashtable-types.h:108 struct member 'lockdep_key' not described in 'rhashtable'
Warning: include/linux/rhashtable-types.h:145 struct member 'end_of_table' not described in 'rhashtable_iter'
Warning: include/linux/rhashtable-types.h:199 Excess function parameter 'ht' description in 'rhashtable_init'
Warning: include/linux/rhashtable-types.h:199 Excess function parameter 'params' description in 'rhashtable_init'
Warning: include/linux/rhashtable-types.h:220 Excess function parameter 'hlt' description in 'rhltable_init'
Warning: include/linux/rhashtable-types.h:220 Excess function parameter 'params' description in 'rhltable_init'
Warning: include/linux/rhashtable.h:87 struct member 'dep_map' not described in 'bucket_table'
Warning: include/linux/rhashtable.h:87 Excess struct member 'rehash' description in 'bucket_table'
Warning: include/linux/rhashtable.h:87 Excess struct member 'ntbl' description in 'bucket_table'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Thomas Graf <tgraf@suug.ch>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org
include/linux/rhashtable-types.h | 11 +++++++----
include/linux/rhashtable.h | 3 +--
2 files changed, 8 insertions(+), 6 deletions(-)
--- linux-next-20261102.orig/include/linux/rhashtable.h
+++ linux-next-20261102/include/linux/rhashtable.h
@@ -65,12 +65,11 @@ struct rhash_lock_head {};
* struct bucket_table - Table of hash buckets
* @size: Number of hash buckets
* @nest: Number of bits of first-level nested table.
- * @rehash: Current bucket being rehashed
* @hash_rnd: Random seed to fold into hash
* @walkers: List of active walkers
* @rcu: RCU structure for freeing the table
* @future_tbl: Table under construction during rehashing
- * @ntbl: Nested table used when out of memory.
+ * @dep_map: Lockdep tracking map
* @buckets: size * hash buckets
*/
struct bucket_table {
--- linux-next-20261102.orig/include/linux/rhashtable-types.h
+++ linux-next-20261102/include/linux/rhashtable-types.h
@@ -88,6 +88,8 @@ struct rhashtable_lockdep_keys {
* @mutex: Mutex to protect current/future table swapping
* @lock: Spin lock to protect walker list
* @nelems: Number of elements in table
+ * @alloc_tag: Allocation codetag and percpu counters
+ * @lockdep_key: Lockdep keys for each lock
*/
struct rhashtable {
struct bucket_table __rcu *tbl;
@@ -134,6 +136,7 @@ struct rhashtable_walker {
* @walker: Associated rhashtable walker
* @slot: Current slot
* @skip: Number of entries to skip in slot
+ * @end_of_table: End of table walk has been reached
*/
struct rhashtable_iter {
struct rhashtable *ht;
@@ -157,8 +160,8 @@ int __rhashtable_init_noprof(struct rhas
/**
* rhashtable_init - initialize a new hash table
- * @ht: hash table to be initialized
- * @params: configuration parameters
+ * @...: variable args list: hash table to be initialized and
+ * configuration parameters
*
* Initializes a new hash table based on the provided configuration
* parameters. A table can be configured either with a variable or
@@ -211,8 +214,8 @@ int __rhltable_init_noprof(struct rhltab
/**
* rhltable_init - initialize a new hash list table
- * @hlt: hash list table to be initialized
- * @params: configuration parameters
+ * @...: variable args list: hash list table to be initialized and
+ * configuration parameters
*
* Initializes a new hash list table.
*
next reply other threads:[~2026-11-03 3:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 3:15 Randy Dunlap [this message]
2026-11-13 13:05 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103031547.2662864-1-rdunlap@infradead.org \
--to=rdunlap@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®