From: David Yang <mmyangfl@gmail.com>
To: linux-crypto@vger.kernel.org
Cc: "David Yang" <mmyangfl@gmail.com>,
"Olivia Mackall" <olivia@selenic.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
"Danilo Krummrich" <dakr@kernel.org>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] hwrng: histb: use device messages
Date: Tue, 3 Nov 2026 12:14:00 +0800 [thread overview]
Message-ID: <20261103041403.4071708-3-mmyangfl@gmail.com> (raw)
In-Reply-To: <20261103041403.4071708-1-mmyangfl@gmail.com>
pr_*() prints without saying which device the message came from. Print
with dev_*() instead and adjust error messages.
Signed-off-by: David Yang <mmyangfl@gmail.com>
---
drivers/char/hw_random/histb-rng.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/char/hw_random/histb-rng.c b/drivers/char/hw_random/histb-rng.c
index d435d4ab9aa7..d28cc84e8367 100644
--- a/drivers/char/hw_random/histb-rng.c
+++ b/drivers/char/hw_random/histb-rng.c
@@ -22,6 +22,7 @@
struct histb_rng_priv {
struct hwrng rng;
+ struct device *dev;
void __iomem *base;
};
@@ -71,8 +72,9 @@ static int histb_rng_read(struct hwrng *rng, void *data, size_t max, bool wait)
if (!wait)
return i;
if (histb_rng_wait(base)) {
- pr_err("failed to generate random number, generated %d\n",
- i);
+ dev_err(priv->dev,
+ "RNG timeout, generated %d of %zu bytes\n",
+ i, max);
return i ? i : -ETIMEDOUT;
}
}
@@ -142,6 +144,7 @@ static int histb_rng_probe(struct platform_device *pdev)
}
priv->base = base;
+ priv->dev = dev;
priv->rng.name = pdev->name;
priv->rng.read = histb_rng_read;
ret = devm_hwrng_register(dev, &priv->rng);
--
2.53.0
prev parent reply other threads:[~2026-11-03 4:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 4:13 [PATCH 0/2] hwrng: histb: fix the FIFO batch timeout David Yang
2026-11-03 4:13 ` [PATCH 1/2] hwrng: histb: wait for a batch of words David Yang
2026-11-03 4:14 ` David Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103041403.4071708-3-mmyangfl@gmail.com \
--to=mmyangfl@gmail.com \
--cc=bhelgaas@google.com \
--cc=dakr@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=olivia@selenic.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®