From: "Michael S. Tsirkin" <mst@redhat.com>
To: Guanglei Zhu <zhugl3@xiaopeng.com>
Cc: amit@kernel.org, virtualization@lists.linux.dev,
linux-kernel@vger.kernel.org, liuc63@xiaopeng.com
Subject: Re: [PATCH] virtio: console: check the control packet size before parsing it
Date: Tue, 3 Nov 2026 06:33:27 -0500 [thread overview]
Message-ID: <20261103062747-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20261103111734.472283-1-zhugl3@xiaopeng.com>
On Tue, Nov 03, 2026 at 07:17:34PM +0800, Guanglei Zhu wrote:
> You are right, the impact statement does not hold up: the reused
> buffer still contains a previously valid control message,
Not always, the buffers are allocated with GFP_KERNEL on the
1st pass.
> so a short
> packet makes the driver parse stale - not attacker-controlled - data,
Who is the attacker here the device? it is absolutely
controlling all of virtio_console_control.
> and that is not worth carrying an extra check for. Please drop this
> patch.
>
> Sorry for the noise, and thanks for the review.
I ask that you please think critically not just go back and forth on it
like an LLM.
--
MST
next prev parent reply other threads:[~2026-11-03 11:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 8:41 Guanglei Zhu
2026-11-03 9:39 ` Michael S. Tsirkin
2026-11-03 11:17 ` Guanglei Zhu
2026-11-03 11:33 ` Michael S. Tsirkin [this message]
2026-11-03 11:59 ` Guanglei Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103062747-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=amit@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuc63@xiaopeng.com \
--cc=virtualization@lists.linux.dev \
--cc=zhugl3@xiaopeng.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®