From: Wentao Liang <vulab@iscas.ac.cn>
To: sumit.semwal@linaro.org, christian.koenig@amd.com
Cc: phasta@kernel.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
linux-kernel@vger.kernel.org, Wentao Liang <vulab@iscas.ac.cn>,
stable@vger.kernel.org
Subject: [PATCH] dma-buf: Release input fences in the unwrap merge order test
Date: Tue, 3 Nov 2026 06:44:57 +0000 [thread overview]
Message-ID: <20261103064457.1056056-1-vulab@iscas.ac.cn> (raw)
The merge order test creates an array and a chain as inputs to
dma_fence_unwrap_merge(). The merge takes references to the underlying
fences but does not consume the input containers. The success path only
puts the merged result, leaking both the input array and the outer chain,
which owns the inner chain.
Put the outer chain after checking the merged result and fall through to
the existing array cleanup on success as well as failure.
The dma-buf-fence-unwrap KUnit suite passes all 11 tests under UML.
Fixes: b1cce631e61f ("dma-buf: add selftest for fence order after merge")
Cc: stable@vger.kernel.org
Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
drivers/dma-buf/st-dma-fence-unwrap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma-buf/st-dma-fence-unwrap.c b/drivers/dma-buf/st-dma-fence-unwrap.c
index c5353b36f0e4..8115a721dc88 100644
--- a/drivers/dma-buf/st-dma-fence-unwrap.c
+++ b/drivers/dma-buf/st-dma-fence-unwrap.c
@@ -437,7 +437,7 @@ static void test_unwrap_merge_order(struct kunit *test)
KUNIT_FAIL(test, "Not all fences seen!");
dma_fence_put(a2);
- return;
+ dma_fence_put(c2);
error_put_a1:
dma_fence_put(a1);
--
2.34.1
next reply other threads:[~2026-11-03 6:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 6:44 Wentao Liang [this message]
2026-11-03 7:27 ` Krzysztof Kozlowski
2026-11-03 8:18 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103064457.1056056-1-vulab@iscas.ac.cn \
--to=vulab@iscas.ac.cn \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=phasta@kernel.org \
--cc=stable@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®