mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zhan Xusheng <zhanxusheng1024@gmail.com>
To: thnkslprpt@gmail.com
Cc: rafael@kernel.org, viresh.kumar@linaro.org,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	zhanxusheng@xiaomi.com
Subject: Re: [PATCH] cpufreq: schedutil: Skip busy-CPU hold when NOHZ is disabled
Date: Tue,  3 Nov 2026 15:17:29 +0800	[thread overview]
Message-ID: <20261103071729.1556217-1-zhanxusheng1024@gmail.com> (raw)
In-Reply-To: <20261103061557.1235129-1-thnkslprpt@gmail.com>

Hi Avi,

On Tue, Nov 03, 2026 at 08:15:57AM +0200, Avi Weiss wrote:
> +	if (!tick_nohz_enabled)
> +		return false;

idle_calls also never moves when nohz is enabled but was never
activated, because tick_check_oneshot_change() found no oneshot clock
event device or no clocksource valid for high resolution. TS_FLAG_NOHZ
then stays clear, as with nohz=off. tick_nohz_is_active() covers both:

	if (!tick_nohz_is_active())
		return false;

Thanks,
Zhan Xusheng

  reply	other threads:[~2026-11-03  7:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03  6:15 Avi Weiss
2026-11-03  7:17 ` Zhan Xusheng [this message]
2026-11-03 11:03   ` Zhongqiu Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261103071729.1556217-1-zhanxusheng1024@gmail.com \
    --to=zhanxusheng1024@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=thnkslprpt@gmail.com \
    --cc=viresh.kumar@linaro.org \
    --cc=zhanxusheng@xiaomi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®