mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: shao.mingyin@zte.com.cn
Cc: hch@lst.de, mst@redhat.com, jasowangio@gmail.com,
	virtualization@lists.linux.dev, pbonzini@redhat.com,
	stefanha@redhat.com, eperezma@redhat.com, dlemoal@kernel.org,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio-blk: Fix zone append sector reporting in batched completion
Date: Tue, 3 Nov 2026 09:02:57 +0100	[thread overview]
Message-ID: <20261103080257.GB3975@lst.de> (raw)
In-Reply-To: <20261103080223.GA3975@lst.de>

On Tue, Nov 03, 2026 at 09:02:23AM +0100, Christoph Hellwig wrote:
> On Wed, Oct 28, 2026 at 10:27:08AM +0800, shao.mingyin@zte.com.cn wrote:
> > I looked into adding blktests coverage, and there is a structural
> > problem. blktests cannot issue REQ_OP_ZONE_APPEND from userspace: fio's
> > --zone_append goes through the io_uring_cmd NVMe passthrough path, so it
> > never reaches the driver's zone-append completion, and zbdioctl has no
> > append operation. blktests has no zone-append test today for the same
> > reason.
> 
> Right.
> 
> > That does not fit blktests, which is a block-layer test suite driven
> > from userspace. Two options as I see it:
> > 
> >   1. an XFS reproducer (e.g. xfstests) - the one that actually
> >      exercises the append completion path, or
> >   2. a blktests zbd test that covers a zoned virtio-blk with poll
> >      queues, which would not reach the append part itself.
> > 
> > I am happy to write either, or to leave it if you think the coverage
> > is not worth the churn. Which do you prefer?
> 
> We do have some blktests test that use a file system in the zbd
> category (zbd/009, zbd/010, zbd/014) so I think we could do this in
> blktests.  I.e. do a blktest that tests zoned polled I/O if we're
> on a zoned device that support polling.

OTOH xfstests might actually still fit better for this.  I guess
eiter way will work..

  reply	other threads:[~2026-11-03  8:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26 11:55 shao.mingyin
2026-10-27 15:06 ` Christoph Hellwig
     [not found]   ` <2026102810270846959TfFOThssBqrSo1PlP9X@zte.com.cn>
2026-11-03  8:02     ` Christoph Hellwig
2026-11-03  8:02       ` Christoph Hellwig [this message]
2026-10-27 19:17 ` Stefan Hajnoczi
2026-10-27 19:19 ` Michael S. Tsirkin
2026-11-03 14:31 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261103080257.GB3975@lst.de \
    --to=hch@lst.de \
    --cc=dlemoal@kernel.org \
    --cc=eperezma@redhat.com \
    --cc=jasowangio@gmail.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=shao.mingyin@zte.com.cn \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®