mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wentao Liang <vulab@iscas.ac.cn>
To: dennis.dalessandro@cornelisnetworks.com, jgg@ziepe.ca, leon@kernel.org
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
	Wentao Liang <vulab@iscas.ac.cn>,
	stable@vger.kernel.org
Subject: [PATCH] RDMA/hfi1: Free the trap send buffer when no address handle is available
Date: Tue,  3 Nov 2026 08:19:15 +0000	[thread overview]
Message-ID: <20261103081915.1147987-1-vulab@iscas.ac.cn> (raw)

send_trap() allocates a MAD send buffer before checking the subnet
manager address handle. If creating that handle fails, or if the subnet
manager LID is permissive, it unlocks and returns without submitting or
freeing the buffer. No send completion can release an unsubmitted MAD.

Free the send buffer after releasing the lock on both early returns,
matching the other failures after ib_create_send_mad().

Fixes: bf90aadd630c ("IB/hfi1: Send MAD traps until repressed")
Cc: stable@vger.kernel.org
Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
 drivers/infiniband/hw/hfi1/mad.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/infiniband/hw/hfi1/mad.c b/drivers/infiniband/hw/hfi1/mad.c
index 585f1d99b91b..dbc2dd55689e 100644
--- a/drivers/infiniband/hw/hfi1/mad.c
+++ b/drivers/infiniband/hw/hfi1/mad.c
@@ -335,12 +335,14 @@ static void send_trap(struct hfi1_ibport *ibp, struct trap_node *trap)
 			ah = hfi1_create_qp0_ah(ibp, ibp->rvp.sm_lid);
 			if (IS_ERR(ah)) {
 				spin_unlock_irqrestore(&ibp->rvp.lock, flags);
+				ib_free_send_mad(send_buf);
 				return;
 			}
 			send_buf->ah = ah;
 			ibp->rvp.sm_ah = ibah_to_rvtah(ah);
 		} else {
 			spin_unlock_irqrestore(&ibp->rvp.lock, flags);
+			ib_free_send_mad(send_buf);
 			return;
 		}
 	} else {
-- 
2.34.1


             reply	other threads:[~2026-11-03  8:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03  8:19 Wentao Liang [this message]
2026-11-03  9:21 ` Krzysztof Kozlowski
2026-11-04  8:10   ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261103081915.1147987-1-vulab@iscas.ac.cn \
    --to=vulab@iscas.ac.cn \
    --cc=dennis.dalessandro@cornelisnetworks.com \
    --cc=jgg@ziepe.ca \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®