mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shivang Upadhyay <shivangu@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com,
	chleroy@kernel.org, ritesh.list@gmail.com, sshegde@linux.ibm.com,
	sourabhjain@linux.ibm.com, rppt@kernel.org,
	ruanjinjie@huawei.com, baoquan.he@linux.dev,
	Shivang Upadhyay <shivangu@linux.ibm.com>,
	Anushree Mathur <anushree.mathur@linux.ibm.com>
Subject: [PATCH] powerpc/crash: update fdt on cpu hotplug remove
Date: Tue,  3 Nov 2026 14:23:19 +0530	[thread overview]
Message-ID: <20261103085319.51480-1-shivangu@linux.ibm.com> (raw)

Currently fdt for crash kernel is not updated on cpu hotplug remove,
which can lead to the following XIVE warnings on the crash kernel
bringup.

[    0.630795][    T1] xive: H_INT_GET_QUEUE_INFO cpu=16 prio=6 failed -55
[    0.630912][    T1] xive: Error -55 getting queue info CPU 16 prio 6
[    0.680899][    T1] xive: H_INT_GET_QUEUE_INFO cpu=17 prio=6 failed -55
[    0.681000][    T1] xive: Error -55 getting queue info CPU 17 prio 6

Fixing this by updating crash fdt on cpu hotplug remove path also.

Reported-by: Anushree Mathur <anushree.mathur@linux.ibm.com>
Suggested-by: Sourabh Jain <sourabhjain@linux.ibm.com>
Signed-off-by: Shivang Upadhyay <shivangu@linux.ibm.com>
---
 arch/powerpc/kexec/crash.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/powerpc/kexec/crash.c b/arch/powerpc/kexec/crash.c
index 775895f31037..0ef10e39ae49 100644
--- a/arch/powerpc/kexec/crash.c
+++ b/arch/powerpc/kexec/crash.c
@@ -639,8 +639,6 @@ void arch_crash_handle_hotplug_event(struct kimage *image, void *arg)
 
 	switch (image->hp_action) {
 	case KEXEC_CRASH_HP_REMOVE_CPU:
-		return;
-
 	case KEXEC_CRASH_HP_ADD_CPU:
 		update_crash_fdt(image);
 		break;
-- 
2.54.0


             reply	other threads:[~2026-11-03  8:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03  8:53 Shivang Upadhyay [this message]
2026-11-03  9:12 ` Jinjie Ruan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261103085319.51480-1-shivangu@linux.ibm.com \
    --to=shivangu@linux.ibm.com \
    --cc=anushree.mathur@linux.ibm.com \
    --cc=baoquan.he@linux.dev \
    --cc=chleroy@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=ritesh.list@gmail.com \
    --cc=rppt@kernel.org \
    --cc=ruanjinjie@huawei.com \
    --cc=sourabhjain@linux.ibm.com \
    --cc=sshegde@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®