mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Samuel Tirwa <samuel.tirwa@web.de>
To: Lee Jones <lee@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	Samuel Tirwa <samuel.tirwa@web.de>
Subject: [PATCH 1/2] mfd: intel-lpss: fall back to polling when no usable IRQ
Date: Tue,  3 Nov 2026 09:59:53 +0100	[thread overview]
Message-ID: <20261103085954.1497-1-samuel.tirwa@web.de> (raw)

On platforms such as the HONOR MagicBook Pro 14 (2025) (Intel Core Ultra 9 285H)
the firmware ACPI tables report the Intel LPSS I2C controllers' PCI INTx line as
not connected (Interrupt Line = 0xff, GSI 255) and do not grant MSI control
through _OSC.  As a result acpi_pci_irq_enable() sets dev->irq to
IRQ_NOTCONNECTED and intel_lpss_probe() rejects it, so all three I2C
controllers (8086:7778/7779/777a) fail to probe with -ENOTCONN and the
touchpad/touchscreen are never exposed.

Treat IRQ_NOTCONNECTED as 'no interrupt available' and pass 0 as the IRQ base
to the child devices instead of failing.  The DesignWare I2C driver already
supports a polling mode when no IRQ resource is present, which keeps the
controllers functional on these firmwares.

Signed-off-by: Samuel Tirwa <samuel.tirwa@web.de>
---
 drivers/mfd/intel-lpss.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c
index f71e076..f785d5d 100644
--- a/drivers/mfd/intel-lpss.c
+++ b/drivers/mfd/intel-lpss.c
@@ -1,5 +1,6 @@
 #include <linux/mfd/core.h>
 #include <linux/module.h>
+#include <linux/interrupt.h>
 
 int intel_lpss_probe(struct device *dev,
                      const struct intel_lpss_platform_info *info)
@@ -7,10 +8,17 @@ int intel_lpss_probe(struct device *dev,
 	struct intel_lpss *lpss;
 	int ret;
 
-	if (!info || !info->mem || info->irq <= 0)
+	if (!info || !info->mem)
 		return -EINVAL;
 
-	if (info->irq < 0)
+	/*
+	 * Firmware on some platforms (e.g. HONOR MagicBook Pro 14 2025)
+	 * reports the LPSS PCI INTx line as not connected (IRQ_NOTCONNECTED).
+	 * Fall back to polling mode in that case instead of failing probe.
+	 */
+	if (info->irq == IRQ_NOTCONNECTED)
+		info->irq = 0;
+	else if (info->irq < 0)
 		return info->irq;
 
 	lpss = devm_kzalloc(dev, sizeof(*lpss), GFP_KERNEL);
-- 
2.56.0.windows.4


             reply	other threads:[~2026-11-03  9:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03  8:59 Samuel Tirwa [this message]
2026-11-03  8:59 ` [PATCH 2/2] i2c: designware: use polling when IRQ resource is 0 Samuel Tirwa
  -- strict thread matches above, loose matches on Subject: below --
2026-11-03  8:57 [PATCH 1/2] mfd: intel-lpss: fall back to polling when no usable IRQ Samuel Tirwa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261103085954.1497-1-samuel.tirwa@web.de \
    --to=samuel.tirwa@web.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=lee@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®