From: Wentao Liang <vulab@iscas.ac.cn>
To: Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Wentao Liang <vulab@iscas.ac.cn>,
stable@vger.kernel.org
Subject: [PATCH] net: dsa: microchip: drop the parent MDIO bus reference
Date: Tue, 3 Nov 2026 10:05:31 +0000 [thread overview]
Message-ID: <20261103100531.1309946-1-vulab@iscas.ac.cn> (raw)
ksz_mdio_register() obtains the parent MDIO bus with of_mdio_find_bus(),
which takes a reference on the embedded struct device, and stores it in
dev->parent_mdio_bus for the side MDIO accessors. Nothing ever drops
that reference, so it is leaked on the probe error paths and when the
switch device is torn down.
Register a devres action to put the device when the DSA switch device
is released. The child MDIO bus is unregistered before the action
runs, so the parent bus stays valid for the whole lifetime of the
switch.
Fixes: 9afaf0eec2ab ("net: dsa: microchip: Refactor MDIO handling for side MDIO access")
Cc: stable@vger.kernel.org
Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
drivers/net/dsa/microchip/ksz_common.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
index 767c8fe8e819..ddd821fa0d3e 100644
--- a/drivers/net/dsa/microchip/ksz_common.c
+++ b/drivers/net/dsa/microchip/ksz_common.c
@@ -2392,6 +2392,17 @@ int ksz_parse_dt_phy_config(struct ksz_device *dev, struct mii_bus *bus,
return 0;
}
+/**
+ * ksz_mdio_put_parent_bus - Drop the reference on a parent MDIO bus
+ * @data: mii_bus obtained from of_mdio_find_bus()
+ */
+static void ksz_mdio_put_parent_bus(void *data)
+{
+ struct mii_bus *bus = data;
+
+ put_device(&bus->dev);
+}
+
/**
* ksz_mdio_register - Register and configure the MDIO bus for the KSZ device.
* @dev: Pointer to the KSZ device structure.
@@ -2431,6 +2442,12 @@ int ksz_mdio_register(struct ksz_device *dev)
goto put_mdio_node;
}
+ ret = devm_add_action_or_reset(ds->dev,
+ ksz_mdio_put_parent_bus,
+ parent_bus);
+ if (ret)
+ goto put_mdio_node;
+
dev->parent_mdio_bus = parent_bus;
}
--
2.34.1
next reply other threads:[~2026-11-03 10:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 10:05 Wentao Liang [this message]
2026-11-03 10:10 ` netdev-bot+sinfo
2026-11-03 10:25 ` Krzysztof Kozlowski
2026-11-05 22:29 ` Jakub Kicinski
2026-11-07 11:47 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103100531.1309946-1-vulab@iscas.ac.cn \
--to=vulab@iscas.ac.cn \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®