From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=109.224.244.121 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793708031; b=nbKDBm/1pXUmBjUbeMw8Jyp3DPbWgdZ2piH/LQeaG9Lx2MFnRL0WPP2KbYj/gv85pxKS BWcVstjDjBOr4v7BeyXL1Cn7lZWOC7+jI3jW9IRM4JK48hVIwpXaxaS5mzXMqqVngblh5 9rcD8V+xfKxSA7petBn+pn25dt3X333Em+g0ShqlhUJnXIg4E9bCBtgOlND2Rr1JgAKS/ WAwDiCMB/d8kNIAwOlaq4p4H3VpmI6rq+8072TgX/J+loF5Kagjy11h106NmOFRs6kfj6 AMRZDEfCjMCPNraK1ue1vn4wITWgAZg0OKEx7nFHAvEqX1DJ4tWY9Ht7nJYdvzI/0FQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793708031; h=DMARC-Filter:DKIM-Signature:Date:To:From:Cc:Subject:Message-ID: In-Reply-To:References:Feedback-ID:X-Pm-Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding; bh=n/UFdXyrAd5gl0Qey0z6/JDNLQSoV4VYRc31LKxfmJI=; b=cZ9JjyRanUplk98fIPNvl1HwSEWDEUMUhcgJUD9rhvtfDVLvSExPwdCdLZgWJlQZ3KUn XALPaRYBAHp1t6/GIJYWGjp5OX4ne797UfMVEo0rnLZnvomyRYMurLGjPp99tg3OQ8uav ePSqLtZCr5nhfmfiXA2MAMC7geBARjxtg0rCFySJtLPIOhZhfEy3E7BbgGTWpV0ZPNqbL UUSeNxHpR1G/UVwOTsCPgc7pBlq8BZHFmMtxsoBAFRPvhW95Ww9aXMld/O7JFlIb1+k/b j4IzZnLAdBfYUdlN2/JVJR8arLdcWgLmUO+pKVptHbFYVsJghaUvT2jITl25lRl0zqw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=pm.me; spf=pass smtp.mailfrom=pm.me; dkim=pass header.d=pm.me header.i=@pm.me header.a=rsa-sha256 header.s=protonmail3 header.b=pzM0ga06; arc=none smtp.remote-ip=109.224.244.121 Received: from mail-244121.protonmail.ch (mail-244121.protonmail.ch [109.224.244.121]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF198606A329 for ; Tue, 3 Nov 2026 12:13:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org BF198606A329 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=pm.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pm.me Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=pm.me header.i=@pm.me header.a=rsa-sha256 header.s=protonmail3 header.b=pzM0ga06 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail3; t=1793708028; x=1793967228; bh=n/UFdXyrAd5gl0Qey0z6/JDNLQSoV4VYRc31LKxfmJI=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=pzM0ga06AYTCAwJWKDaysdEveVmzUFBxb3BpYxFhCjIRG+ADe+YrIjkxypiOBI67h q8XP+itWyT7thYOOr+fNusL6sdeXMKzSuOBPfUS/ETMVJtpdD5DWs0qX6ECIdnovat 0SVzO8n8JdwKBCbciLqNIyUYVpIa5tc+Q3KFzM6TsAuCvF4mOVkZrpwxIJSIacHi4L ta5BPVA90KGECgiXl30SsBbS65VJa3+PQlDZR8P69IvYny3ITVjUdSz6y7LHUw+Pe2 iMkhFkPz7Dgs7fqwx4Ar7euxS0HINkWNU3HdZLwHq6iVrr7ncvgnmszIz7UgSTdZv8 zyxOOx4fVYEmA== Date: Tue, 03 Nov 2026 12:13:42 +0000 To: Sakari Ailus , Benjamin Mugnier , Sylvain Petinot , Mauro Carvalho Chehab From: Sergey Lebedev Cc: Dan Scally , Hans de Goede , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Marshall , George Neacsu , Hao Yao , Fernando Rimoli , "D. Manresa" , sashiko-bot@kernel.org, sashiko-reviews@lists.linux.dev, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] media: i2c: Add ST VD55G0 global shutter sensor driver Message-ID: <20261103121333.39898-1-lsa.uz@pm.me> In-Reply-To: <20261103103235.94397-3-lsa.uz@pm.me> References: <20261103103235.94397-1-lsa.uz@pm.me> <20261103103235.94397-3-lsa.uz@pm.me> Feedback-ID: 113843758:user:proton X-Pm-Message-ID: 45bb7be137328bb37ef3a7c1f693d445054ed23e X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sashiko's review of this patch [1] went to devicetree, not linux-media. All three points are right; v3 will fix them. Tested on the Surface Pro 11 with v2 and with the fix: 1. Auto exposure. Once a stream stops, the exposure and gains read back, and carry into manual mode, the values set before switching to auto, not the last applied ones. No runtime suspend is needed for this: pm_runtime_get_if_in_use() fails as soon as the stream's reference is dropped. Here the stream applied 1796/24/2048; after the stop the controls read 123/7/333, the manual values set before, and a manual stream then applied 123/7/333. v3 returns what the last stream applied, which the driver already keeps for the next cold start; the controls then read 1796/24/2048 and the manual stream applies that. So the v2 cover letter's "carry over to manual mode" held only while streaming. 2. Probe. The sensor was runtime suspended 22 ms after bind returned, not after the 1 s autosuspend delay. v3 takes a reference before pm_runtime_enable() and sets up autosuspend before registering, as vd55g1 does, and drops the reference once registered; the sensor then suspends 1.2 s after bind. The error path was not exercised. 3. RUNTIME_PM_OPS() and pm_ptr(): in v3. With CONFIG_PM=3Dn, vd55g0_pm_ops is then no longer in the object. With the fix, v4l2-compliance passes 46 of 46, with no KASAN or lockdep report. [1] https://lore.kernel.org/all/sashiko-outbox-195119@kernel.org/ Sergey