From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.210.172 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793713635; b=Xu76RLkSiAUWehW6YXbSaB0q++evIXHw7PUWCZkBUriOQWZJ/66rA8w3lJDTOxNT7AT3 CSqbVrzZ58dUURB4xtkQ6KDGu2ljJ/fSuYf3efD1tXARAprI0UnaJ0sE1oyQCzJ8220sm HH8xqIMJU0+bGPrVhA4fpl/7PpPnXjNuscZBLtZNfNqpGNf2ITySG6hYEn7AygKrryRgM 0NBCVQ0EiWHeqZpZtsOaN7cIBCjGB5aOw0a4jsoWwVeH+gKMR/yRMr+R7aIp4SxGtf57+ m3lV6wI5ltua49CGcJFW6n0yCRXvX+vJgrMU7ObGASGR3VNGcgVqWRZPZCj3EIn3nwA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793713635; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:MIME-Version: Content-Transfer-Encoding; bh=PKjWRUzPQ/AfOjwLbgBl9OKiNXSCa4wej4PtIGjwOlI=; b=lbn2cXs/dz8K90f7EEpcrkDYZTvxUrICpl7gI16R5P/UtD4Xb5SiRSRVfck8R1evVzdk gyvtZpgUwk9vl2MYSveCWR6usUXRv9699ALN+JI3n2VBQOEYasVpG1r4ENY9PSpqaqrNk MzQF+mJWL1qrr128V1atOfUA2/ZK83p4k4DWC+Fze1qxe8qIHOKxfDCXXjHT0RtFnDN3M lHVzQOk4IspDyJQZ9AALOp91e124gpK/mELAApF6vyRQo72rwY9gX70ac7Vm7ZdSrl1XH Pt5ziICbRC1TzUwCB+o0e4I0JJ1q6w/nfoN7lQyPXJ370m4GuGl0oExoOK/X+NBiouA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=D7PEmlY5; arc=none smtp.remote-ip=209.85.210.172 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7BC1606A32D for ; Tue, 3 Nov 2026 13:47:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org A7BC1606A32D Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=D7PEmlY5 Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-8a06b27bf9bso1462473b3a.2 for ; Tue, 03 Nov 2026 05:47:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793713634; x=1794318434; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=PKjWRUzPQ/AfOjwLbgBl9OKiNXSCa4wej4PtIGjwOlI=; b=D7PEmlY5k7wOC+F0nZP+WRt17y704Pn0Gj0t2m24022le2/m3TEQLsk3WgGjQxjKI5 AT4wap6DJldbXKNEUf5GVmxdM4mWLGPKYnAGFC82zB9WjLLv5UyiplLkms6nr8sxrqx2 1uAyQC040dRM9YZBOdE5cbeQjAB1erDJEwIuVueGuzNUYAWkuuwtoqN97L+Os4DMLsTW 5zoJH4IyxtfVMGH1eRJCkm4CZ4GhRKuhmdqnQEAVros6f2sqlbOJJ8OshwkMwoJsCRbL YvgjbCgIsIFaUfviUhHz+LU6q6G0iGYnxr/MX5PfHqegGgucXJgvevtWRzXJqFzMhdch 6OSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793713634; x=1794318434; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PKjWRUzPQ/AfOjwLbgBl9OKiNXSCa4wej4PtIGjwOlI=; b=wu/f3Gh3bmhvYPGDxTAsFohtVopOIhs2sVg6dB2slVck1cn5nu2Nadl7DskJkFnVtO 8h8zu6Y8TzqNsUF2AX+f22FVQ5h/VAueWy1Q6tGlPAodVMj+7SU97DGAJghol7qLDMje v+ZhT0tuDxZTF2tsetx2qv/+ADFjkgRYsqUWXl7TPMAFXQe/cf7MhK3zH1R1Ly6XfO4E BAihAcWvJHS2jOauaHqdtLW/4oUksKKi7H6QtRKMspbTUHtKk9nwK0ZkmAQwnEDPrS3W U/2NyxBorXEU59WWQcGgxZjRUzwMuUgCsx7glgcC+G4mgV0OLaRJeNU3KfTgRhIC4vcd a2Hw== X-Forwarded-Encrypted: i=1; AKwUvByKiJ/7VY9im3f+V3iyJACbrBEuh1LC6sWtjDkDp6UgRNUh+aYeq7EEiEPklxJQF/3MoCdD26+S0uWvDyc=@vger.kernel.org X-Gm-Message-State: APuU4Z8E4FU/d/CFV8Q4i8EPXr/VCUF2d9hN0u/NOpHwsuNPeKGlR5Kg dg7eGWT9sc6lCyjmIa1/o4lvuBKNn5n2R7m0LABKwDL1TuxIVZiQdD3v X-Gm-Gg: AYBFou0ZByrMz5UNEVlFo/CXsTZGHBoHvl6y0Jyfvvrb/MjNMv66Y1KyAKrHCPae9Ve ExW0SYQnc/8Sm9RoOqW2qgOfED7gxTn73iN2Ycrr6vVql/65zy+/ivHEbq4pt2iy/A7MjIA0pDT VDnZpDtjUINNPUswFp2b8+mOUWsn70MZfO0UZo8iL513G9oZn3gOzRfZX4Pn08e2hrExdi5cSdZ Gbc67vAbaRQQ9c4QPZJZNuyLGXCYvVrDMyXbXuAu7erPRiRoL2FKQ7SnzS12TswKoSjgbAmrD1g NN92bwUHtBuXRFo+OFE0IifSnSys9S/hj21Xo8+gKmg4e+ayREL8JgaUL+ks30DswNBuLsBOKvZ Dfk0r7LD1GsD7WpsxNyi+qPmBUp/h7rTz6HI+pqudxWQyP6GyZiME3UW9y1vTfb6L9b2AbZ5PpP IW2BfuqaPJGtxK9C9DXvKm9WNEt+9+mYsQ9vErESPYQOHJwu3AygDMQ2gipu+XMc7hoC2IIEoeG ZPs6vFg4VnIyNF4VNqJzDdyHByJtEQPzqzsnjMS/DSNny5WGmGnLqwpHkHZJbFUQQqvp8dlhFiw pK8Y0257f0ynCozYJCMzEN6x9qgy9IzKR5Fo8lmydp+Ochbt4zRy X-Received: by 2002:a05:6a00:2da5:b0:89f:172b:3b88 with SMTP id d2e1a72fcca58-8a9bfaf8c30mr10114132b3a.47.1793713633720; Tue, 03 Nov 2026 05:47:13 -0800 (PST) Received: from d.home.yangfl.dn42 ([2a09:bac1:7680:28::4:396]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8aad7707ed0sm3436124b3a.4.2026.11.03.05.47.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 05:47:13 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Subject: [PATCH net v2] net: dsa: motorcomm: Publish a consistent MIB sample Date: Tue, 3 Nov 2026 21:47:03 +0800 Message-ID: <20261103134705.867613-1-mmyangfl@gmail.com> X-Mailer: git-send-email 2.53.0 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit get_stats64() derived rx_bytes and tx_bytes by subtracting ETH_FCS_LEN per packet from the published byte counters, but u64_stats_sync gives neither ordering nor retry across a multi-field read on 64-bit kernels, and a failed register read published a partially refreshed buffer as well. A fresh packet count could then pair with a stale byte counter, and the subtraction underflowed on unsigned arithmetic, reporting rx_bytes or tx_bytes as about 2^64. Do the arithmetic in the writer, on the complete sample collected under priv->reg_lock, and publish the adjusted byte counters next to the frame totals, so that get_stats64() only copies published values. On a failed register read, keep the last complete sample. Found by LLM. The issue is transient and abnormal values will be flushed by the next function call. Fixes: 186623f4aa72 ("net: dsa: yt921x: Add support for Motorcomm YT921x") Signed-off-by: David Yang --- v2: - more issues found by sashiko v1: https://lore.kernel.org/r/20261102101334.3525485-1-mmyangfl@gmail.com drivers/net/dsa/motorcomm/mib.c | 23 +++++++++++++++-------- drivers/net/dsa/motorcomm/mib.h | 2 ++ 2 files changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/net/dsa/motorcomm/mib.c b/drivers/net/dsa/motorcomm/mib.c index 6b170fc6e187..d47aafc468a3 100644 --- a/drivers/net/dsa/motorcomm/mib.c +++ b/drivers/net/dsa/motorcomm/mib.c @@ -95,6 +95,8 @@ static int yt921x_mib_read(struct yt921x_priv *priv, int port) unsigned long flags; u64 rx_frames; u64 tx_frames; + u64 rx_bytes; + u64 tx_bytes; int res = 0; mib = &pm->stats; @@ -127,6 +129,12 @@ static int yt921x_mib_read(struct yt921x_priv *priv, int port) buf[i] = val; } + if (res) { + dev_err(dev, "Failed to %s port %d: %i\n", "read stats for", + port, res); + return res; + } + flags = u64_stats_update_begin_irqsave(&pm->syncp); for (size_t i = 0; i < ARRAY_SIZE(yt921x_mib_descs); i++) u64_stats_set(&((u64_stats_t *)mib)[i], buf[i]); @@ -144,14 +152,15 @@ static int yt921x_mib_read(struct yt921x_priv *priv, int port) u64_stats_read(&mib->tx_512_1023byte) + u64_stats_read(&mib->tx_1024_1518byte) + u64_stats_read(&mib->tx_jumbo); + rx_bytes = u64_stats_read(&mib->rx_good_bytes) - ETH_FCS_LEN * rx_frames; + tx_bytes = u64_stats_read(&mib->tx_good_bytes) - ETH_FCS_LEN * tx_frames; u64_stats_set(&pm->rx_frames, rx_frames); u64_stats_set(&pm->tx_frames, tx_frames); + u64_stats_set(&pm->rx_bytes, rx_bytes); + u64_stats_set(&pm->tx_bytes, tx_bytes); u64_stats_update_end_irqrestore(&pm->syncp, flags); - if (res) - dev_err(dev, "Failed to %s port %d: %i\n", "read stats for", - port, res); - return res; + return 0; } void yt921x_mib_poll(struct work_struct *work) @@ -391,10 +400,8 @@ yt921x_dsa_get_stats64(struct dsa_switch *ds, int port, stats->rx_packets = u64_stats_read(&pm->rx_frames); stats->tx_packets = u64_stats_read(&pm->tx_frames); - stats->rx_bytes = u64_stats_read(&mib->rx_good_bytes) - - ETH_FCS_LEN * stats->rx_packets; - stats->tx_bytes = u64_stats_read(&mib->tx_good_bytes) - - ETH_FCS_LEN * stats->tx_packets; + stats->rx_bytes = u64_stats_read(&pm->rx_bytes); + stats->tx_bytes = u64_stats_read(&pm->tx_bytes); stats->rx_dropped = u64_stats_read(&mib->rx_dropped); /* stats->tx_dropped */ stats->multicast = u64_stats_read(&mib->rx_multicast); diff --git a/drivers/net/dsa/motorcomm/mib.h b/drivers/net/dsa/motorcomm/mib.h index 9c24a52d46cc..2e2b832cb245 100644 --- a/drivers/net/dsa/motorcomm/mib.h +++ b/drivers/net/dsa/motorcomm/mib.h @@ -136,6 +136,8 @@ struct yt921x_mib { struct yt921x_mib_stats stats; u64_stats_t rx_frames; u64_stats_t tx_frames; + u64_stats_t rx_bytes; + u64_stats_t tx_bytes; /* protected by priv->reg_lock */ u64 data[YT921X_MIB_STAT_NUM]; }; -- 2.53.0