mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: Andreas Hindborg <a.hindborg@kernel.org>,
	Shuah Khan <shuah@kernel.org>,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] selftests/configfs: fix the build on 32-bit architectures
Date: Tue,  3 Nov 2026 09:16:27 -0500	[thread overview]
Message-ID: <20261103141627.30838-1-sashal@kernel.org> (raw)

The fixture setup checks the result of mkdtemp() with ASSERT_NE(), which
hands the pointer to the harness. The harness casts both operands to
intmax_t to print them, and on 32-bit architectures gcc warns about the
cast from a pointer to an integer of a different size. The configfs
test builds with -Werror, so it fails to build there:

  kselftest_harness.h:797:49: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]

Compare the result against NULL inside ASSERT_TRUE(), so that the
harness only sees an int.

Fixes: a7fdcb2edd0f ("selftests/configfs: add tests for the userspace interface")
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
KernelCI's 32-bit arm kselftest builds fail on this. Built
configfs_test.c with gcc 16 -m32, with and without _TIME_BITS=64 (fails
before, builds after), clang 21 -m32, and both compilers for x86_64.

The harness cast warns for every pointer comparison on 32-bit, a few
thousand warnings in one KernelCI arm build, and configfs only breaks
because of its -Werror. Making the harness print pointers through
uintptr_t would be a separate change.

 tools/testing/selftests/filesystems/configfs/configfs_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/filesystems/configfs/configfs_test.c b/tools/testing/selftests/filesystems/configfs/configfs_test.c
index c6a1049e5852e..94ae8f7103092 100644
--- a/tools/testing/selftests/filesystems/configfs/configfs_test.c
+++ b/tools/testing/selftests/filesystems/configfs/configfs_test.c
@@ -122,7 +122,7 @@ FIXTURE_SETUP(configfs)
 	ASSERT_EQ(unshare(CLONE_NEWNS), 0);
 	ASSERT_EQ(mount(NULL, "/", NULL, MS_REC | MS_PRIVATE, NULL), 0);
 
-	ASSERT_NE(mkdtemp(tmpl), NULL);
+	ASSERT_TRUE(mkdtemp(tmpl) != NULL);
 	strcpy(self->mnt, tmpl);
 
 	ASSERT_EQ(mount("configfs", self->mnt, "configfs", 0, NULL), 0);
-- 
2.53.0


             reply	other threads:[~2026-11-03 14:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03 14:16 Sasha Levin [this message]
2026-11-03 17:18 ` Breno Leitao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261103141627.30838-1-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®