mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ian Bridges <icb@fastmail.org>
To: linkinjeon@kernel.org
Cc: senozhatsky@chromium.org, tom@talpey.com,
	chenxiaosong@chenxiaosong.com, linux-cifs@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Aamir Ahmed <elb12345@hotmail.co.uk>,
	stable@vger.kernel.org, Ian Bridges <icb@fastmail.org>
Subject: Re: [PATCH v2] ksmbd: grant a caller what its groups and OWNER RIGHTS ACEs allow
Date: Tue,  3 Nov 2026 08:54:19 -0600	[thread overview]
Message-ID: <20261103145419.10809-1-icb@fastmail.org> (raw)
In-Reply-To: <CAKYAXd-s-g2V4LNY8e5SsH=+0r3qLY+AeOa5Lp9K0T5p_tnA8A@mail.gmail.com>

Hi Namjae,

You're right. For MAXIMUM_ALLOWED, v2 skips deny ACEs for the caller's
groups along with their allow ACEs. An owner named only by an OWNER
RIGHTS ACE then gets the rights of that ACE, write included, even when
a deny ACE for one of its groups comes first. A probe confirms your
example.

I'll send a v3 that processes those deny ACEs when this patch decides
the MAXIMUM_ALLOWED answer. Where the existing lookup decides, group
ACEs stay ignored for every request, as before this patch.

Thanks,
Ian

      reply	other threads:[~2026-11-03 14:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02 20:03 Ian Bridges
2026-11-02 23:41 ` Namjae Jeon
2026-11-03 14:54   ` Ian Bridges [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261103145419.10809-1-icb@fastmail.org \
    --to=icb@fastmail.org \
    --cc=chenxiaosong@chenxiaosong.com \
    --cc=elb12345@hotmail.co.uk \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=senozhatsky@chromium.org \
    --cc=stable@vger.kernel.org \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®