From: Luigi Rizzo <lrizzo@google.com>
To: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org, Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Luigi Rizzo <rizzo.unipi@gmail.com>,
Brian Vazquez <brianvv@google.com>,
Joshua Hay <joshua.a.hay@intel.com>,
Larysa Zaremba <larysa.zaremba@intel.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org, Luigi Rizzo <lrizzo@google.com>
Subject: [PATCH iwl-next v3 0/2] libeth, idpf: use GFP_KERNEL for the initial Rx ring fill
Date: Tue, 3 Nov 2026 16:23:23 +0000 [thread overview]
Message-ID: <20261103162326.3615979-1-lrizzo@google.com> (raw)
libeth_rx_alloc() always allocates with GFP_ATOMIC, including when a
driver fills its Rx rings at open or on queue reconfiguration. That
fill runs in process context, right after page_pool_create() and before
the queues' NAPI is enabled, so it may sleep, and GFP_ATOMIC is
needlessly restrictive there: it can neither reclaim nor compact, while
the initial fill can allocate tens of thousands of buffers across all
queues.
Patch 1 adds __libeth_rx_alloc() taking a gfp_t parameter and turns
libeth_rx_alloc() into its GFP_ATOMIC wrapper.
Patch 2 switches idpf's initial Rx ring fill (both splitq and singleq)
to GFP_KERNEL.
v3:
- rename libeth_rx_alloc_gfp() to __libeth_rx_alloc() and put the gfp
argument on its own line in page_pool_alloc_netmem() (Alexander Lobakin)
v2: https://lore.kernel.org/r/20261019210604.2433620-1-lrizzo@google.com/
- split into two patches (libeth helper and idpf consumer)
v1: https://lore.kernel.org/r/20261016151835.2500807-1-lrizzo@google.com/
Luigi Rizzo (2):
libeth: add __libeth_rx_alloc() to specify allocation flags
idpf: use GFP_KERNEL for the initial Rx ring fill
.../ethernet/intel/idpf/idpf_singleq_txrx.c | 7 +++---
drivers/net/ethernet/intel/idpf/idpf_txrx.c | 9 ++++---
drivers/net/ethernet/intel/idpf/idpf_txrx.h | 2 +-
include/net/libeth/rx.h | 24 +++++++++++++++----
4 files changed, 31 insertions(+), 11 deletions(-)
--
2.56.0.385.gac671c819a-goog
next reply other threads:[~2026-11-03 16:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 16:23 Luigi Rizzo [this message]
2026-11-03 16:23 ` [PATCH iwl-next v3 1/2] libeth: add __libeth_rx_alloc() to specify allocation flags Luigi Rizzo
2026-11-03 16:23 ` [PATCH iwl-next v3 2/2] idpf: use GFP_KERNEL for the initial Rx ring fill Luigi Rizzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103162326.3615979-1-lrizzo@google.com \
--to=lrizzo@google.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=brianvv@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=joshua.a.hay@intel.com \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rizzo.unipi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®