From: Steven Rostedt <rostedt@goodmis.org>
To: Li Pengfei <ljdlns1987@gmail.com>
Cc: mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
mark.rutland@arm.com, corbet@lwn.net, skhan@linuxfoundation.org,
lkp@intel.com, linux-trace-kernel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kselftest@vger.kernel.org, zhangbo56@xiaomi.com,
lipengfei28@xiaomi.com
Subject: Re: [RFC PATCH v7 03/10] trace: add stackmap statistics interface
Date: Tue, 3 Nov 2026 19:36:02 -0500 [thread overview]
Message-ID: <20261103193602.563c52ce@gandalf.local.home> (raw)
In-Reply-To: <20260912083753.3426176-4-lipengfei28@xiaomi.com>
On Sat, 12 Sep 2026 16:37:46 +0800
Li Pengfei <ljdlns1987@gmail.com> wrote:
> @@ -9411,6 +9411,18 @@ static __init void tracer_init_tracefs_work_func(struct work_struct *work)
> */
> smp_store_release(&global_trace.stackmap, smap);
> WRITE_ONCE(stackmap_init_state, STACKMAP_INIT_DONE);
> + /*
> + * stat is an auxiliary observability
> + * surface. If it fails to be created we keep
> + * dedup enabled -- the kernel side still
> + * works and stack_map alone is enough to
> + * resolve and reset; trace_create_file()
> + * already pr_warn()s on failure.
> + */
The above comment is useless. Get rid of it.
-- Steve
> + trace_create_file("stack_map_stat",
> + TRACE_MODE_READ, NULL,
> + smap,
> + &ftrace_stackmap_stat_fops);
> }
> } else {
> pr_warn("ftrace stackmap init failed, dedup disabled\n");
next prev parent reply other threads:[~2026-11-04 0:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-12 8:37 [RFC PATCH v7 00/10] trace: stack trace deduplication for ftrace ring buffer Li Pengfei
2026-09-12 8:37 ` [RFC PATCH v7 01/10] trace: add lock-free stackmap for stack trace deduplication Li Pengfei
2026-11-03 22:49 ` Steven Rostedt
2026-09-12 8:37 ` [RFC PATCH v7 02/10] trace: use the stackmap from the ftrace stack recording path Li Pengfei
2026-11-04 0:34 ` Steven Rostedt
2026-09-12 8:37 ` [RFC PATCH v7 03/10] trace: add stackmap statistics interface Li Pengfei
2026-11-04 0:36 ` Steven Rostedt [this message]
2026-09-12 8:37 ` [RFC PATCH v7 04/10] trace: add stackmap binary export Li Pengfei
2026-09-12 8:37 ` [RFC PATCH v7 05/10] trace: make the stackmap capacity settable on the kernel command line Li Pengfei
[not found] ` <20260912085841.48E7B1F00893@smtp.kernel.org>
2026-09-14 6:08 ` Li Pengfei
2026-09-12 8:37 ` [RFC PATCH v7 06/10] Documentation: tracing: document the ftrace stackmap Li Pengfei
2026-09-12 8:37 ` [RFC PATCH v7 07/10] tools/tracing: add a parser for the stackmap binary export Li Pengfei
2026-09-12 8:37 ` [RFC PATCH v7 08/10] selftests/ftrace: add a stackmap basic functionality test Li Pengfei
[not found] ` <20260912090213.C77861F00893@smtp.kernel.org>
2026-09-14 6:08 ` Li Pengfei
2026-09-12 8:37 ` [RFC PATCH v7 09/10] selftests/ftrace: add a stackmap reset and binary ABI test Li Pengfei
2026-09-12 8:37 ` [RFC PATCH v7 10/10] selftests/ftrace: add a stackmap instance gating test Li Pengfei
2026-10-13 2:03 ` [RFC PATCH v7 00/10] trace: stack trace deduplication for ftrace ring buffer Li Pengfei
2026-11-04 0:44 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103193602.563c52ce@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lipengfei28@xiaomi.com \
--cc=ljdlns1987@gmail.com \
--cc=lkp@intel.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=zhangbo56@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®