From: Renze Nicolai <renze@rnplus.nl>
To: Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>
Cc: Renze Nicolai <renze@rnplus.nl>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/4] ARM: dts: aspeed: x570d4u: Fix fan tach channel assignments
Date: Tue, 3 Nov 2026 21:33:03 +0100 [thread overview]
Message-ID: <20261103203308.54789-3-renze@rnplus.nl> (raw)
In-Reply-To: <20261103203308.54789-1-renze@rnplus.nl>
The tachometer channel numbers for FAN4, FAN5 and FAN6 did not match
the board's actual PWM wiring, causing incorrect fan speed readings.
FAN6 is wired to PWM5 and FAN5 is wired to PWM6 (not PWM6/PWM5
respectively as previously assigned), and FAN4's tach channel was
off by one.
Signed-off-by: Renze Nicolai <renze@rnplus.nl>
---
arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts
index 7d27833b761d..6e7e3e7ec101 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts
@@ -320,19 +320,19 @@ fan@2 {
fan@3 {
/* FAN4 (6-pin) */
reg = <0x03>;
- aspeed,fan-tach-ch = /bits/ 8 <0x04 0x0b>;
+ aspeed,fan-tach-ch = /bits/ 8 <0x03 0x0b>;
};
fan@4 {
- /* FAN6 (6-pin) */
+ /* FAN6 (6-pin), wired to PWM5 */
reg = <0x04>;
- aspeed,fan-tach-ch = /bits/ 8 <0x06 0x0d>;
+ aspeed,fan-tach-ch = /bits/ 8 <0x05 0x0d>;
};
fan@5 {
- /* FAN5 (6-pin) */
+ /* FAN5 (6-pin), wired to PWM6 */
reg = <0x05>;
- aspeed,fan-tach-ch = /bits/ 8 <0x05 0x0c>;
+ aspeed,fan-tach-ch = /bits/ 8 <0x04 0x0c>;
};
};
--
2.56.0
next prev parent reply other threads:[~2026-11-03 20:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 20:33 [PATCH 0/4] ARM: dts: aspeed: x570d4u: devicetree fixes and cleanups Renze Nicolai
2026-11-03 20:33 ` [PATCH 1/4] ARM: dts: aspeed: x570d4u: Remove w83773g temperature sensor Renze Nicolai
2026-11-03 20:33 ` Renze Nicolai [this message]
2026-11-03 20:33 ` [PATCH 3/4] ARM: dts: aspeed: x570d4u: Give unique names to MAC address nvmem cells Renze Nicolai
2026-11-03 20:33 ` [PATCH 4/4] ARM: dts: aspeed: x570d4u: Add some GPIO line names Renze Nicolai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103203308.54789-3-renze@rnplus.nl \
--to=renze@rnplus.nl \
--cc=andrew@codeconstruct.com.au \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®