mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Akshay Ubale <akshay.ubale001@gmail.com>
To: netdev-bot+sinfo@kernel.org
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>, Breno Leitao <leitao@debian.org>,
	Kees Cook <kees@kernel.org>,
	Matheos Worku <matheos.worku@sun.com>,
	linux-kernel@vger.kernel.org,
	Akshay Ubale <akshay.ubale001@gmail.com>
Subject: Re: [PATCH net] niu: bounds-check phy-type and model VPD strings
Date: Tue,  3 Nov 2026 22:13:48 +0100	[thread overview]
Message-ID: <20261103211348.39521-1-akshay.ubale001@gmail.com> (raw)
In-Reply-To: <179253979539.3290.9924821446681218748@kernel.org>

Hi,

Answers to the questions about this patch:

- Discovery: manual code inspection. While reviewing unchecked strcpy()
  calls in the kernel, I found that niu_get_of_props() copies the
  "phy-type" and "model" device-tree properties into fixed-size buffers
  without checking their length. No syzbot report, production report,
  or static analysis tool was involved.

- Triggered: not triggered. This is theoretical, found by code
  inspection. No symptoms were observed. Triggering needs a property
  longer than the destination buffer, which I have not seen reported.

- Hardware: not tested on real hardware. The change was verified with a
  SPARC64 cross-build (gcc 13.3, W=1, no warnings) and a standalone test
  harness for the length-check logic.

Thanks,
Akshay Ubale

  reply	other threads:[~2026-11-03 21:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20 23:30 Akshay Ubale
2026-10-20 23:43 ` netdev-bot+sinfo
2026-11-03 21:13   ` Akshay Ubale [this message]
2026-10-21  1:10 ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261103211348.39521-1-akshay.ubale001@gmail.com \
    --to=akshay.ubale001@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=kees@kernel.org \
    --cc=kuba@kernel.org \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matheos.worku@sun.com \
    --cc=netdev-bot+sinfo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®