From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793742072; b=wiEqxLpZQc5xtATOmRpo+R0emKkw0DtX6F0CXaGAH1yDWE+ZmBgZbwbWhFhcRECDeePK Yf5gXlJ0nQhv7wIwKBJbBVTPbdl0Y3aPZQVmuRVBUTutN0Ocka5JYQC4f4BMGqNATw0bc boqkIvqIG5/3qAjoXlvigoxGBHK6k15aO2YAAioJsTdqUg44LsiNK3CnpUUY8W5YDAQxT u7GApLoPvBgiDriSmcBdIVDgXN2w+SlcFbxwsHEMtNzlog31aCon+S0P49Kus8RI0SYDU H3gEysFipQgjUh8njyf00G5ItKf8O8OXvCSQ+46rTZr58O+c9V3TWQadELfTmrbwMpw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793742072; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:From:To:Cc: Subject:Date:Message-Id:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding:X-Proofpoint-Spam-Details-Enc: X-Proofpoint-GUID:X-Authority-Analysis:X-Proofpoint-Spam-Info: X-Proofpoint-ORIG-GUID:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=mWF4Em/s+/j7aCjLGWQL65SgDN+9hBOaJk8SJTBvAJo=; b=eOGRTG00b2yzP7vbAgSu0/HrmJKTFPGrD2a3gkuiwSC16n2rdj9wIoIo0N4dgA95ZfcP rIJEMCJ3BVhJkbSCzZE3hqeRFfiPIQ5lpnVFyi1S9+0BscP8I/kA6tXMI/sqlUIu3apc7 5bWfDxouPRPhKl1iUW4AruxfHbFcucPqUvjGFEJy+d2tFInT4njNCgcMAihGDnRCsJRin GS/ceGWmYb1GDHMZOrFiX07L0mnQcwarlh6Ylfxx/+YON6a/d4Ho+Et6IZrnNgFoBJN2S M69SbWci++GGNwtlZiUsXui+ZVeJ0PlEn7T06fFiIuzIu7OsTAUTQC0N939tGpYFLVA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=f3UbJzwY; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=i3aOJONr; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62FB1606D81F for ; Tue, 3 Nov 2026 21:41:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 62FB1606D81F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=f3UbJzwY; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=i3aOJONr Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6A3LKor6415160 for ; Tue, 3 Nov 2026 21:41:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=mWF4Em/s+/j 7aCjLGWQL65SgDN+9hBOaJk8SJTBvAJo=; b=f3UbJzwYsZb59Z5cK8xXeu3TMXJ 7qaeeZGm0cuCdqGGn6Spdu6UEw0IiqLMZ6n1lQkXit13pIEol/9A6dyawmJMmzN6 bd7aayDEYF31v5AvAfKHRXfq33qR8coZ8HSClQVR7mZkXseXdiI3Vpr2I7EdDz32 RMWPdNbHFO7jqmJQkCTmG83D/rMiJ+BBRmyc/IiG26iK6MakxWmfW4iGDoadVumV fwn9RWVCXJkJgVEw54vKaTRyLco6eImGqzRbDHmjreCCU9qttw+4atEZCPsp2KO6 ruNF0YUAFhHM3oQpMnrmpSkdHifvTi02DTDLKGxj8XEyDSeaMhE6Hkp4cPg== Received: from mail-dy1-f199.google.com (mail-dy1-f199.google.com [74.125.82.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hqkgp96tg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 03 Nov 2026 21:41:11 +0000 (GMT) Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-3662e7a9299so18056037eec.1 for ; Tue, 03 Nov 2026 13:41:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793742070; x=1794346870; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mWF4Em/s+/j7aCjLGWQL65SgDN+9hBOaJk8SJTBvAJo=; b=i3aOJONrhWI9HBJfDx1fX+eh6SO4lDhqQ+U0KDkip6m8ZaZSs73RCLNS5h9A34rMad sEFpzrgVZm61HJNgX8SuEnuZOJO7kAtrKXPD85liXhHOTsoopVqQoA5/Mp8QYtg6M4xu et/yFlLq4vys7BPMjRgqiBVqM0gc2xyrZN0/RiaVZR/anCMmg1l1vQOtDOpg93iU3ydJ 3wwOKMCN3knKxqMRnJps5epgM3jLi2YZRLHi6Du8yXLgx7LHzu45dZ/Q76zohhAZKUV0 2ZtVeQg8M9bNvR9/s9LXN2IsEJfvKP64i8hWAwbiaw0YOnBcS9aORALlvOLfBX4h+QA5 l37Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793742070; x=1794346870; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=mWF4Em/s+/j7aCjLGWQL65SgDN+9hBOaJk8SJTBvAJo=; b=hyBBX60RyBeBraKyad54gF7+RNtNaEEpb4zyIz/r6J2EGb5hT7dJhFsZEAoa2bq9a4 k7gHmXUX/2Ya9TbpVIKB9ps6jtnbZsPILIUvHckvIOHwbgyAOGdof016OrwypJBxs97K IVrghdX0DOHu8N9d7hQV4HgLlRMWr6+FoSqaYHW+J9mKKfSzcB7lxtgdNp4m0WXCoDx+ 9nZBTe6Q9Z0jGuHxJzzegi5f7MIguz2qmOmaCsaDPel2AFRuaobaM3PcfhpJ2s5zRXSa GsUAKDD5CXCb/PBQ/TrHGMUNX5DGIu8uQgtcTBnZ4l4BgQGbE0XTfspvw/XbYpbjklNE XO/w== X-Forwarded-Encrypted: i=1; AKwUvByXgNcwjCwd2OBDw91LT3EuEXzJOKt9VTb2IMQBT/GgeLcCDqkwlePaEgal7Y8fRA59tZHiRGR33KFnM/E=@vger.kernel.org X-Gm-Message-State: APuU4Z/ftM5L5SqK/5eymDoVeuTRzp9HY5KN9C2UxvKzbDwcnZOnTxW9 WqgKnLAe7ULrsUyckuDwdcb8x0tZk+lNV81ZYl68ycx1TIajHb7QWyGS/uJKRuNu9Mlj7HDBvcb TR8s0OR06C8VWZlfZabTPu+tRvCfz5FQRXjZGPrwM4ZQJUwC8liKI38y3xyioKSpOdQg= X-Gm-Gg: AYBFou2/JAUqk02iohOzfM2MWtP4XMII0pe6D7HaYrRPIW61lZ34chhEI4MEqwLJNtP MejRmtF9TrLXdaUpNc/X172hn1AEBTFKso7I6bX8JyCBdcBCDK/v19cK1s+oXSkxitD2CBGEDzP mlFykRZ1GQWjQqrDW6+IuKL6GWevBcmimpm+gEZwQ66XVl0u4hD029NuzD3JbmdJTAIcsvFQuGX uAAlaZxHHZ8GHZO5O7vBhhmvWrTf3v5FrChgaHe+JjekOYzlzICvT8NFZEhqOUwepphdVW8t0Yb WEbZ/BlVJ3JlwPCeB7+AOiGrP1uIGiINjzM1V3mRlvFydNQXtxDN7dm9W+IAXD6UPKSLkoX0XSw eKs1P/4hWILaWOuhNbiLhcVi8ujXDJFM41ZgDxYIFz5hnzAjzmbYGpn5qTnWVuRG3SHYbavmOPQ KUiOQOHFjKAYikFmcvOn0+rj5y2m0= X-Received: by 2002:a05:701b:4188:10b0:166:b307:5855 with SMTP id a92af1059eb24-1ac4f91fceemr22434984c88.0.1793742070226; Tue, 03 Nov 2026 13:41:10 -0800 (PST) X-Received: by 2002:a05:701b:4188:10b0:166:b307:5855 with SMTP id a92af1059eb24-1ac4f91fceemr22434945c88.0.1793742069598; Tue, 03 Nov 2026 13:41:09 -0800 (PST) Received: from hu-aarunnan-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1b245c1c272sm1537440c88.8.2026.11.03.13.41.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 13:41:09 -0800 (PST) From: Anusha Arun Nandi To: Bryan O'Donoghue Cc: Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , gjorgji.rosikopulos@oss.qualcomm.com, hariram.purushothaman@oss.qualcomm.com, akapatra@quicinc.com, jigarkumar.zala@oss.qualcomm.com, linux-phy@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/5] phy: qcom-mipi-csi2: Make OPP table optional Date: Tue, 3 Nov 2026 13:41:03 -0800 Message-Id: <20261103214105.3605181-4-anusha.nandi@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20261103214105.3605181-1-anusha.nandi@oss.qualcomm.com> References: <20261103214105.3605181-1-anusha.nandi@oss.qualcomm.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTAzMDA4NiBTYWx0ZWRfX8r4jk7Jmzp5O QSqNJssmgBODumz8GOR0Y+jwRZPzwgc9XPI/pIoK+1lbLXn1xV8QMZd8/NnOC0fAiOr1YIyMOpo sAEdTLzqEaPw4kT0RrifjOdMzed/77GBAPt6UoFljVjy2rGNuY4yV5l5Mmwci6GB4728jGT5zeq EZXwctxv8nIC3/jONutYLVtE+1uWjmsD0b2vzJURlh24Vafu8v3GkPnKAHt/zLtqTqKmrhy1Ufx bXOUoj9rPRUbcLB32kxXa+T2yeytodXrqz5l+v3H2T30YAYrbTGStuzds/sC9YNqcuqV9aQQ1iV H1Uc8MPd3l5KWhsD4i3JMFLCw1Rf2FAcZzfzjGiv/JsqJ2OR84GXefsvk70RpsGA1Ok6gBhgICl 89TQFFjKaQXaUmitsBJ0bvJRt7r/lUlQtzKcBNoW52gLngRKvJYXadclLCc2mZenYkURL1PfxsU M3Oz5ZgdfB5DwVUa+aw== X-Proofpoint-GUID: T3Dc1Ww3JXDhDgCYjV2T9BOcEfmdv_Px X-Authority-Analysis: v=2.4 cv=Yoya1IYX c=1 sm=1 tr=0 ts=6aea54f7 cx=c_pps a=cFYjgdjTJScbgFmBucgdfQ==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=xhLwaI6HiHkcQTGlYsAA:9 a=scEy_gLbYbu1JhEsrz4S:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMTAzMDA4NiBTYWx0ZWRfX29T6YXpKSG0N a5yCpHhezsjRZMq2VGRJlbe/A76/3Xj2ugxn8laWsn7f7OMy6T27y+Vq7RFGEfJN7rxsUouKB1x KWn6ZrnDv9P7fhMegwFHAGq0/ZkHC2c= X-Proofpoint-ORIG-GUID: T3Dc1Ww3JXDhDgCYjV2T9BOcEfmdv_Px X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-03_05,2026-11-03_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 clxscore=1015 suspectscore=0 spamscore=0 phishscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610300000 definitions=main-2611030086 Not every SoC the generic MIPI CSI2 PHY driver supports needs an OPP table: a CSIPHY with only a single, unscaled power-domain has no performance state to vote on, so running its "core" clock through the OPP framework buys nothing over a plain clk_set_rate(). Skip devm_pm_opp_set_clkname()/devm_pm_opp_of_add_table() in probe() and the OPP/performance-state handling in phy_qcom_mipi_csi2_set_clock_rates() when soc_cfg->opp_clk_name is unset, falling back to clk_round_rate()/clk_set_rate() on the timer clock only. x1e80100 still sets opp_clk_name, so this is a no-op for it. Reviewed-by: Jigarkumar Zala Signed-off-by: Anusha Arun Nandi --- .../phy/qualcomm/phy-qcom-mipi-csi2-core.c | 72 ++++++++++--------- 1 file changed, 39 insertions(+), 33 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-mipi-csi2-core.c b/drivers/phy/qualcomm/phy-qcom-mipi-csi2-core.c index 3de25728ed28..181813caf282 100644 --- a/drivers/phy/qualcomm/phy-qcom-mipi-csi2-core.c +++ b/drivers/phy/qualcomm/phy-qcom-mipi-csi2-core.c @@ -32,40 +32,43 @@ phy_qcom_mipi_csi2_set_clock_rates(struct mipi_csi2phy_device *csi2phy, unsigned long opp_rate = link_freq / 4; struct dev_pm_opp *opp; long timer_rate; - int i, pstate; + int i = 0, pstate; int ret; - opp = dev_pm_opp_find_freq_ceil(dev, &opp_rate); - if (IS_ERR(opp)) { - dev_err(csi2phy->dev, "Couldn't find ceiling for %lld Hz\n", - link_freq); - return PTR_ERR(opp); - } + if (csi2phy->soc_cfg->opp_clk_name) { + opp = dev_pm_opp_find_freq_ceil(dev, &opp_rate); + if (IS_ERR(opp)) { + dev_err(csi2phy->dev, "Couldn't find ceiling for %lld Hz\n", + link_freq); + return PTR_ERR(opp); + } - pstate = 0; - for (i = 0; csi2phy->pd_list && i < csi2phy->pd_list->num_pds; i++) { - unsigned int perf; + pstate = 0; + for (i = 0; csi2phy->pd_list && i < csi2phy->pd_list->num_pds; i++) { + unsigned int perf; - if (!csi2phy->soc_cfg->genpds[i].scaled) - continue; + if (!csi2phy->soc_cfg->genpds[i].scaled) + continue; - perf = dev_pm_opp_get_required_pstate(opp, pstate); - pstate += 1; + perf = dev_pm_opp_get_required_pstate(opp, pstate); + pstate += 1; - ret = dev_pm_genpd_set_performance_state(csi2phy->pd_list->pd_devs[i], perf); - if (ret) { - dev_err(csi2phy->dev, "Couldn't set perf state %u\n", - perf); - dev_pm_opp_put(opp); - goto unset_pstate; + ret = dev_pm_genpd_set_performance_state(csi2phy->pd_list->pd_devs[i], + perf); + if (ret) { + dev_err(csi2phy->dev, "Couldn't set perf state %u\n", + perf); + dev_pm_opp_put(opp); + goto unset_pstate; + } } - } - dev_pm_opp_put(opp); + dev_pm_opp_put(opp); - ret = dev_pm_opp_set_rate(dev, opp_rate); - if (ret) { - dev_err(csi2phy->dev, "dev_pm_opp_set_rate() fail\n"); - goto unset_opp_rate; + ret = dev_pm_opp_set_rate(dev, opp_rate); + if (ret) { + dev_err(csi2phy->dev, "dev_pm_opp_set_rate() fail\n"); + goto unset_opp_rate; + } } timer_rate = clk_round_rate(csi2phy->timer_clk, link_freq / 4); @@ -83,7 +86,8 @@ phy_qcom_mipi_csi2_set_clock_rates(struct mipi_csi2phy_device *csi2phy, return 0; unset_opp_rate: - dev_pm_opp_set_rate(dev, 0); + if (csi2phy->soc_cfg->opp_clk_name) + dev_pm_opp_set_rate(dev, 0); unset_pstate: while (i--) { @@ -405,13 +409,15 @@ static int phy_qcom_mipi_csi2_probe(struct platform_device *pdev) if (!csi2phy->timer_clk) return dev_err_probe(dev, -ENODEV, "no timer clock\n"); - ret = devm_pm_opp_set_clkname(dev, csi2phy->soc_cfg->opp_clk_name); - if (ret) - return dev_err_probe(dev, ret, "Failed to set opp clkname\n"); + if (csi2phy->soc_cfg->opp_clk_name) { + ret = devm_pm_opp_set_clkname(dev, csi2phy->soc_cfg->opp_clk_name); + if (ret) + return dev_err_probe(dev, ret, "Failed to set opp clkname\n"); - ret = devm_pm_opp_of_add_table(dev); - if (ret) - return dev_err_probe(dev, ret, "invalid OPP table in device tree\n"); + ret = devm_pm_opp_of_add_table(dev); + if (ret) + return dev_err_probe(dev, ret, "invalid OPP table in device tree\n"); + } num_supplies = csi2phy->soc_cfg->num_supplies; csi2phy->supplies = devm_kzalloc(dev, sizeof(*csi2phy->supplies) * num_supplies, -- 2.34.1