mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: "Günther Noack" <gnoack3000@gmail.com>
Cc: "Mickaël Salaün" <mic@digikod.net>,
	"Günther Noack" <gnoack@google.com>,
	"Shuah Khan" <shuah@kernel.org>,
	linux-security-module@vger.kernel.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/landlock: fix the regex_escape() error check
Date: Tue,  3 Nov 2026 16:49:41 -0500	[thread overview]
Message-ID: <20261103214941.1553946-1-sashal@kernel.org> (raw)
In-Reply-To: <20261103.06edcd6fc9f1@gnoack.org>

On Tue, Nov 03, 2026 at 09:31:33PM +0100, Günther Noack wrote:
> Thanks for the contribution!  I also stumbled across this one when I
> did a wider cleanup, and at the time I came to the conclusion that it
> would be wiser to fix the weird way in which regex_escape() reports
> errors.
>
> https://lore.kernel.org/all/20261008142604.39107-20-gnoack3000@gmail.com/
>
> Does that seem reasonable to you?

Yes, that's better. Your 18/27 also fixes the size miscount after the
escaped path, so it covers everything this patch does. Let's drop this
one in favor of your series.

--
Thanks,
Sasha

      reply	other threads:[~2026-11-03 21:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03 16:39 Sasha Levin
2026-11-03 20:31 ` Günther Noack
2026-11-03 21:49   ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261103214941.1553946-1-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=gnoack3000@gmail.com \
    --cc=gnoack@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mic@digikod.net \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®