From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.179 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793818167; b=09JyF/VRFovetzz7lXgMOjRdbeaNwhkUUp9m91mM9jd7l5Pss352J6vl2xI/sKsV79LQ wlOQNKpIUlrqFFGz+x27RJTphXb3tCxIhoACmr+Yo5yzJwN2VIecijIPPw6ekjIUUeCAf vQNDs2IN+1V5tIeSe3JCLAXUfUoQQmHL7jWZj9Ek65eQviLpPpOx4R4ZEWaWYEpPMcUbq p5VOayceFACaVD29/bNOVXfHcEq62BQB4hcG5uFEV24MkQS0s9j2ZyAfdpK39jUr5gvPM NppQnrk64eaFUmkldB5f7DB5SEAiE2Pp0zEvg9AsnKSv436+kDviMzhQCJt+wcIiJqw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793818167; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:Date:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:References:In-Reply-To:To:Cc:X-Mailer: X-Developer-Signature:X-Developer-Key; bh=0xA1nzke1axFk20N+g0eZRM7/Oalpco/d1jENf6Frus=; b=Id7CN4zUbXoQfc15SLffrnPLzQltStybpx+/jMqeunpR6uelIKkqAIhwugMq+b4rewKR olEkzGKzq4ip4LFGqgTddthR8mzT853Bkxk5EV6u98NzZ1hBEfMzrurfntxBjJ/cIViNZ wUJKF/Afr1PCuse9/sEHD71yE1rMumk0nX0vxs+/WVOwZ3G38UFPKngY9KDJ6zEPjGbY9 GVHQnyRE0zyDABiDu6C3SwjIFpfg6YW3G1zbFomV0CuJ0MTV8dWeJLagjpVEgLEXGI3Cb KLnj/tmhslEc4Dk3PH8TG29LBgTUPX5Yfr98+UhGfcx1wJJp5JZ7369YzDGY1ffirOQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=TruuIUZ3; arc=none smtp.remote-ip=209.85.128.179 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12E296082BCC for ; Wed, 4 Nov 2026 18:49:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 12E296082BCC Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=TruuIUZ3 Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-8ae8607e8afso10621637b3.3 for ; Wed, 04 Nov 2026 10:49:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793818166; x=1794422966; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0xA1nzke1axFk20N+g0eZRM7/Oalpco/d1jENf6Frus=; b=TruuIUZ3C5roWxeoqwyUG8NrdbU5aQ6iVV/aIMZsE4iJrZaM3bx1NtWD7njSSJ6nLi E2PLhyFoBfb2Ou93r01Gd9icP6EFmEAjMcwOyNUiagLM9OTytL+DqIR9m3shMOWoFlZJ zaYwZlKLDl1lzNjZTUDliYubasxsfC8EfGDjygCCWccus4d/K4YkhVGR88OW4ZsHPXpq 9yHQf8PLVqrRG/22SbbZnarWpuI0H2v7jefjMEaQX7mw+lGfqloa8M5681CFfhII4j8d PNvmSYITfAWuWQddEkLFlZDg5vsjaRosdsM20NvMsFpLKOl55tbLACrA3MGFHvpZf6S1 qCfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793818166; x=1794422966; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0xA1nzke1axFk20N+g0eZRM7/Oalpco/d1jENf6Frus=; b=xIPKu2b1ZKGvBSSqHmQ7IsCUKQLFsUDh4Zgb0xrmduZurNiCvyMuiGzOPN83jSyk8h 1bPf7mUixKabmPhVeRbgtYyBuwO1d3n7YIupiYjN/TluDBPsI6SpBFiJqh9sRDWeQSqv 2XqDmGMO7r5XAuOP0k75TR36b2Tu6GyzUOwme/BLGWuztp6/dfS1Yez+houwu687T9jA nEDPLWFkfLNvpbzrk9nOP5OjtdQx4FLSfttscpPFhzbH/kiOhIYSTHkKwLax6P5Z9sBX nFFL0A2EXrVVOrfTugjCUTfixWanb2135CXVtLdrY1PcznA2PLySVG0WKk23W4mcy3hc x5kg== X-Forwarded-Encrypted: i=1; AKwUvBx56rcP3VHoDkMeONHET2GuJHMMPMekm2uFdrwrC4+VjlQYmiTDscpMFtY+ltBW8x8M8doAEzZiL4V3mag=@vger.kernel.org X-Gm-Message-State: APuU4Z8lMlymzz4UctTGjUXZ0Pnl3xshzRi7lpKXUbsHepsFr5lX+eG/ tu5AbPfVHlCP19nV9pqz4CS6CU5uuXuVY28JJIp2PINGWSiHJ1EApd2W8BxQjA== X-Gm-Gg: AYBFou2JyGCAl7/euMvOIUCR8hZ+h6edROpyJUmoh6o+BOwpwqmJMCXt8Mu1YZ+Ie/z fG90+/efkKX49uRZMPjl2f8uKuIC4YjgjENWg+8bnhunhQElLQCNFgyuurSWbInCHoIhQsjVpcR Q8b3JtvUO9QrSWC9QXMnJMvJHyw1LlCt7ynyBmVZHuzm+Yu+aJlpQTnnQHZTLFvuszkmHfCN9s+ N9OTkqAaynngTK2mhHBI3Arc5oYWMBq4OdUUHL26C5v8OrS7suplbnNNsXsnGArivuJRFuGev6l QHvlUD2Rp3cIwA86vD3WsdC4Xsf3rZ9eWevjX/9hyyh3Aw1GJdCzNASaMhpSgJ6pT9GLfCOr/xC Or2EuP9T62Ft2KWvHIcQXhBh5ExCmT2pok6kCi8Ta3raHvpIlhGiozylPX17Dk9TfKxMuEPfZ1z MJB/hhZ6N/KYwOYhY/UOMSumj6Lq6ueCfuR7oe4UpGzlOsxJ4v301EyylwN6s5HNfy/W/cYzIE2 5StvkqyNIHM1Rgab9ul/S6hiPHzyNV05fb81Na8ty8X8mxiO6zv/0LbeL8Lm919Hs8hVlScLJ/n vOpdqDEqOgLrqNJ75QG7HJJmFJoerdya8K+/3kdnIquQLrh5x06dhWhruaFNRCfrurvn2Wr5J+n IzfFXdhR71AOm6irxAGkdCzVCExYcxIE= X-Received: by 2002:a05:690c:ec6:b0:8b0:f1c0:60b8 with SMTP id 00721157ae682-8b2b67d0b17mr92106777b3.64.1793818165983; Wed, 04 Nov 2026 10:49:25 -0800 (PST) Received: from localhost ([2600:1702:7a90:6f9f:66f3:d5d6:2d12:d460]) by smtp.gmail.com with ESMTPSA id 00721157ae682-8b3098c313esm24660157b3.15.2026.11.04.10.49.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2026 10:49:25 -0800 (PST) From: Matt Turner Date: Wed, 04 Nov 2026 13:49:16 -0500 Subject: [PATCH v6 09/13] alpha/perf: report the ProfileMe window count as the sample weight X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261104-alpha-profileme-v6-9-63362e9290a3@gmail.com> References: <20261104-alpha-profileme-v6-0-63362e9290a3@gmail.com> In-Reply-To: <20261104-alpha-profileme-v6-0-63362e9290a3@gmail.com> To: Richard Henderson , Magnus Lindholm , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Matt Turner X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2519; i=mattst88@gmail.com; h=from:subject:message-id; bh=/4EgoGj15UgMHZVbNtflEWxIUyBJ/kuaOxUdsmo8m0w=; b=owGbwMvMwCW25rVmCc8sv+mMp9WSGLJe16lGL9xx9Ng8pZiqqMXzipkVaysPR7286a6/9IZKX +tD2z7Tjo8sDGJcDDPFFFni1iuyzGrbsdTntPQvmDmsTCBDpEUaGICAhYEvNzGv1EjHSM9U21DP EMjQMYqHyOkxaGQWF5emFummFRQ55OWXJJZk5ucV6+UXpOYVpBfopWWmlWRk5BcVpwKN0MtLLTF 1dXQzMjQwsXS0MHOycDQ1cXZ2MnRyc3R0dnUysjQ3MXC2dDRxtTRn4OIUgLkmbi8jw+xy1nI9rf 8b70+ZfmzBRf2V7Le2BfoZ/rBpE9cRkxVsLGVk2K/gbLTtW8yc6ezONqE87DebXOanv7mgq/5Az GKp15Q0ZgA= X-Developer-Key: i=mattst88@gmail.com; a=openpgp; fpr=3BB639E56F861FA2E86505690FDD682D974CA72A What PCTR1 counted during the ProfileMe window, the inum retire delay for cycles:p or the window length for instructions:p, is only available in the PERF_SAMPLE_RAW data. Report it in var1_dw of the sample weight, which the weight and local_weight sort keys read. It is 20 bits, so it fits. As Alpha is little-endian, this is also the right value for plain PERF_SAMPLE_WEIGHT, which is what perf record -W asks for. Samples that fall back to the interrupted PC get no weight, as it belongs to a different instruction. Suggested-by: Ian Rogers Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Matt Turner --- arch/alpha/kernel/perf_event.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/arch/alpha/kernel/perf_event.c b/arch/alpha/kernel/perf_event.c index b33677cc23ca..c9ab40ff76ad 100644 --- a/arch/alpha/kernel/perf_event.c +++ b/arch/alpha/kernel/perf_event.c @@ -1068,7 +1068,7 @@ static void alpha_perf_event_profileme(struct perf_event *event, struct perf_raw_record raw; struct perf_sample_data data; struct pt_regs *pm_regs; - bool pc_only = false; + bool pc_only = false, exact = true; unsigned long pctr_ctl, i_stat, pmpc, ovr, pc, saved_pc, saved_ps; pctr_ctl = wrperfmon(PERFMON_CMD_READ, 0); @@ -1115,6 +1115,7 @@ static void alpha_perf_event_profileme(struct perf_event *event, pc = pmpc & EV67_PMPC_PC_MASK; if (pmpc & EV67_PMPC_PAL) { pc = regs->pc; + exact = false; } else if (pc < TASK_SIZE && !user_mode(regs)) { if (is_user_task(current)) { pc_only = true; @@ -1124,6 +1125,7 @@ static void alpha_perf_event_profileme(struct perf_event *event, pm_regs->ps = 8; } else { pc = regs->pc; + exact = false; } } else if (pc >= TASK_SIZE && user_mode(regs)) { pm_regs = this_cpu_ptr(&alpha_profileme_regs); @@ -1157,6 +1159,15 @@ static void alpha_perf_event_profileme(struct perf_event *event, }; perf_sample_save_raw_data(&data, event, &raw); + /* The count belongs to the profiled instruction, not the interrupted PC. */ + if (exact && (event->attr.sample_type & PERF_SAMPLE_WEIGHT_TYPE)) { + /* perf_sample_data_init() does not clear it. */ + data.weight.full = 0; + data.weight.var1_dw = (pctr_ctl >> EV67_PCTR_1_COUNT_SHIFT) & + EV67_PCTR_1_COUNT_MASK; + data.sample_flags |= PERF_SAMPLE_WEIGHT_TYPE; + } + if (!alpha_perf_event_set_period(event, hwc, 0)) return; -- 2.55.0