From: Felix Gu <ustc.gu@gmail.com>
To: Mark Brown <broonie@kernel.org>, Felipe Balbi <balbi@ti.com>,
Sourav Poddar <sourav.poddar@ti.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Mark Brown <broonie@linaro.org>, Felix Gu <ustc.gu@gmail.com>
Subject: [PATCH 2/3] spi: ti-qspi: Abort probe when clock lookup fails
Date: Wed, 04 Nov 2026 22:08:11 +0800 [thread overview]
Message-ID: <20261104-ti-qspi-v1-2-c286943c22c3@gmail.com> (raw)
In-Reply-To: <20261104-ti-qspi-v1-0-c286943c22c3@gmail.com>
Return the clock lookup error instead of continuing with an error
pointer that subsequent transfers can pass to clk_get_rate().
Fixes: 505a14954e2d ("spi/qspi: Add qspi flash controller")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
---
drivers/spi/spi-ti-qspi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
index 0cc8c2d52226..2026fbcbeb90 100644
--- a/drivers/spi/spi-ti-qspi.c
+++ b/drivers/spi/spi-ti-qspi.c
@@ -844,6 +844,7 @@ static int ti_qspi_probe(struct platform_device *pdev)
if (IS_ERR(qspi->fclk)) {
ret = PTR_ERR(qspi->fclk);
dev_err(&pdev->dev, "could not get clk: %d\n", ret);
+ return ret;
}
pm_runtime_use_autosuspend(&pdev->dev);
--
2.53.0
next prev parent reply other threads:[~2026-11-04 14:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 14:08 [PATCH 0/3] spi: ti-qspi: three cleanups Felix Gu
2026-11-04 14:08 ` [PATCH 1/3] spi: ti-qspi: Remove unbalanced runtime PM put on removal Felix Gu
2026-11-04 14:08 ` Felix Gu [this message]
2026-11-04 14:08 ` [PATCH 3/3] spi: ti-qspi: Correct runtime PM error message Felix Gu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261104-ti-qspi-v1-2-c286943c22c3@gmail.com \
--to=ustc.gu@gmail.com \
--cc=balbi@ti.com \
--cc=broonie@kernel.org \
--cc=broonie@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®