From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793751650; b=qdRVI6iRF9R31D2AxOA0CGUHaWanPWKgYpy+g36IMWRp54hX7az2ylg5eQ3jqU8mEwb6 QXiCfBoN0PxEBFA/H/7Ku6RzKesLugQvQ0Gtni50F0bkZr1Jy860pnYdxsn86V4X0ExCA 2aqX1oiWoOsTwAPmGesSdIyMk1QJSnho5z+zcJMT/7oR1KVtG0sKi/ujmcUrvHte0HYdU 3niJ30AUdptS3NtK4gLdc7eun6JRb44zi1XvypBsgOKII6kVvCvu9yDYYgLAGSiQigp2t Vg9Da3fzPFISnCGhbE8i8T+4S5ni0RDzr76SXvJqfrEFwEmAxJBBO7YCzee6QOzJ3mA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793751650; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Date:From: To:Cc:Subject:Message-ID:In-Reply-To:References:Organization:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding: X-Proofpoint-Spam-Info:X-Proofpoint-ORIG-GUID: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-GUID:X-Authority-Analysis: X-Proofpoint-Virus-Version:X-Proofpoint-Spam-Details; bh=OfnNX61NtQ31WOejDUqbkK4HwJYzLMGKN6Wyl9m2oIs=; b=uI2Ztg7R2XR4cia4RqscrnYQiUFtzXGm4BW1YjPtGiV+mAgplrRzGtDmPSjb0ylBjOSb c0gFYjyzm3kb8BvqQ+C30fSZMMxq348gQIuP6aOPO1reDm431hrAiCqjIJh6Z4zpo7GoU DVOnHgR1529OyCaPG/YW4NlgpUIv40X40p3cYXjeXpzDt31fK65VYo1NJduDHQCJmLhBK guFxI5iaQo39D+ILmjI7+c0pcCvmflZWFICSbgO/AnkswAioAPXD8BhYWR5ZYRsG/L6yQ 7OOy39COFdPDVPj6FNP5mOrt25RHifFYVwxtoi2zN0Z/d6PyXiFbOFqR80ePrwtNeuw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=O9aA2zlY; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b="Y7G/sx/h"; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8C25606A329 for ; Wed, 4 Nov 2026 00:20:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D8C25606A329 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=O9aA2zlY; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=Y7G/sx/h Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6A3LKlU34033341 for ; Wed, 4 Nov 2026 00:20:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OfnNX61NtQ31WOejDUqbkK4HwJYzLMGKN6Wyl9m2oIs=; b=O9aA2zlY2c8+9sxr hXQL4F6wd2IkKQ+VwK7lMQzQ46GiOvIpxp91H2p0JDnpQL8YFnWTpiDbyrffdXu7 ypY463gCS0OkSDzuxQzxK/Fbbir96u+n7p0fYBJeRuc9C875OBzhe9jDYuN2NPjL kvpKI4W6w90/l1N8jpg98FvxduvmBFocU8BHFyTU0S89lQLzNwifnlKqgytRaF6h mIYsWzV32M5cjjVSu7FDv46pqfrwr8BKkbkjOeqD7M8Vvy2X4rdwzkuJrz6tPmTT +4mKx6bfXbBsk9xVem0omadSRCKRthgz4+7mXvn7GJecdizYtWODemcR+ODHZpA3 ou5kgw== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hqhypj8ak-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Nov 2026 00:20:48 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3b08364cdc7so201714a91.0 for ; Tue, 03 Nov 2026 16:20:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793751648; x=1794356448; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=OfnNX61NtQ31WOejDUqbkK4HwJYzLMGKN6Wyl9m2oIs=; b=Y7G/sx/hkyqa7plfa6wvCEbOgFJjXACTY/Q9dWAqr4XFbRQqx4RKWhNoHxtlKW6u0o ICRvbwMs6+XRgTMt8A8Ix5IPX5DKYBkDRLlhJO7d2/gKO2yMnRlcXLS7fDjIto9osA93 eDhOgPR3fVpF3/J1yTwph/607e2A1Q5Gfh/1dVJSBMKm5OCMLc+zowF66ekVuXcvk3jr ARYpzIFR1okZb7AF8AEfazXOtF1S24DUhbO3s9jlyliLGtj0MlPObTgwzeJfByU0ye+P XQ6iNYOfXQCMNLnXlT34cIKG0dO+OUM+DbWUDDwpjx5LKpzLojgNYDoXT1ysnRkKtmI2 rKqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793751648; x=1794356448; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OfnNX61NtQ31WOejDUqbkK4HwJYzLMGKN6Wyl9m2oIs=; b=AeARMweNMw2D4wbzTdVE6QNgPLggg9pUZAeScyqFEQgcu7EzwghR5wdUp9uHbLCtJy vKl8IFGzfU+PtuoZOcxgGvgvSOGFEZun533fJAGRBiNIqz3QsAThHhWY60zXbYBb3qP1 oB1imKniYmMQvNidQYKJY6mGkdobykrOr4Eeca9Uwlzi8fqpBnbA3u2viRwYUsAdc3PR GqtqFgVFPiYWdzSxwEtBLhiZXcvpz8Cet36jZlqzt6KTG41zBy02DjCWDZiD6XQMqxB5 S9v9wM8N0ssmAravwHqy8DgjMebkeyffvjF41T2RuinxmOqFNbfbuRfHkwirdOcJUonF jcxA== X-Forwarded-Encrypted: i=1; AKwUvBxg7vIRvv76/yztKVghbkzY6+QNSciOevGLfasTy43ku7uGRxZ5tfZnVH9aqopkAyQgt/sHHqTj6KqrSRc=@vger.kernel.org X-Gm-Message-State: APuU4Z/l3Su9CaiEuwE893T5aeU5sWan0XyYM7odXcJgwgakSm2WeRo0 VmS4i5r9D019mCHiIYVu0BCUDupDD/NbsxqAr2XWyh85Id6R3i/x4llyxR7MMUdXGlMpO7ZOBOa 1gG5knOGNCsk5d6OPnIbFkmkNMkEZLCViIDbhzAK/gmTxnoGnljB+0qSyRrScNyLLdAw= X-Gm-Gg: AYBFou1pJMgqrVFy6Y5VvW8s8vjF7zVxMxWy1UH1oo8umKt14Te8/yQz52mMDWQj48e y8L5HuXbTdQUjN8wMA29aG/rjP9zWz535zc28Z2XOxTRYvvNeOt/ftPl0jPj9RHO8zb4bDa5Ui/ Vkf4jrbJHZg19AasCQxsHos56iJqpnG8EvKD69tasbi3LrX1uDS9/ECsdA/hDkjHma1Vm8QgwWN YANJJP9dxVNMicIcPEfg+1MlkPHDa2g3PJQXx7SpKJWO7AU4cMheSELguof6VbVSS+Uricf1/1Z MifqhP56L6Q7XG5XzhiakeiUOWHZyCrNm9kCAZCGYNCSFwfI7X5fTLwqNsj5WeNx2P5npwzudu9 HjZw558pjrukmv9CwZJPHyL9MKAWIABSHOwSEiNGnIyz2IKuC5MW/0Y8XxV5XGMu9/Q== X-Received: by 2002:a17:90b:4c12:b0:3ae:5572:c4d1 with SMTP id 98e67ed59e1d1-3ae8986e3bamr13180560a91.62.1793751647546; Tue, 03 Nov 2026 16:20:47 -0800 (PST) X-Received: by 2002:a17:90b:4c12:b0:3ae:5572:c4d1 with SMTP id 98e67ed59e1d1-3ae8986e3bamr13180527a91.62.1793751647042; Tue, 03 Nov 2026 16:20:47 -0800 (PST) Received: from jic23-hlaptop ([50.35.44.179]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3b094453532sm1090412a91.3.2026.11.03.16.20.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 16:20:46 -0800 (PST) Date: Wed, 4 Nov 2026 00:20:42 +0000 From: Jonathan Cameron To: Rodrigo Alencar via B4 Relay Cc: rodrigo.alencar@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux@analog.com, devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, linux-doc@vger.kernel.org, Olivier Moysan , Jonathan Cameron , David Lechner , Andy Shevchenko , Michael Hennerich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Jonathan Corbet , Shuah Khan , Randy Dunlap Subject: Re: [PATCH v3 01/10] iio: frequency: ad9910: powerdown fix Message-ID: <20261104002042.10064e8b@jic23-hlaptop> In-Reply-To: <20261103-ad9910-backend-support-v3-1-0e9224ddf7b7@analog.com> References: <20261103-ad9910-backend-support-v3-0-0e9224ddf7b7@analog.com> <20261103-ad9910-backend-support-v3-1-0e9224ddf7b7@analog.com> Organization: Qualcomm X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYxMTA0MDAwMCBTYWx0ZWRfX06pXTHUsQsih EW5NytXDgc5+zfCDwhQgrC1dA8zSB8OI1/Z7+AgPxhU/kwCAVpKwc19gvr7P4YyA8m6bTkBXAVu QyaBw3/Th++HEbR9dV74zUSSHgYEBqk= X-Proofpoint-ORIG-GUID: zyotimM0HHxOpmnrmmJSfh9-hm2x33l5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTA0MDAwMCBTYWx0ZWRfX9ikn1klffWjH st5LHqjH/W6iDd1AEqEteryxPsI4WRyIn3Jd0QUoh/2qbuPYBo7nT5UzeaJIjLvzbbX1V8atxrz s7krvgtCMbvu4QEmEVHK40/uKTa/TVyOvJpAXdzsyESB2v8PVn4lCsLCjPgbPooPYg2Ts6Xo9Dy KJBfbyaJa44ySOkRipUqvBzxzLrTyKBmUlXjuFZ60ttun1E27TdyIYca3MGCj2JXCwkS+i/uc3R 9xo8Mm682JosaTy1zmym1l0Z7wY6dUusGDEcryii1Dz4CcJxTJjC11HAu/vbWhBcRyDnwfJUkb4 3oIXvisivGbIG0ldjpOHZfDhLnjsNu1Hyd5G92WfVDlNodbIMhonrsxETOFhkZWX3jmVqM2zFzV Oyo5ky35ahPkcYAlkbwQncb2YqRa0uoUJfBFOgZYdScX6Nyc+IspccStjY9ObDBrvvo5v2bJwkG TLtP7/dc6pvxLNFuTYA== X-Proofpoint-GUID: zyotimM0HHxOpmnrmmJSfh9-hm2x33l5 X-Authority-Analysis: v=2.4 cv=T94Z3PKQ c=1 sm=1 tr=0 ts=6aea7a60 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=aNnz9XPx1a4JIXSYt2cE/A==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=gAnH3GRIAAAA:8 a=Pob1JPmMRzAnXopCxDUA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-03_05,2026-11-03_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 clxscore=1015 adultscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610300000 definitions=main-2611040000 On Tue, 03 Nov 2026 11:52:57 -0300 Rodrigo Alencar via B4 Relay wrote: > From: Rodrigo Alencar >=20 > Enable the software powerdown on all the applicable CFR1 register bits at > once with an IO update. >=20 > It turns out that DIGITAL and REFCLK_INPUT powerdown do need an IO update > when enabling the powerdown, but that is not the case when powering it up > again. It is an asymmetric behavior, which was observed while profiling > power consumption in the lab. Just to be absolutely sure I understand this right... The bug today wastes power but otherwise doesn't break using the device? I'm just trying to judge urgency of applying this. Is it fine to go with the changes that follow later in the series or do I need to rush it in, potentially delaying the rest. Thanks Jonathan >=20 > Fixes: 22452fe6cd08 ("iio: frequency: ad9910: initial driver implementati= on") > Reviewed-by: Nuno S=C3=A1 > Signed-off-by: Rodrigo Alencar > --- > drivers/iio/frequency/ad9910.c | 26 ++++++++------------------ > 1 file changed, 8 insertions(+), 18 deletions(-) >=20 > diff --git a/drivers/iio/frequency/ad9910.c b/drivers/iio/frequency/ad991= 0.c > index 04a4e184b873..8bc24d0b7442 100644 > --- a/drivers/iio/frequency/ad9910.c > +++ b/drivers/iio/frequency/ad9910.c > @@ -621,26 +621,16 @@ static int ad9910_sw_powerdown_set(struct ad9910_st= ate *st, bool enable) > if (ad9910_sw_powerdown_get(st) =3D=3D enable) > return 0; > =20 > - /* > - * When powering down, the DAC and AUX_DAC (SW1) must be powered down > - * first, as they require an I/O update to take effect. The opposite is > - * true when powering up, the DAC and AUX_DAC must be powered up last, > - * i.e., after the DIGITAL and REFCLK_INPUT (SW0) power up. > - */ > - if (enable) { > - ret =3D ad9910_reg32_update(st, AD9910_REG_CFR1, > - AD9910_CFR1_SW1_POWER_DOWN_MSK, > - AD9910_CFR1_SW1_POWER_DOWN_MSK, > - true); > - if (ret) > - return ret; > - > + if (enable) > return ad9910_reg32_update(st, AD9910_REG_CFR1, > - AD9910_CFR1_SW0_POWER_DOWN_MSK, > - AD9910_CFR1_SW0_POWER_DOWN_MSK, > - false); > - } > + AD9910_CFR1_SW_POWER_DOWN_MSK, > + AD9910_CFR1_SW_POWER_DOWN_MSK, > + true); > =20 > + /* > + * When powering up, the DIGITAL and REFCLK_INPUT (SW0) must be powered > + * up first, as they do not require an I/O update to take effect. > + */ > ret =3D ad9910_reg32_update(st, AD9910_REG_CFR1, > AD9910_CFR1_SW0_POWER_DOWN_MSK, 0, false); > if (ret) >=20