mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	 Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
	 Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	 Quentin Monnet <qmo@kernel.org>,
	Josh Poimboeuf <jpoimboe@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	 Eduard Zingerman <eddyz87@gmail.com>,
	Kumar Kartikeya Dwivedi <memxor@gmail.com>,
	 Martin KaFai Lau <martin.lau@linux.dev>,
	Song Liu <song@kernel.org>,
	 Yonghong Song <yonghong.song@linux.dev>,
	James Clark <james.clark@linaro.org>,  Leo Yan <leo.yan@arm.com>,
	linux-perf-users@vger.kernel.org, bpf@vger.kernel.org,
	 linux-kernel@vger.kernel.org
Subject: [PATCH v3 0/4] tools build: Fixes for libbfd -lzstd dependency
Date: Tue,  3 Nov 2026 20:30:02 -0800	[thread overview]
Message-ID: <20261104043006.1199857-1-irogers@google.com> (raw)

This series addresses build problems when linking against static
libbfd/libopcodes on distributions like Fedora where binutils is built
with zstd section decompression support (requiring '-liberty -lz -lzstd'
together).

In v2, commit 89d001d48ec7 ("tools build: Add zstd to the binutils
library feature tests") landed in tools/build/feature/Makefile at the
same time, creating a merge conflict and only adding '|| $(BUILD_BFD)
-lzstd' without '-liberty -lz' or the corresponding
libbfd-liberty-z-zstd feature check in perf and bpftool (so even if
test-libbfd.bin passed with -lzstd, perf and bpftool would link only
'-lbfd -lopcodes' without '-lzstd').

v3 rebases onto perf-tools-next (v7.4-rc1), fixes commit 89d001d48ec7 in
patch 1/4, collects the Acked-by tags from Quentin Monnet and Peter
Zijlstra, updates the LIBOPCODES_LIBS comment in tools/objtool/Makefile,
and moves the AI assistance disclosure from commit trailers to the cover
letter.

v2: https://lore.kernel.org/all/20260909204122.1993010-1-irogers@google.com/
v1: https://lore.kernel.org/linux-perf-users/20260909181030.1870496-1-irogers@google.com/

AI Assistance Disclosure (per Documentation/process/coding-assistants.rst):
- Tools used: Antigravity coding assistant and Sashiko automated patch
  review.
- Summary of prompts and assistance: Rebased the 4-patch series onto
  perf-tools-next, resolved the conflict with commit 89d001d48ec7 in
  tools/build/feature/Makefile, incorporated review feedback and
  Acked-by tags, and verified with scripts/checkpatch.pl.

Ian Rogers (4):
  tools build: Add explicitly sequenced -lzstd to libbfd feature
    fallback
  perf build: Add explicitly sequenced -lzstd to libbfd feature fallback
  bpftool: Add explicitly sequenced -lzstd to libbfd feature fallback
  objtool: Add explicitly sequenced -lzstd to libopcodes fallback

 tools/bpf/bpftool/Makefile   |  4 ++++
 tools/build/Makefile.feature |  3 ++-
 tools/build/feature/Makefile | 19 +++++++++++++------
 tools/objtool/Makefile       |  7 ++++---
 tools/perf/Makefile.config   |  3 +++
 5 files changed, 26 insertions(+), 10 deletions(-)

-- 
2.56.0.385.gac671c819a-goog


             reply	other threads:[~2026-11-04  4:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04  4:30 Ian Rogers [this message]
2026-11-04  4:30 ` [PATCH v3 1/4] tools build: Add explicitly sequenced -lzstd to libbfd feature fallback Ian Rogers
2026-11-04  5:03   ` bot+bpf-ci
2026-11-04  4:30 ` [PATCH v3 2/4] perf " Ian Rogers
2026-11-04  4:30 ` [PATCH v3 3/4] bpftool: " Ian Rogers
2026-11-04  4:30 ` [PATCH v3 4/4] objtool: Add explicitly sequenced -lzstd to libopcodes fallback Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261104043006.1199857-1-irogers@google.com \
    --to=irogers@google.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=jpoimboe@kernel.org \
    --cc=leo.yan@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=memxor@gmail.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=qmo@kernel.org \
    --cc=song@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®