From: Weilin Tong <tongweilin@linux.alibaba.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Ryan Roberts <ryan.roberts@arm.com>
Cc: David Hildenbrand <david@kernel.org>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2] tools/mm/thpmaps: handle carriage returns and non-UTF-8 filenames
Date: Wed, 4 Nov 2026 14:16:41 +0800 [thread overview]
Message-ID: <20261104061641.1115805-1-tongweilin@linux.alibaba.com> (raw)
VMAList opens smaps with universal newline handling and strict decoding.
A carriage return in a mapped filename can split a header into multiple
records, while non-UTF-8 bytes cause UnicodeDecodeError.
Read LF-terminated records and use surrogateescape to preserve filename
bytes. Escape filename characters that stdout cannot encode to avoid
UnicodeEncodeError when printing mapping names.
Fixes: 2444172cfde4 ("tools/mm: add thpmaps script to dump THP usage info")
Suggested-by: Andrew Morton <akpm@linux-foundation.org>
Link: https://lore.kernel.org/linux-mm/20261101211644.c63a2028bbede0f763f41f80@linux-foundation.org/
Signed-off-by: Weilin Tong <tongweilin@linux.alibaba.com>
---
Changes in v2:
- Escape unencodable mapping names in vma_print() (Sashiko).
- Rebase onto mm-new.
Link to v1: https://lore.kernel.org/linux-mm/20261102085419.696232-1-tongweilin@linux.alibaba.com/
tools/mm/thpmaps | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tools/mm/thpmaps b/tools/mm/thpmaps
index a1a9bc30514f..0e17723515cd 100644
--- a/tools/mm/thpmaps
+++ b/tools/mm/thpmaps
@@ -196,7 +196,8 @@ class VMAList:
# instance to receive VMAs.
def __init__(self, pid='self', stats=[]):
self.vmas = []
- with open(f'/proc/{pid}/smaps', 'r') as file:
+ with open(f'/proc/{pid}/smaps', 'r', newline='\n',
+ errors='surrogateescape') as file:
for line in file:
elements = line.rstrip('\n').split(maxsplit=5)
if '-' in elements[0]:
@@ -363,12 +364,14 @@ def cont_parse(vma, order, ranges, anons, heads):
def vma_print(vma, pid):
# Prints a VMA instance in a format similar to smaps. The main difference is
# that the pid is included as the first value.
+ name = vma.name.encode(sys.stdout.encoding, errors='backslashreplace')
+ name = name.decode(sys.stdout.encoding)
print("{:010d}: {:016x}-{:016x} {}{}{}{} {:08x} {:02x}:{:02x} {:08x} {}"
.format(
pid, vma.start, vma.end,
'r' if vma.read else '-', 'w' if vma.write else '-',
'x' if vma.execute else '-', 'p' if vma.private else 's',
- vma.pgoff, vma.major, vma.minor, vma.inode, vma.name
+ vma.pgoff, vma.major, vma.minor, vma.inode, name
))
base-commit: 74d73ffcffe03804f97e9fb82301dadf75671282
reply other threads:[~2026-11-04 6:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261104061641.1115805-1-tongweilin@linux.alibaba.com \
--to=tongweilin@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®